From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Date: Tue, 17 May 2016 13:01:51 +0000 (-0400)
Subject: Fix: macro compares unsigned to 0 (no effect)
X-Git-Tag: v2.6.3~33
X-Git-Url: https://git.lttng.org/?a=commitdiff_plain;h=5cb6809197b4e8cac4d7649081388e33bedaebbf;hp=440e7c9b2a9f4b1df8fbd16d021fbbed361cb84c;p=lttng-tools.git

Fix: macro compares unsigned to 0 (no effect)

Found by Coverity:

CID 1262117 (#1 of 1): Macro compares unsigned to 0
(NO_EFFECT)unsigned_compare: This greater-than-or-equal-to-zero
comparison of an unsigned value is always true. events->nb_fd >= 0U.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
---

diff --git a/src/common/compat/compat-epoll.c b/src/common/compat/compat-epoll.c
index 614f166ff..cf9f77102 100644
--- a/src/common/compat/compat-epoll.c
+++ b/src/common/compat/compat-epoll.c
@@ -209,7 +209,6 @@ int compat_epoll_wait(struct lttng_poll_event *events, int timeout)
 		ERR("Wrong arguments in compat_epoll_wait");
 		goto error;
 	}
-	assert(events->nb_fd >= 0);
 
 	if (events->nb_fd == 0) {
 		errno = EINVAL;