X-Git-Url: https://git.lttng.org/?a=blobdiff_plain;f=urcu-qsbr.c;h=5f9e46dc28f6f88d11004c95acda61bd24643543;hb=ac258107eb2e669d6f8210c86164f1b2a028f5fc;hp=4ce2f9acdea1e1758f626f3dc14630922ab65be6;hpb=ff2f67a0a2168bb1f0114af901e5e8e6ddce076b;p=urcu.git

diff --git a/urcu-qsbr.c b/urcu-qsbr.c
index 4ce2f9a..5f9e46d 100644
--- a/urcu-qsbr.c
+++ b/urcu-qsbr.c
@@ -32,6 +32,7 @@
 #include <errno.h>
 #include <poll.h>
 
+#define BUILD_QSBR_LIB
 #include "urcu-qsbr-static.h"
 /* Do not #define _LGPL_SOURCE to ensure we can emit the wrapper symbols */
 #include "urcu-qsbr.h"
@@ -41,20 +42,20 @@ pthread_mutex_t urcu_mutex = PTHREAD_MUTEX_INITIALIZER;
 /*
  * Global grace period counter.
  */
-long urcu_gp_ctr = 0;
+unsigned long urcu_gp_ctr = RCU_GP_ONLINE;
 
 /*
  * Written to only by each individual reader. Read by both the reader and the
  * writers.
  */
-long __thread rcu_reader_qs_gp;
+unsigned long __thread rcu_reader_qs_gp;
 
 /* Thread IDs of registered readers */
 #define INIT_NUM_THREADS 4
 
 struct reader_registry {
 	pthread_t tid;
-	long *rcu_reader_qs_gp;
+	unsigned long *rcu_reader_qs_gp;
 };
 
 #ifdef DEBUG_YIELD
@@ -105,18 +106,10 @@ static void force_mb_single_thread(struct reader_registry *index)
 }
 #endif /* #ifdef HAS_INCOHERENT_CACHES */
 
-static void force_mb_all_threads(void)
-{
-	smp_mb();
-}
-
 static void wait_for_quiescent_state(void)
 {
 	struct reader_registry *index;
 
-        if (rcu_reader_qs_gp & 1)
-            rcu_reader_qs_gp = urcu_gp_ctr + 1;
-
 	if (!registry)
 		return;
 	/*
@@ -124,8 +117,7 @@ static void wait_for_quiescent_state(void)
 	 */
 	for (index = registry; index < registry + num_readers; index++) {
 #ifndef HAS_INCOHERENT_CACHES
-		while (rcu_gp_ongoing(index->rcu_reader_qs_gp) &&
-		       (*index->rcu_reader_qs_gp - urcu_gp_ctr < 0))
+		while (rcu_gp_ongoing(index->rcu_reader_qs_gp))
 			cpu_relax();
 #else /* #ifndef HAS_INCOHERENT_CACHES */
 		int wait_loops = 0;
@@ -133,8 +125,7 @@ static void wait_for_quiescent_state(void)
 		 * BUSY-LOOP. Force the reader thread to commit its
 		 * rcu_reader_qs_gp update to memory if we wait for too long.
 		 */
-		while (rcu_gp_ongoing(index->rcu_reader_qs_gp) &&
-		       (*index->rcu_reader_qs_gp - urcu_gp_ctr < 0)) {
+		while (rcu_gp_ongoing(index->rcu_reader_qs_gp)) {
 			if (wait_loops++ == KICK_READER_LOOPS) {
 				force_mb_single_thread(index);
 				wait_loops = 0;
@@ -148,27 +139,27 @@ static void wait_for_quiescent_state(void)
 
 void synchronize_rcu(void)
 {
-	int was_online;
+	unsigned long was_online;
 
-	was_online = rcu_reader_qs_gp & 1;
+	was_online = rcu_reader_qs_gp;
 
 	/*
 	 * Mark the writer thread offline to make sure we don't wait for
 	 * our own quiescent state. This allows using synchronize_rcu() in
 	 * threads registered as readers.
 	 */
+	smp_mb();
 	if (was_online)
-		_rcu_thread_offline();
+		STORE_SHARED(rcu_reader_qs_gp, 0);
 
 	internal_urcu_lock();
-	force_mb_all_threads();
-	urcu_gp_ctr += 2;
+	STORE_SHARED(urcu_gp_ctr, urcu_gp_ctr + RCU_GP_COUNT);
 	wait_for_quiescent_state();
-	force_mb_all_threads();
 	internal_urcu_unlock();
 
 	if (was_online)
-		_rcu_thread_online();
+		_STORE_SHARED(rcu_reader_qs_gp, LOAD_SHARED(urcu_gp_ctr));
+	smp_mb();
 }
 
 /*