X-Git-Url: https://git.lttng.org/?a=blobdiff_plain;f=tests%2Funit%2Ftest_utils_compat_poll.c;h=41ff237d861d5e198840678eb047dee99fb6a733;hb=898ba13216992affd6cb40fe11c64bdc6e65ca9e;hp=24a74d76f753018b6599161070b1c1d5725588e5;hpb=41b42b3b7f1d94d5caff7e6ecf1a8b3f1f1441ae;p=lttng-tools.git

diff --git a/tests/unit/test_utils_compat_poll.c b/tests/unit/test_utils_compat_poll.c
index 24a74d76f..41ff237d8 100644
--- a/tests/unit/test_utils_compat_poll.c
+++ b/tests/unit/test_utils_compat_poll.c
@@ -5,14 +5,8 @@
  *
  * Copyright (C) 2019 Yannick Lamarre <ylamarre@efficios.com>
  *
- * This program is free software; you can redistribute it and/or modify it
- * under the terms of the GNU General Public License as published by as
- * published by the Free Software Foundation; only version 2 of the License.
+ * SPDX-License-Identifier: GPL-2.0-only
  *
- * This program is distributed in the hope that it will be useful, but WITHOUT
- * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
- * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
- * more details.
  */
 
 #include <assert.h>
@@ -49,9 +43,9 @@ int lttng_opt_mi;
 #define MAGIC_VALUE ((char) 0x5A)
 
 #ifdef HAVE_EPOLL
-#define NUM_TESTS 46
+#define NUM_TESTS 47
 #else
-#define NUM_TESTS 45
+#define NUM_TESTS 46
 #endif
 
 #ifdef HAVE_EPOLL
@@ -71,7 +65,7 @@ void test_epoll_compat(void)
 }
 #endif
 
-void test_alloc(void)
+static void test_alloc(void)
 {
 	struct lttng_poll_event poll_events;
 
@@ -92,7 +86,7 @@ void test_alloc(void)
 }
 
 /* Tests stuff related to what would be handled with epoll_ctl. */
-void test_add_del(void)
+static void test_add_del(void)
 {
 	struct lttng_poll_event poll_events;
 
@@ -101,7 +95,7 @@ void test_add_del(void)
 	ok(lttng_poll_add(&poll_events, 1, LPOLLIN) != 0, "Adding to uninitialized structure fails");
 	ok(lttng_poll_add(&poll_events, -1, LPOLLIN) != 0, "Adding invalid FD fails");
 
-	lttng_poll_create(&poll_events, 1, 0);
+	ok(lttng_poll_create(&poll_events, 1, 0) == 0, "Create a poll set succeeds");
 	ok(LTTNG_POLL_GETNB(&poll_events) == 0, "Set created empty");
 
 	ok(lttng_poll_add(NULL, 1, LPOLLIN) != 0, "Adding to NULL set fails");
@@ -130,7 +124,7 @@ void test_add_del(void)
 	lttng_poll_clean(&poll_events);
 }
 
-void test_mod_wait(void)
+static void test_mod_wait(void)
 {
 	struct lttng_poll_event poll_events;
 	struct lttng_poll_event cpoll_events;
@@ -186,7 +180,7 @@ void test_mod_wait(void)
 	}
 }
 
-void test_func_def(void)
+static void test_func_def(void)
 {
 #ifdef LTTNG_POLL_GETFD
 #define PASS_GETFD 1