X-Git-Url: https://git.lttng.org/?a=blobdiff_plain;f=tests%2Fregression%2Fust%2Fperiodical-metadata-flush%2Ftest_periodical_metadata_flush;h=f1132c2e49e9218b465f1688b037f146a1891713;hb=HEAD;hp=1a2ff96557782d11d4bcbf9e3509e4068f49c1dd;hpb=2345b91fe4d88812a0cfe96040d7c87b01f0380b;p=lttng-tools.git diff --git a/tests/regression/ust/periodical-metadata-flush/test_periodical_metadata_flush b/tests/regression/ust/periodical-metadata-flush/test_periodical_metadata_flush index 1a2ff9655..f1132c2e4 100755 --- a/tests/regression/ust/periodical-metadata-flush/test_periodical_metadata_flush +++ b/tests/regression/ust/periodical-metadata-flush/test_periodical_metadata_flush @@ -1,23 +1,13 @@ #!/bin/bash # -# Copyright (C) - 2012 David Goulet +# Copyright (C) 2012 David Goulet # -# This library is free software; you can redistribute it and/or modify it under -# the terms of the GNU Lesser General Public License as published by the Free -# Software Foundation; version 2.1 of the License. -# -# This library is distributed in the hope that it will be useful, but WITHOUT -# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS -# FOR A PARTICULAR PURPOSE. See the GNU Lesser General Public License for more -# details. -# -# You should have received a copy of the GNU Lesser General Public License -# along with this library; if not, write to the Free Software Foundation, Inc., -# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA +# SPDX-License-Identifier: LGPL-2.1-only + TEST_DESC="UST tracer - Tracing with per UID buffers and periodical flush" -CURDIR=$(dirname $0)/ -TESTDIR=$CURDIR/../../.. +CURDIR=$(dirname "$0")/ +TESTDIR="$CURDIR/../../.." NR_ITER=100 NR_USEC_WAIT=100000 TESTAPP_PATH="$TESTDIR/utils/testapp" @@ -25,10 +15,12 @@ TESTAPP_NAME="gen-ust-events" TESTAPP_BIN="$TESTAPP_PATH/$TESTAPP_NAME/$TESTAPP_NAME" SESSION_NAME="periodical-flush" EVENT_NAME="tp:tptest" -BIN_NAME="gen-nevents" NUM_TESTS=38 +APP_TMP_FILE=$(mktemp -u -t tmp.test_periodical_metadata_flush_ust_app_tmp_file.XXXXXX) +APP_PIDS=() -source $TESTDIR/utils/utils.sh +# shellcheck source-path=SCRIPTDIR/../../../ +source "$TESTDIR/utils/utils.sh" if [ ! -x "$TESTAPP_BIN" ]; then BAIL_OUT "No UST events binary detected." @@ -41,7 +33,7 @@ function enable_channel_per_uid() local sess_name=$1 local channel_name=$2 - $TESTDIR/../src/bin/lttng/$LTTNG_BIN enable-channel --buffers-uid -u $channel_name -s $sess_name --switch-timer 100000 >/dev/null 2>&1 + "$TESTDIR/../src/bin/lttng/$LTTNG_BIN" enable-channel --buffers-uid -u "$channel_name" -s "$sess_name" --switch-timer 100000 >/dev/null 2>&1 ok $? "Enable channel $channel_name per UID for session $sess_name" } @@ -50,7 +42,7 @@ function enable_channel_per_pid() local sess_name=$1 local channel_name=$2 - $TESTDIR/../src/bin/lttng/$LTTNG_BIN enable-channel --buffers-pid -u $channel_name -s $sess_name --switch-timer 100000 >/dev/null 2>&1 + "$TESTDIR/../src/bin/lttng/$LTTNG_BIN" enable-channel --buffers-pid -u "$channel_name" -s "$sess_name" --switch-timer 100000 >/dev/null 2>&1 ok $? "Enable channel $channel_name per UID for session $sess_name" } @@ -59,7 +51,7 @@ function enable_metadata_per_uid() local sess_name=$1 local channel_name="metadata" - $TESTDIR/../src/bin/lttng/$LTTNG_BIN enable-channel --buffers-uid -u $channel_name -s $sess_name --switch-timer 200000 >/dev/null 2>&1 + "$TESTDIR/../src/bin/lttng/$LTTNG_BIN" enable-channel --buffers-uid -u "$channel_name" -s "$sess_name" --switch-timer 200000 2>&1 ok $? "Enable channel $channel_name per UID for session $sess_name" } @@ -68,24 +60,16 @@ function enable_metadata_per_pid() local sess_name=$1 local channel_name="metadata" - $TESTDIR/../src/bin/lttng/$LTTNG_BIN enable-channel --buffers-pid -u $channel_name -s $sess_name --switch-timer 200000 >/dev/null 2>&1 + "$TESTDIR/../src/bin/lttng/$LTTNG_BIN" enable-channel --buffers-pid -u "$channel_name" -s "$sess_name" --switch-timer 200000 >/dev/null 2>&1 ok $? "Enable channel $channel_name per PID for session $sess_name" } -function wait_apps -{ - diag "Waiting for applications to end..." - while [ -n "$(pidof $TESTAPP_NAME)" ]; do - sleep 1 - done -} - function validate_trace() { local out - out=$(babeltrace $TRACE_PATH | grep $EVENT_NAME | wc -l) - if [ $out -eq 0 ]; then + out=$("$BABELTRACE_BIN" "$TRACE_PATH" | grep -c $EVENT_NAME) + if [ "$out" -eq 0 ]; then fail "Trace validation" diag "No event(s) found. We are supposed to have at least one." out=1 @@ -98,35 +82,74 @@ function validate_trace() return $out } +function check_app_tmp_file() +{ + # Wait for the application file to appear indicating that at least one + # tracepoint has been fired. + while [ ! -f "$APP_TMP_FILE" ]; do + sleep 0.5 + done + diag "Removing test app temporary file $APP_TMP_FILE" + rm -f "$APP_TMP_FILE" +} + +function start_trace_app() +{ + # Start application with a temporary file. + $TESTAPP_BIN -i $NR_ITER -w $NR_USEC_WAIT --sync-after-first-event "$APP_TMP_FILE" & + ret=$? + APP_PIDS+=(${!}) + ok $ret "Start application to trace" +} + +function start_check_trace_app() +{ + start_trace_app + check_app_tmp_file +} + + +function wait_trace_apps() +{ + wait "${APP_PIDS[@]}" 2> /dev/null + APP_PIDS=() +} + test_after_app_pid() { local out + APP_PIDS=() + diag "Start application AFTER tracing is started" - create_lttng_session $SESSION_NAME $TRACE_PATH + create_lttng_session_ok $SESSION_NAME "$TRACE_PATH" enable_metadata_per_pid $SESSION_NAME enable_channel_per_pid $SESSION_NAME "channel0" - enable_ust_lttng_event $SESSION_NAME $EVENT_NAME "channel0" - start_lttng_tracing $SESSION_NAME + enable_ust_lttng_event_ok $SESSION_NAME $EVENT_NAME "channel0" + start_lttng_tracing_ok $SESSION_NAME # Start application after tracing - $TESTAPP_BIN $NR_ITER $NR_USEC_WAIT - ok $? "Start application to trace" - - # At least hit one event - sleep 2 + start_check_trace_app + # After this point we are sure that at least one event has been hit. # Make sure the application does not generate any more data, # thus ensuring that we are not flushing a packet concurrently # with validate_trace. - killall -q $TESTAPP_NAME + kill -s SIGSTOP "${APP_PIDS[@]}" + + # Give time to the consumer to write inflight data. sleep 2 + # shellcheck disable=SC2119 validate_trace out=$? - stop_lttng_tracing $SESSION_NAME - destroy_lttng_session $SESSION_NAME + kill -s SIGKILL "${APP_PIDS[@]}" + wait "${APP_PIDS[@]}" 2>/dev/null + stop_lttng_tracing_ok $SESSION_NAME + destroy_lttng_session_ok $SESSION_NAME + + wait_trace_apps return $out } @@ -134,34 +157,42 @@ test_after_app_pid() { test_before_app_pid() { local out + APP_PIDS=() + diag "Start application BEFORE tracing is started" - $TESTAPP_BIN $NR_ITER $NR_USEC_WAIT & - ok $? "Start application to trace" + start_trace_app # Start application before tracing - create_lttng_session $SESSION_NAME $TRACE_PATH + create_lttng_session_ok $SESSION_NAME "$TRACE_PATH" enable_metadata_per_pid $SESSION_NAME enable_channel_per_pid $SESSION_NAME "channel0" - enable_ust_lttng_event $SESSION_NAME $EVENT_NAME "channel0" - start_lttng_tracing $SESSION_NAME + enable_ust_lttng_event_ok $SESSION_NAME $EVENT_NAME "channel0" + start_lttng_tracing_ok $SESSION_NAME - # At least hit one event + check_app_tmp_file + # Let the application at least perform a flush! sleep 2 # Make sure the application does not generate any more data, # thus ensuring that we are not flushing a packet concurrently # with validate_trace. - killall -q $TESTAPP_NAME + kill -s SIGSTOP "${APP_PIDS[@]}" + + # Give time to the consumer to write inflight data. sleep 2 + # shellcheck disable=SC2119 validate_trace out=$? - stop_lttng_tracing $SESSION_NAME - destroy_lttng_session $SESSION_NAME + kill -s SIGKILL "${APP_PIDS[@]}" + wait "${APP_PIDS[@]}" 2>/dev/null + + stop_lttng_tracing_ok $SESSION_NAME + destroy_lttng_session_ok $SESSION_NAME - wait_apps + wait_trace_apps return $out } @@ -169,32 +200,38 @@ test_before_app_pid() { test_after_app_uid() { local out + APP_PIDS=() + diag "Start application AFTER tracing is started" - create_lttng_session $SESSION_NAME $TRACE_PATH + create_lttng_session_ok $SESSION_NAME "$TRACE_PATH" enable_metadata_per_uid $SESSION_NAME enable_channel_per_uid $SESSION_NAME "channel0" - enable_ust_lttng_event $SESSION_NAME $EVENT_NAME "channel0" - start_lttng_tracing $SESSION_NAME + enable_ust_lttng_event_ok $SESSION_NAME $EVENT_NAME "channel0" + start_lttng_tracing_ok $SESSION_NAME # Start application after tracing - $TESTAPP_BIN $NR_ITER $NR_USEC_WAIT - ok $? "Start application to trace" - - # At least hit one event - sleep 2 + start_check_trace_app + # After this point we are sure that at least one event has been hit. # Make sure the application does not generate any more data, # thus ensuring that we are not flushing a packet concurrently # with validate_trace. - killall -q $TESTAPP_NAME + kill -s SIGSTOP "${APP_PIDS[@]}" + + # Give time to the consumer to write inflight data. sleep 2 + # shellcheck disable=SC2119 validate_trace out=$? - stop_lttng_tracing $SESSION_NAME - destroy_lttng_session $SESSION_NAME + kill -s SIGKILL "${APP_PIDS[@]}" + wait "${APP_PIDS[@]}" + stop_lttng_tracing_ok $SESSION_NAME + destroy_lttng_session_ok $SESSION_NAME + + wait_trace_apps return $out } @@ -202,34 +239,41 @@ test_after_app_uid() { test_before_app_uid() { local out + APP_PIDS=() + diag "Start application BEFORE tracing is started" - # Start application after tracing - $TESTAPP_BIN $NR_ITER $NR_USEC_WAIT & - ok $? "Start application to trace" + # Start application before tracing + start_trace_app - create_lttng_session $SESSION_NAME $TRACE_PATH + create_lttng_session_ok $SESSION_NAME "$TRACE_PATH" enable_metadata_per_uid $SESSION_NAME enable_channel_per_uid $SESSION_NAME "channel0" - enable_ust_lttng_event $SESSION_NAME $EVENT_NAME "channel0" - start_lttng_tracing $SESSION_NAME + enable_ust_lttng_event_ok $SESSION_NAME $EVENT_NAME "channel0" + start_lttng_tracing_ok $SESSION_NAME - # At least hit one event + check_app_tmp_file + # Let the application at least perform a flush! sleep 2 # Make sure the application does not generate any more data, # thus ensuring that we are not flushing a packet concurrently # with validate_trace. - killall -q $TESTAPP_NAME + kill -s SIGSTOP "${APP_PIDS[@]}" + + # Give time to the consumer to write inflight data. sleep 2 + # shellcheck disable=SC2119 validate_trace out=$? - stop_lttng_tracing $SESSION_NAME - destroy_lttng_session $SESSION_NAME + kill -s SIGKILL "${APP_PIDS[@]}" + wait "${APP_PIDS[@]}" + stop_lttng_tracing_ok $SESSION_NAME + destroy_lttng_session_ok $SESSION_NAME - wait_apps + wait_trace_apps return $out } @@ -238,6 +282,7 @@ test_before_app_uid() { plan_tests $NUM_TESTS print_test_banner "$TEST_DESC" +bail_out_if_no_babeltrace TESTS=( "test_before_app_uid" @@ -249,13 +294,15 @@ TESTS=( TEST_COUNT=${#TESTS[@]} i=0 +# shellcheck disable=SC2119 start_lttng_sessiond -while [ $i -lt $TEST_COUNT ]; do - TRACE_PATH=$(mktemp -d) +while [ $i -lt "$TEST_COUNT" ]; do + TRACE_PATH=$(mktemp -d -t tmp.test_periodical_metadata_flush_ust_trace_path.XXXXXX) ${TESTS[$i]} - rm -rf $TRACE_PATH - let "i++" + rm -rf "$TRACE_PATH" + (( "i++" )) done +# shellcheck disable=SC2119 stop_lttng_sessiond