X-Git-Url: https://git.lttng.org/?a=blobdiff_plain;f=tests%2Fregression%2Ftools%2Frotation%2Ftest_ust;h=ddada1007fb8d6354c670c880dc3eb600d2408fa;hb=56f80787af0aa6c608c3927309c4cf3b595e17d2;hp=89c4c969d4fd7b68a677dcc553745f0791038118;hpb=e7716c6aec4c7152bd4cb060b805d8cb7051c121;p=lttng-tools.git

diff --git a/tests/regression/tools/rotation/test_ust b/tests/regression/tools/rotation/test_ust
index 89c4c969d..ddada1007 100755
--- a/tests/regression/tools/rotation/test_ust
+++ b/tests/regression/tools/rotation/test_ust
@@ -1,35 +1,23 @@
 #!/bin/bash
 #
-# Copyright (C) - 2017 Julien Desfossez <jdesfossez@efficios.com>
+# Copyright (C) 2017 Julien Desfossez <jdesfossez@efficios.com>
 #
-# This library is free software; you can redistribute it and/or modify it under
-# the terms of the GNU Lesser General Public License as published by the Free
-# Software Foundation; version 2.1 of the License.
-#
-# This library is distributed in the hope that it will be useful, but WITHOUT
-# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
-# FOR A PARTICULAR PURPOSE.  See the GNU Lesser General Public License for more
-# details.
-#
-# You should have received a copy of the GNU Lesser General Public License
-# along with this library; if not, write to the Free Software Foundation, Inc.,
-# 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301 USA
+# SPDX-License-Identifier: LGPL-2.1-only
+
 TEST_DESC="Rotation - User space tracing"
 
 CURDIR=$(dirname $0)/
 TESTDIR=$CURDIR/../../..
-NR_ITER=1
 NR_USEC_WAIT=0
 TESTAPP_PATH="$TESTDIR/utils/testapp"
 TESTAPP_NAME="gen-ust-events"
 TESTAPP_BIN="$TESTAPP_PATH/$TESTAPP_NAME/$TESTAPP_NAME"
 SESSION_NAME="stream"
 EVENT_NAME="tp:tptest"
-PID_RELAYD=0
 
-TRACE_PATH=$(mktemp -d)
+TRACE_PATH=$(mktemp --tmpdir -d -t tmp.test_ust_rotation_trace_path.XXXXXX)
 
-NUM_TESTS=146
+NUM_TESTS=145
 
 source $TESTDIR/utils/utils.sh
 source $CURDIR/rotate_utils.sh
@@ -38,21 +26,15 @@ if [ ! -x "$TESTAPP_BIN" ]; then
 	BAIL_OUT "No UST events binary detected."
 fi
 
-function enable_channel_per_pid()
+XPATH_CMD_OUTPUT="//lttng:command/lttng:output"
+XPATH_PID="$XPATH_CMD_OUTPUT/lttng:domains/lttng:domain[./lttng:type = 'UST']/lttng:pids/lttng:pid/lttng:id"
+
+function enable_channel_per_pid ()
 {
 	sess_name=$1
 	channel_name=$2
 
-	$TESTDIR/../src/bin/lttng/$LTTNG_BIN enable-channel --buffers-pid -u $channel_name -s $sess_name >/dev/null 2>&1
-	ok $? "Enable channel $channel_name per PID for session $sess_name"
-}
-
-function lttng_create_session_uri
-{
-	# Create session with default path
-	$TESTDIR/../src/bin/lttng/$LTTNG_BIN create $SESSION_NAME -U net://localhost >/dev/null 2>&1
-
-	ok $? "Create session $SESSION_NAME"
+	enable_ust_lttng_channel_ok $sess_name $channel_name --buffers-pid
 }
 
 # MUST set TESTDIR before calling those functions
@@ -66,10 +48,10 @@ function rotate_ust_test ()
 	start_lttng_tracing_ok $SESSION_NAME
 	today=$(date +%Y%m%d)
 
-	$TESTAPP_BIN 10 $NR_USEC_WAIT /dev/null 2>&1
+	$TESTAPP_BIN -i 10 -w $NR_USEC_WAIT > /dev/null 2>&1
 	rotate_session_ok $SESSION_NAME
 
-	$TESTAPP_BIN 20 $NR_USEC_WAIT /dev/null 2>&1
+	$TESTAPP_BIN -i 20 -w $NR_USEC_WAIT > /dev/null 2>&1
 	stop_lttng_tracing_ok $SESSION_NAME
 
 	# Third chunk contains no event (rotate after stop).
@@ -77,25 +59,16 @@ function rotate_ust_test ()
 
 	destroy_lttng_session_ok $SESSION_NAME
 
-	# The tests on the chunk folder rely on the date staying the same during
-	# the duration of the test, if this fail we will now why the other checks
-	# fail afterwards. There is a short window of time where an automated test
-	# could fail because of that.
-	now=$(date +%Y%m%d)
-	test $today = $now
-	ok $? "Date did not change during the test"
-
-	validate_test_chunks "${local_path}" $today $app_path ust $per_pid
+	validate_test_chunks "${local_path}" $today $app_path ust
 }
 
 function test_ust_streaming_uid ()
 {
 	diag "Test UST streaming with session rotation per UID"
-	lttng_create_session_uri
+	create_lttng_session_uri $SESSION_NAME net://localhost
 	enable_ust_lttng_event_ok $SESSION_NAME $EVENT_NAME
 
-	rotate_ust_test "${TRACE_PATH}/${HOSTNAME}/${SESSION_NAME}*" "ust/uid/*/*/" 0
-	rm -rf ${TRACE_PATH}/${HOSTNAME}
+	rotate_ust_test "${TRACE_PATH}/${HOSTNAME}/${SESSION_NAME}*/archives" "ust/uid/*/*/" 0
 }
 
 function test_ust_local_uid ()
@@ -104,19 +77,17 @@ function test_ust_local_uid ()
 	create_lttng_session_ok $SESSION_NAME $TRACE_PATH
 	enable_ust_lttng_event_ok $SESSION_NAME $EVENT_NAME
 
-	rotate_ust_test "${TRACE_PATH}" "ust/uid/*/*/" 0
-	rm -rf ${TRACE_PATH}
+	rotate_ust_test "${TRACE_PATH}/archives" "ust/uid/*/*/" 0
 }
 
 function test_ust_streaming_pid ()
 {
 	diag "Test UST streaming with session rotation per PID"
-	lttng_create_session_uri
+	create_lttng_session_uri $SESSION_NAME net://localhost
 	enable_channel_per_pid $SESSION_NAME "channel0"
 	enable_ust_lttng_event_ok $SESSION_NAME $EVENT_NAME "channel0"
 
-	rotate_ust_test "${TRACE_PATH}/${HOSTNAME}/${SESSION_NAME}*" "ust/pid/*/" 1
-	rm -rf ${TRACE_PATH}/${HOSTNAME}
+	rotate_ust_test "${TRACE_PATH}/${HOSTNAME}/${SESSION_NAME}*/archives" "ust/pid/*/" 1
 }
 
 function test_ust_local_pid ()
@@ -126,8 +97,37 @@ function test_ust_local_pid ()
 	enable_channel_per_pid $SESSION_NAME "channel0"
 	enable_ust_lttng_event_ok $SESSION_NAME $EVENT_NAME "channel0"
 
-	rotate_ust_test "${TRACE_PATH}" "ust/pid/*/" 1
-	rm -rf ${TRACE_PATH}
+	rotate_ust_test "${TRACE_PATH}/archives" "ust/pid/*/" 1
+}
+
+function wait_until_app_unregistration ()
+{
+	local pid=$1
+	local mi_output
+	local value=1
+
+	mi_output=$(mktemp)
+
+	while [ $value -ne 0 ]; do
+		# Extract from lttng list tracepoint the registered apps.
+		# This should give us enough guarantee since that if the app is not
+		# present it is unregistered from lttng-sessiond point of view.
+		LTTNG_BIN="lttng --mi xml" OUTPUT_DEST="$mi_output" list_lttng_notap -u
+		if ! $MI_VALIDATE "$mi_output"; then
+			return 1
+		fi
+
+		value=$("$MI_VALIDATE" "$mi_output" "$XPATH_PID" | wc -l)
+		if [ $value -ne 0 ]; then
+			diag "At least one app is still registred from lttng-sessiond point of view"
+			sleep 1
+		else
+			# No app present on listing.
+			break;
+		fi
+	done
+
+	return 0
 }
 
 function test_ust_local_timer_uid ()
@@ -138,54 +138,88 @@ function test_ust_local_timer_uid ()
 	lttng_enable_rotation_timer_ok $SESSION_NAME 500ms
 	start_lttng_tracing_ok $SESSION_NAME
 	# We just want the app to register, no event generated
-	$TESTAPP_BIN 0 0 /dev/null 2>&1
+	$TESTAPP_BIN -i 0 -w 0 > /dev/null 2>&1
 
-	rotate_timer_test "${TRACE_PATH}" 0
-	rm -rf ${TRACE_PATH}
+	rotate_timer_test "${TRACE_PATH}/archives" 0
 }
 
 function test_ust_streaming_timer_uid ()
 {
 	diag "Test ust remote with session rotation timer per-uid"
-	lttng_create_session_uri
+	create_lttng_session_uri $SESSION_NAME net://localhost
 	enable_ust_lttng_event_ok $SESSION_NAME $EVENT_NAME
 	lttng_enable_rotation_timer_ok $SESSION_NAME 500ms
 	start_lttng_tracing_ok $SESSION_NAME
 	# We just want the app to register, no event generated
-	$TESTAPP_BIN 0 0 /dev/null 2>&1
+	$TESTAPP_BIN -i 0 -w 0 > /dev/null 2>&1
 
-	rotate_timer_test "${TRACE_PATH}/${HOSTNAME}/${SESSION_NAME}*" 0
-	rm -rf ${TRACE_PATH}/${HOSTNAME}
+	rotate_timer_test "${TRACE_PATH}/${HOSTNAME}/${SESSION_NAME}*/archives" 0
 }
 
 function test_ust_local_timer_pid ()
 {
+	local app_pid
+
 	diag "Test ust local with session rotation timer per-pid"
 	create_lttng_session_ok $SESSION_NAME $TRACE_PATH
 	enable_channel_per_pid $SESSION_NAME "channel0"
 	enable_ust_lttng_event_ok $SESSION_NAME $EVENT_NAME "channel0"
-	lttng_enable_rotation_timer_ok $SESSION_NAME 500ms
 	start_lttng_tracing_ok $SESSION_NAME
-	# We just want the app to register, no event generated
-	$TESTAPP_BIN 0 0 /dev/null 2>&1
 
-	rotate_timer_test "${TRACE_PATH}" 1
-	rm -rf ${TRACE_PATH}
+	# We just want the app to register, no event generated.
+	# But we want the pid for the app since we need to validate its
+	# unregistration on lttng listing.
+	$TESTAPP_BIN -i 0 -w 0 > /dev/null 2>&1 &
+	app_pid=$!
+	wait $app_pid
+
+	wait_until_app_unregistration $app_pid
+	ok $? "App is un-registered"
+
+	# Set the rotation after that the app is done and that it was
+	# unregistered from lttng-sessiond.
+	# This is necessary since the rotate_timer_test function expects the
+	# second rotation archive to be empty. On slow machine it can take more
+	# than 500ms for the lttng-sessiond to receive and handle an app
+	# termination. This can lead to situation where the second rotation
+	# archive still have the channels for the pid for the app since that
+	# from the point of view of the lttng-sessiond/consumer the app is still
+	# "alive" and "kicking". This is a problem only for per-pid testing.
+	lttng_enable_rotation_timer_ok $SESSION_NAME 500ms
+
+	rotate_timer_test "${TRACE_PATH}/archives" 1
 }
 
 function test_ust_streaming_timer_pid ()
 {
 	diag "Test ust remote with session rotation timer per-pid"
-	lttng_create_session_uri
+	create_lttng_session_uri $SESSION_NAME net://localhost
 	enable_channel_per_pid $SESSION_NAME "channel0"
 	enable_ust_lttng_event_ok $SESSION_NAME $EVENT_NAME "channel0"
-	lttng_enable_rotation_timer_ok $SESSION_NAME 500ms
 	start_lttng_tracing_ok $SESSION_NAME
-	# We just want the app to register, no event generated
-	$TESTAPP_BIN 0 0 /dev/null 2>&1
 
-	rotate_timer_test "${TRACE_PATH}/${HOSTNAME}/${SESSION_NAME}*" 1
-	rm -rf ${TRACE_PATH}/${HOSTNAME}
+	# We just want the app to register, no event generated.
+	# But we want the pid for the app since we need to validate its
+	# unregistration on lttng listing.
+	$TESTAPP_BIN -i 0 -w 0 > /dev/null 2>&1 &
+	app_pid=$!
+	wait $app_pid
+
+	wait_until_app_unregistration $app_pid
+	ok $? "App is un-registered"
+
+	# Set the rotation after that the app is done and that it was
+	# unregistered from lttng-sessiond.
+	# This is necessary since the rotate_timer_test function expects the
+	# second rotation archive to be empty. On slow machine it can take more
+	# than 500ms for the lttng-sessiond to receive and handle an app
+	# termination. This can lead to situation where the second rotation
+	# archive still have the channels for the pid for the app since that
+	# from the point of view of the lttng-sessiond/consumer the app is still
+	# "alive" and "kicking". This is a problem only for per-pid testing.
+	lttng_enable_rotation_timer_ok $SESSION_NAME 500ms
+
+	rotate_timer_test "${TRACE_PATH}/${HOSTNAME}/${SESSION_NAME}*/archives" 1
 }
 
 function test_incompatible_sessions ()
@@ -194,19 +228,19 @@ function test_incompatible_sessions ()
 
 	diag "Live session with rotate timer"
 	# Should not be able to enable a rotation timer with a live session
-	$TESTDIR/../src/bin/lttng/$LTTNG_BIN create $SESSION_NAME --live >/dev/null 2>&1
+	create_lttng_session_uri $SESSION_NAME net://localhost --live
 	lttng_enable_rotation_timer_fail $SESSION_NAME 500ms
 	destroy_lttng_session_ok $SESSION_NAME
 
 	diag "Snapshot session with rotate timer"
 	# Should not be able to enable a rotation timer with a snapshot session
-	$TESTDIR/../src/bin/lttng/$LTTNG_BIN create $SESSION_NAME --snapshot >/dev/null 2>&1
+	create_lttng_session_ok $SESSION_NAME $TRACE_PATH --snapshot
 	lttng_enable_rotation_timer_fail $SESSION_NAME 500ms
 	destroy_lttng_session_ok $SESSION_NAME
 
 	diag "Live session with rotate"
 	# Should not be able to rotate a live session
-	$TESTDIR/../src/bin/lttng/$LTTNG_BIN create $SESSION_NAME --live >/dev/null 2>&1
+	create_lttng_session_uri $SESSION_NAME net://localhost --live
 	enable_ust_lttng_event_ok $SESSION_NAME $EVENT_NAME
 	start_lttng_tracing_ok $SESSION_NAME
 	rotate_session_fail $SESSION_NAME
@@ -214,17 +248,44 @@ function test_incompatible_sessions ()
 
 	diag "Snapshot session with rotate"
 	# Should not be able to rotate a snapshot session
-	$TESTDIR/../src/bin/lttng/$LTTNG_BIN create $SESSION_NAME --snapshot >/dev/null 2>&1
+	create_lttng_session_ok $SESSION_NAME $TRACE_PATH --snapshot
 	enable_ust_lttng_event_ok $SESSION_NAME $EVENT_NAME
 	start_lttng_tracing_ok $SESSION_NAME
 	rotate_session_fail $SESSION_NAME
 	destroy_lttng_session_ok $SESSION_NAME
+}
+
+function test_ust_local_size_uid ()
+{
+	diag "Rotate uid local session every 2MiB"
+	local size_threshold=$((2 * 1024 * 1024))
 
+	diag "Test ust local with size-based session rotation per-uid"
+	create_lttng_session_ok $SESSION_NAME $TRACE_PATH
+	enable_ust_lttng_channel_ok $SESSION_NAME "channel0" --buffers-uid
+	enable_ust_lttng_event_ok $SESSION_NAME $EVENT_NAME "channel0"
+	lttng_enable_rotation_size_ok $SESSION_NAME $size_threshold
+	start_lttng_tracing_ok $SESSION_NAME
+
+	local archive_count=0
+
+	diag "Waiting for 4 size-based rotations to occur"
+	while [[ archive_count -lt 4 ]]
+	do
+		archive_count=$(find "$TRACE_PATH" -mindepth 2 -maxdepth 2 -type d -path "*archives*" | wc -l)
+		$TESTAPP_BIN -i 2000 -w 0 > /dev/null 2>&1
+	done
+
+	[[ $archive_count -eq 4 ]]
+	ok $? "Saw four trace archives resulting from trace archive rotations"
+
+	destroy_lttng_session_ok $SESSION_NAME
 }
 
 plan_tests $NUM_TESTS
 
 print_test_banner "$TEST_DESC"
+bail_out_if_no_babeltrace
 
 start_lttng_relayd "-o $TRACE_PATH"
 start_lttng_sessiond
@@ -233,15 +294,17 @@ tests=( test_ust_streaming_uid test_ust_local_uid \
 	test_ust_streaming_pid test_ust_local_pid \
 	test_ust_local_timer_uid test_ust_streaming_timer_uid \
 	test_ust_local_timer_pid test_ust_streaming_timer_pid \
-	test_incompatible_sessions )
+	test_incompatible_sessions test_ust_local_size_uid )
 
 for fct_test in ${tests[@]};
 do
 	SESSION_NAME=$(randstring 16 0)
 	${fct_test}
+	clean_path $TRACE_PATH
 done
 
 stop_lttng_sessiond
 stop_lttng_relayd
 
-exit $out
+# Remove tmp dir
+rm -rf $TRACE_PATH