X-Git-Url: https://git.lttng.org/?a=blobdiff_plain;f=src%2Flttng-events.c;h=172513f3d0cff3c31ddc7c612ef64a28e7e7ba72;hb=4a399b764e79f280a434da2201a5c3e30490aa9e;hp=21653efd242cf414042ded43afb5ae226ded8286;hpb=437d5aa59380583ce1cd14d394a53b398be1275d;p=lttng-modules.git diff --git a/src/lttng-events.c b/src/lttng-events.c index 21653efd..172513f3 100644 --- a/src/lttng-events.c +++ b/src/lttng-events.c @@ -58,8 +58,10 @@ static LIST_HEAD(lttng_counter_transport_list); * Protect the sessions and metadata caches. */ static DEFINE_MUTEX(sessions_mutex); -static struct kmem_cache *event_cache; +static struct kmem_cache *event_recorder_cache; +static struct kmem_cache *event_recorder_private_cache; static struct kmem_cache *event_notifier_cache; +static struct kmem_cache *event_notifier_private_cache; static void lttng_session_lazy_sync_event_enablers(struct lttng_session *session); static void lttng_session_sync_event_enablers(struct lttng_session *session); @@ -67,15 +69,14 @@ static void lttng_event_enabler_destroy(struct lttng_event_enabler *event_enable static void lttng_event_notifier_enabler_destroy(struct lttng_event_notifier_enabler *event_notifier_enabler); static void lttng_event_notifier_group_sync_enablers(struct lttng_event_notifier_group *event_notifier_group); -static void _lttng_event_destroy(struct lttng_event *event); -static void _lttng_event_notifier_destroy(struct lttng_event_notifier *event_notifier); +static void _lttng_event_destroy(struct lttng_kernel_event_common *event); static void _lttng_channel_destroy(struct lttng_channel *chan); -static int _lttng_event_unregister(struct lttng_event *event); -static int _lttng_event_notifier_unregister(struct lttng_event_notifier *event_notifier); +static int _lttng_event_unregister(struct lttng_kernel_event_recorder *event); +static int _lttng_event_notifier_unregister(struct lttng_kernel_event_notifier *event_notifier); static int _lttng_event_metadata_statedump(struct lttng_session *session, struct lttng_channel *chan, - struct lttng_event *event); + struct lttng_kernel_event_recorder *event); static int _lttng_session_metadata_statedump(struct lttng_session *session); static @@ -88,7 +89,7 @@ int _lttng_type_statedump(struct lttng_session *session, static int _lttng_field_statedump(struct lttng_session *session, const struct lttng_kernel_event_field *field, - size_t nesting); + size_t nesting, const char **prev_field_name_p); void synchronize_trace(void) { @@ -290,7 +291,7 @@ struct lttng_event_notifier_group *lttng_event_notifier_group_create(void) * notifications. */ event_notifier_group->ops = &transport->ops; - event_notifier_group->chan = transport->ops.channel_create( + event_notifier_group->chan = transport->ops.priv->channel_create( transport_name, event_notifier_group, NULL, subbuf_size, num_subbuf, switch_timer_interval, read_timer_interval); @@ -331,7 +332,7 @@ void metadata_cache_destroy(struct kref *kref) void lttng_session_destroy(struct lttng_session *session) { struct lttng_channel *chan, *tmpchan; - struct lttng_event *event, *tmpevent; + struct lttng_kernel_event_recorder_private *event_recorder_priv, *tmpevent_recorder_priv; struct lttng_metadata_stream *metadata_stream; struct lttng_event_enabler *event_enabler, *tmp_event_enabler; int ret; @@ -342,8 +343,8 @@ void lttng_session_destroy(struct lttng_session *session) ret = lttng_syscalls_unregister_channel(chan); WARN_ON(ret); } - list_for_each_entry(event, &session->events, list) { - ret = _lttng_event_unregister(event); + list_for_each_entry(event_recorder_priv, &session->events, node) { + ret = _lttng_event_unregister(event_recorder_priv->pub); WARN_ON(ret); } synchronize_trace(); /* Wait for in-flight events to complete */ @@ -354,8 +355,8 @@ void lttng_session_destroy(struct lttng_session *session) list_for_each_entry_safe(event_enabler, tmp_event_enabler, &session->enablers_head, node) lttng_event_enabler_destroy(event_enabler); - list_for_each_entry_safe(event, tmpevent, &session->events, list) - _lttng_event_destroy(event); + list_for_each_entry_safe(event_recorder_priv, tmpevent_recorder_priv, &session->events, node) + _lttng_event_destroy(&event_recorder_priv->pub->parent); list_for_each_entry_safe(chan, tmpchan, &session->chan, list) { BUG_ON(chan->channel_type == METADATA_CHANNEL); _lttng_channel_destroy(chan); @@ -380,7 +381,7 @@ void lttng_event_notifier_group_destroy( struct lttng_event_notifier_group *event_notifier_group) { struct lttng_event_notifier_enabler *event_notifier_enabler, *tmp_event_notifier_enabler; - struct lttng_event_notifier *event_notifier, *tmpevent_notifier; + struct lttng_kernel_event_notifier_private *event_notifier_priv, *tmpevent_notifier_priv; int ret; if (!event_notifier_group) @@ -391,9 +392,9 @@ void lttng_event_notifier_group_destroy( ret = lttng_syscalls_unregister_event_notifier_group(event_notifier_group); WARN_ON(ret); - list_for_each_entry_safe(event_notifier, tmpevent_notifier, - &event_notifier_group->event_notifiers_head, list) { - ret = _lttng_event_notifier_unregister(event_notifier); + list_for_each_entry_safe(event_notifier_priv, tmpevent_notifier_priv, + &event_notifier_group->event_notifiers_head, node) { + ret = _lttng_event_notifier_unregister(event_notifier_priv->pub); WARN_ON(ret); } @@ -408,9 +409,9 @@ void lttng_event_notifier_group_destroy( &event_notifier_group->enablers_head, node) lttng_event_notifier_enabler_destroy(event_notifier_enabler); - list_for_each_entry_safe(event_notifier, tmpevent_notifier, - &event_notifier_group->event_notifiers_head, list) - _lttng_event_notifier_destroy(event_notifier); + list_for_each_entry_safe(event_notifier_priv, tmpevent_notifier_priv, + &event_notifier_group->event_notifiers_head, node) + _lttng_event_destroy(&event_notifier_priv->pub->parent); if (event_notifier_group->error_counter) { struct lttng_counter *error_counter = event_notifier_group->error_counter; @@ -421,7 +422,7 @@ void lttng_event_notifier_group_destroy( event_notifier_group->error_counter = NULL; } - event_notifier_group->ops->channel_destroy(event_notifier_group->chan); + event_notifier_group->ops->priv->channel_destroy(event_notifier_group->chan); module_put(event_notifier_group->transport->owner); list_del(&event_notifier_group->node); @@ -520,7 +521,7 @@ int lttng_session_metadata_regenerate(struct lttng_session *session) { int ret = 0; struct lttng_channel *chan; - struct lttng_event *event; + struct lttng_kernel_event_recorder_private *event_recorder_priv; struct lttng_metadata_cache *cache = session->metadata_cache; struct lttng_metadata_stream *stream; @@ -545,8 +546,8 @@ int lttng_session_metadata_regenerate(struct lttng_session *session) chan->metadata_dumped = 0; } - list_for_each_entry(event, &session->events, list) { - event->metadata_dumped = 0; + list_for_each_entry(event_recorder_priv, &session->events, node) { + event_recorder_priv->metadata_dumped = 0; } ret = _lttng_session_metadata_statedump(session); @@ -602,36 +603,57 @@ end: return ret; } -int lttng_event_enable(struct lttng_event *event) +int lttng_event_enable(struct lttng_kernel_event_common *event) { int ret = 0; mutex_lock(&sessions_mutex); - if (event->chan->channel_type == METADATA_CHANNEL) { - ret = -EPERM; - goto end; + switch (event->type) { + case LTTNG_KERNEL_EVENT_TYPE_RECORDER: + { + struct lttng_kernel_event_recorder *event_recorder = + container_of(event, struct lttng_kernel_event_recorder, parent); + + if (event_recorder->chan->channel_type == METADATA_CHANNEL) { + ret = -EPERM; + goto end; + } + break; } + case LTTNG_KERNEL_EVENT_TYPE_NOTIFIER: + switch (event->priv->instrumentation) { + case LTTNG_KERNEL_ABI_KRETPROBE: + ret = -EINVAL; + goto end; + default: + break; + } + break; + default: + break; + } + if (event->enabled) { ret = -EEXIST; goto end; } - switch (event->instrumentation) { - case LTTNG_KERNEL_TRACEPOINT: /* Fall-through */ - case LTTNG_KERNEL_SYSCALL: + switch (event->priv->instrumentation) { + case LTTNG_KERNEL_ABI_TRACEPOINT: /* Fall-through */ + case LTTNG_KERNEL_ABI_SYSCALL: ret = -EINVAL; break; - case LTTNG_KERNEL_KPROBE: /* Fall-through */ - case LTTNG_KERNEL_UPROBE: + case LTTNG_KERNEL_ABI_KPROBE: /* Fall-through */ + case LTTNG_KERNEL_ABI_UPROBE: WRITE_ONCE(event->enabled, 1); break; - case LTTNG_KERNEL_KRETPROBE: + case LTTNG_KERNEL_ABI_KRETPROBE: ret = lttng_kretprobes_event_enable_state(event, 1); break; - case LTTNG_KERNEL_FUNCTION: /* Fall-through */ - case LTTNG_KERNEL_NOOP: /* Fall-through */ + case LTTNG_KERNEL_ABI_FUNCTION: /* Fall-through */ + case LTTNG_KERNEL_ABI_NOOP: /* Fall-through */ default: WARN_ON_ONCE(1); ret = -EINVAL; @@ -641,101 +663,57 @@ end: return ret; } -int lttng_event_disable(struct lttng_event *event) +int lttng_event_disable(struct lttng_kernel_event_common *event) { int ret = 0; mutex_lock(&sessions_mutex); - if (event->chan->channel_type == METADATA_CHANNEL) { - ret = -EPERM; - goto end; - } - if (!event->enabled) { - ret = -EEXIST; - goto end; - } - switch (event->instrumentation) { - case LTTNG_KERNEL_TRACEPOINT: /* Fall-through */ - case LTTNG_KERNEL_SYSCALL: - ret = -EINVAL; - break; + switch (event->type) { + case LTTNG_KERNEL_EVENT_TYPE_RECORDER: + { + struct lttng_kernel_event_recorder *event_recorder = + container_of(event, struct lttng_kernel_event_recorder, parent); - case LTTNG_KERNEL_KPROBE: /* Fall-through */ - case LTTNG_KERNEL_UPROBE: - WRITE_ONCE(event->enabled, 0); + if (event_recorder->chan->channel_type == METADATA_CHANNEL) { + ret = -EPERM; + goto end; + } break; - - case LTTNG_KERNEL_KRETPROBE: - - ret = lttng_kretprobes_event_enable_state(event, 0); + } + case LTTNG_KERNEL_EVENT_TYPE_NOTIFIER: + switch (event->priv->instrumentation) { + case LTTNG_KERNEL_ABI_KRETPROBE: + ret = -EINVAL; + goto end; + default: + break; + } break; - - case LTTNG_KERNEL_FUNCTION: /* Fall-through */ - case LTTNG_KERNEL_NOOP: /* Fall-through */ default: - WARN_ON_ONCE(1); - ret = -EINVAL; + break; } -end: - mutex_unlock(&sessions_mutex); - return ret; -} - -int lttng_event_notifier_enable(struct lttng_event_notifier *event_notifier) -{ - int ret = 0; - mutex_lock(&sessions_mutex); - if (event_notifier->enabled) { + if (!event->enabled) { ret = -EEXIST; goto end; } - switch (event_notifier->instrumentation) { - case LTTNG_KERNEL_TRACEPOINT: /* Fall-through */ - case LTTNG_KERNEL_SYSCALL: + switch (event->priv->instrumentation) { + case LTTNG_KERNEL_ABI_TRACEPOINT: /* Fall-through */ + case LTTNG_KERNEL_ABI_SYSCALL: ret = -EINVAL; break; - case LTTNG_KERNEL_KPROBE: /* Fall-through */ - case LTTNG_KERNEL_UPROBE: - WRITE_ONCE(event_notifier->enabled, 1); - break; - - case LTTNG_KERNEL_FUNCTION: /* Fall-through */ - case LTTNG_KERNEL_KRETPROBE: /* Fall-through */ - case LTTNG_KERNEL_NOOP: /* Fall-through */ - default: - WARN_ON_ONCE(1); - ret = -EINVAL; - } -end: - mutex_unlock(&sessions_mutex); - return ret; -} - -int lttng_event_notifier_disable(struct lttng_event_notifier *event_notifier) -{ - int ret = 0; - - mutex_lock(&sessions_mutex); - if (!event_notifier->enabled) { - ret = -EEXIST; - goto end; - } - switch (event_notifier->instrumentation) { - case LTTNG_KERNEL_TRACEPOINT: /* Fall-through */ - case LTTNG_KERNEL_SYSCALL: - ret = -EINVAL; + case LTTNG_KERNEL_ABI_KPROBE: /* Fall-through */ + case LTTNG_KERNEL_ABI_UPROBE: + WRITE_ONCE(event->enabled, 0); break; - case LTTNG_KERNEL_KPROBE: /* Fall-through */ - case LTTNG_KERNEL_UPROBE: - WRITE_ONCE(event_notifier->enabled, 0); + case LTTNG_KERNEL_ABI_KRETPROBE: + ret = lttng_kretprobes_event_enable_state(event, 0); break; - case LTTNG_KERNEL_FUNCTION: /* Fall-through */ - case LTTNG_KERNEL_KRETPROBE: /* Fall-through */ - case LTTNG_KERNEL_NOOP: /* Fall-through */ + case LTTNG_KERNEL_ABI_FUNCTION: /* Fall-through */ + case LTTNG_KERNEL_ABI_NOOP: /* Fall-through */ default: WARN_ON_ONCE(1); ret = -EINVAL; @@ -780,7 +758,7 @@ struct lttng_channel *lttng_channel_create(struct lttng_session *session, * headers. Therefore the "chan" information used as input * should be already accessible. */ - chan->chan = transport->ops.channel_create(transport_name, + chan->chan = transport->ops.priv->channel_create(transport_name, chan, buf_addr, subbuf_size, num_subbuf, switch_timer_interval, read_timer_interval); if (!chan->chan) @@ -812,7 +790,7 @@ active: static void _lttng_channel_destroy(struct lttng_channel *chan) { - chan->ops->channel_destroy(chan->chan); + chan->ops->priv->channel_destroy(chan->chan); module_put(chan->transport->owner); list_del(&chan->list); lttng_kernel_destroy_context(chan->ctx); @@ -842,14 +820,14 @@ void _lttng_metadata_channel_hangup(struct lttng_metadata_stream *stream) * Supports event creation while tracing session is active. * Needs to be called with sessions mutex held. */ -struct lttng_event *_lttng_event_create(struct lttng_channel *chan, - struct lttng_kernel_event *event_param, - void *filter, +struct lttng_kernel_event_recorder *_lttng_kernel_event_recorder_create(struct lttng_channel *chan, + struct lttng_kernel_abi_event *event_param, const struct lttng_kernel_event_desc *event_desc, - enum lttng_kernel_instrumentation itype) + enum lttng_kernel_abi_instrumentation itype) { struct lttng_session *session = chan->session; - struct lttng_event *event; + struct lttng_kernel_event_recorder *event_recorder; + struct lttng_kernel_event_recorder_private *event_recorder_priv; const char *event_name; struct hlist_head *head; int ret; @@ -860,19 +838,19 @@ struct lttng_event *_lttng_event_create(struct lttng_channel *chan, } switch (itype) { - case LTTNG_KERNEL_TRACEPOINT: + case LTTNG_KERNEL_ABI_TRACEPOINT: event_name = event_desc->event_name; break; - case LTTNG_KERNEL_KPROBE: /* Fall-through */ - case LTTNG_KERNEL_UPROBE: /* Fall-through */ - case LTTNG_KERNEL_KRETPROBE: /* Fall-through */ - case LTTNG_KERNEL_SYSCALL: + case LTTNG_KERNEL_ABI_KPROBE: /* Fall-through */ + case LTTNG_KERNEL_ABI_UPROBE: /* Fall-through */ + case LTTNG_KERNEL_ABI_KRETPROBE: /* Fall-through */ + case LTTNG_KERNEL_ABI_SYSCALL: event_name = event_param->name; break; - case LTTNG_KERNEL_FUNCTION: /* Fall-through */ - case LTTNG_KERNEL_NOOP: /* Fall-through */ + case LTTNG_KERNEL_ABI_FUNCTION: /* Fall-through */ + case LTTNG_KERNEL_ABI_NOOP: /* Fall-through */ default: WARN_ON_ONCE(1); ret = -EINVAL; @@ -881,36 +859,46 @@ struct lttng_event *_lttng_event_create(struct lttng_channel *chan, head = utils_borrow_hash_table_bucket(session->events_ht.table, LTTNG_EVENT_HT_SIZE, event_name); - lttng_hlist_for_each_entry(event, head, hlist) { - WARN_ON_ONCE(!event->desc); - if (!strncmp(event->desc->event_name, event_name, - LTTNG_KERNEL_SYM_NAME_LEN - 1) - && chan == event->chan) { + lttng_hlist_for_each_entry(event_recorder_priv, head, hlist) { + WARN_ON_ONCE(!event_recorder_priv->parent.desc); + if (!strncmp(event_recorder_priv->parent.desc->event_name, event_name, + LTTNG_KERNEL_ABI_SYM_NAME_LEN - 1) + && chan == event_recorder_priv->pub->chan) { ret = -EEXIST; goto exist; } } - event = kmem_cache_zalloc(event_cache, GFP_KERNEL); - if (!event) { + event_recorder = kmem_cache_zalloc(event_recorder_cache, GFP_KERNEL); + if (!event_recorder) { ret = -ENOMEM; goto cache_error; } - event->chan = chan; - event->filter = filter; - event->id = chan->free_event_id++; - event->instrumentation = itype; - event->evtype = LTTNG_TYPE_EVENT; - INIT_LIST_HEAD(&event->filter_bytecode_runtime_head); - INIT_LIST_HEAD(&event->enablers_ref_head); + event_recorder_priv = kmem_cache_zalloc(event_recorder_private_cache, GFP_KERNEL); + if (!event_recorder_priv) { + ret = -ENOMEM; + goto cache_private_error; + } + event_recorder_priv->pub = event_recorder; + event_recorder_priv->parent.pub = &event_recorder->parent; + event_recorder->priv = event_recorder_priv; + event_recorder->parent.priv = &event_recorder_priv->parent; + event_recorder->parent.type = LTTNG_KERNEL_EVENT_TYPE_RECORDER; + + event_recorder->parent.run_filter = lttng_kernel_interpret_event_filter; + event_recorder->chan = chan; + event_recorder->priv->id = chan->free_event_id++; + event_recorder->priv->parent.instrumentation = itype; + INIT_LIST_HEAD(&event_recorder->priv->parent.filter_bytecode_runtime_head); + INIT_LIST_HEAD(&event_recorder->priv->parent.enablers_ref_head); switch (itype) { - case LTTNG_KERNEL_TRACEPOINT: + case LTTNG_KERNEL_ABI_TRACEPOINT: /* Event will be enabled by enabler sync. */ - event->enabled = 0; - event->registered = 0; - event->desc = lttng_event_desc_get(event_name); - if (!event->desc) { + event_recorder->parent.enabled = 0; + event_recorder->priv->parent.registered = 0; + event_recorder->priv->parent.desc = lttng_event_desc_get(event_name); + if (!event_recorder->priv->parent.desc) { ret = -ENOENT; goto register_error; } @@ -918,13 +906,13 @@ struct lttng_event *_lttng_event_create(struct lttng_channel *chan, smp_wmb(); break; - case LTTNG_KERNEL_KPROBE: + case LTTNG_KERNEL_ABI_KPROBE: /* * Needs to be explicitly enabled after creation, since * we may want to apply filters. */ - event->enabled = 0; - event->registered = 1; + event_recorder->parent.enabled = 0; + event_recorder->priv->parent.registered = 1; /* * Populate lttng_event structure before event * registration. @@ -934,40 +922,53 @@ struct lttng_event *_lttng_event_create(struct lttng_channel *chan, event_param->u.kprobe.symbol_name, event_param->u.kprobe.offset, event_param->u.kprobe.addr, - event); + event_recorder); if (ret) { ret = -EINVAL; goto register_error; } - ret = try_module_get(event->desc->owner); + ret = try_module_get(event_recorder->priv->parent.desc->owner); WARN_ON_ONCE(!ret); break; - case LTTNG_KERNEL_KRETPROBE: + case LTTNG_KERNEL_ABI_KRETPROBE: { - struct lttng_event *event_return; + struct lttng_kernel_event_recorder *event_recorder_return; + struct lttng_kernel_event_recorder_private *event_recorder_return_priv; /* kretprobe defines 2 events */ /* * Needs to be explicitly enabled after creation, since * we may want to apply filters. */ - event->enabled = 0; - event->registered = 1; - event_return = - kmem_cache_zalloc(event_cache, GFP_KERNEL); - if (!event_return) { + event_recorder->parent.enabled = 0; + event_recorder->priv->parent.registered = 1; + + event_recorder_return = kmem_cache_zalloc(event_recorder_cache, GFP_KERNEL); + if (!event_recorder_return) { + ret = -ENOMEM; + goto register_error; + } + event_recorder_return_priv = kmem_cache_zalloc(event_recorder_private_cache, GFP_KERNEL); + if (!event_recorder_return_priv) { + kmem_cache_free(event_recorder_cache, event_recorder_return); ret = -ENOMEM; goto register_error; } - event_return->chan = chan; - event_return->filter = filter; - event_return->id = chan->free_event_id++; - event_return->enabled = 0; - event_return->registered = 1; - event_return->instrumentation = itype; - INIT_LIST_HEAD(&event_return->filter_bytecode_runtime_head); - INIT_LIST_HEAD(&event_return->enablers_ref_head); + event_recorder_return_priv->pub = event_recorder_return; + event_recorder_return_priv->parent.pub = &event_recorder_return->parent; + event_recorder_return->priv = event_recorder_return_priv; + event_recorder_return->parent.priv = &event_recorder_return_priv->parent; + event_recorder_return->parent.type = LTTNG_KERNEL_EVENT_TYPE_RECORDER; + + event_recorder_return->parent.run_filter = lttng_kernel_interpret_event_filter; + event_recorder_return->chan = chan; + event_recorder_return->priv->id = chan->free_event_id++; + event_recorder_return->priv->parent.instrumentation = itype; + event_recorder_return->parent.enabled = 0; + event_recorder_return->priv->parent.registered = 1; + INIT_LIST_HEAD(&event_recorder_return->priv->parent.filter_bytecode_runtime_head); + INIT_LIST_HEAD(&event_recorder_return->priv->parent.enablers_ref_head); /* * Populate lttng_event structure before kretprobe registration. */ @@ -976,73 +977,75 @@ struct lttng_event *_lttng_event_create(struct lttng_channel *chan, event_param->u.kretprobe.symbol_name, event_param->u.kretprobe.offset, event_param->u.kretprobe.addr, - event, event_return); + event_recorder, event_recorder_return); if (ret) { - kmem_cache_free(event_cache, event_return); + kmem_cache_free(event_recorder_private_cache, event_recorder_return_priv); + kmem_cache_free(event_recorder_cache, event_recorder_return); ret = -EINVAL; goto register_error; } /* Take 2 refs on the module: one per event. */ - ret = try_module_get(event->desc->owner); + ret = try_module_get(event_recorder->priv->parent.desc->owner); WARN_ON_ONCE(!ret); - ret = try_module_get(event->desc->owner); + ret = try_module_get(event_recorder_return->priv->parent.desc->owner); WARN_ON_ONCE(!ret); ret = _lttng_event_metadata_statedump(chan->session, chan, - event_return); + event_recorder_return); WARN_ON_ONCE(ret > 0); if (ret) { - kmem_cache_free(event_cache, event_return); - module_put(event->desc->owner); - module_put(event->desc->owner); + kmem_cache_free(event_recorder_private_cache, event_recorder_return_priv); + kmem_cache_free(event_recorder_cache, event_recorder_return); + module_put(event_recorder_return->priv->parent.desc->owner); + module_put(event_recorder->priv->parent.desc->owner); goto statedump_error; } - list_add(&event_return->list, &chan->session->events); + list_add(&event_recorder_return->priv->node, &chan->session->events); break; } - case LTTNG_KERNEL_SYSCALL: + case LTTNG_KERNEL_ABI_SYSCALL: /* * Needs to be explicitly enabled after creation, since * we may want to apply filters. */ - event->enabled = 0; - event->registered = 0; - event->desc = event_desc; + event_recorder->parent.enabled = 0; + event_recorder->priv->parent.registered = 0; + event_recorder->priv->parent.desc = event_desc; switch (event_param->u.syscall.entryexit) { - case LTTNG_KERNEL_SYSCALL_ENTRYEXIT: + case LTTNG_KERNEL_ABI_SYSCALL_ENTRYEXIT: ret = -EINVAL; goto register_error; - case LTTNG_KERNEL_SYSCALL_ENTRY: - event->u.syscall.entryexit = LTTNG_SYSCALL_ENTRY; + case LTTNG_KERNEL_ABI_SYSCALL_ENTRY: + event_recorder->priv->parent.u.syscall.entryexit = LTTNG_SYSCALL_ENTRY; break; - case LTTNG_KERNEL_SYSCALL_EXIT: - event->u.syscall.entryexit = LTTNG_SYSCALL_EXIT; + case LTTNG_KERNEL_ABI_SYSCALL_EXIT: + event_recorder->priv->parent.u.syscall.entryexit = LTTNG_SYSCALL_EXIT; break; } switch (event_param->u.syscall.abi) { - case LTTNG_KERNEL_SYSCALL_ABI_ALL: + case LTTNG_KERNEL_ABI_SYSCALL_ABI_ALL: ret = -EINVAL; goto register_error; - case LTTNG_KERNEL_SYSCALL_ABI_NATIVE: - event->u.syscall.abi = LTTNG_SYSCALL_ABI_NATIVE; + case LTTNG_KERNEL_ABI_SYSCALL_ABI_NATIVE: + event_recorder->priv->parent.u.syscall.abi = LTTNG_SYSCALL_ABI_NATIVE; break; - case LTTNG_KERNEL_SYSCALL_ABI_COMPAT: - event->u.syscall.abi = LTTNG_SYSCALL_ABI_COMPAT; + case LTTNG_KERNEL_ABI_SYSCALL_ABI_COMPAT: + event_recorder->priv->parent.u.syscall.abi = LTTNG_SYSCALL_ABI_COMPAT; break; } - if (!event->desc) { + if (!event_recorder->priv->parent.desc) { ret = -EINVAL; goto register_error; } break; - case LTTNG_KERNEL_UPROBE: + case LTTNG_KERNEL_ABI_UPROBE: /* * Needs to be explicitly enabled after creation, since * we may want to apply filters. */ - event->enabled = 0; - event->registered = 1; + event_recorder->parent.enabled = 0; + event_recorder->priv->parent.registered = 1; /* * Populate lttng_event structure before event @@ -1052,33 +1055,35 @@ struct lttng_event *_lttng_event_create(struct lttng_channel *chan, ret = lttng_uprobes_register_event(event_param->name, event_param->u.uprobe.fd, - event); + event_recorder); if (ret) goto register_error; - ret = try_module_get(event->desc->owner); + ret = try_module_get(event_recorder->priv->parent.desc->owner); WARN_ON_ONCE(!ret); break; - case LTTNG_KERNEL_FUNCTION: /* Fall-through */ - case LTTNG_KERNEL_NOOP: /* Fall-through */ + case LTTNG_KERNEL_ABI_FUNCTION: /* Fall-through */ + case LTTNG_KERNEL_ABI_NOOP: /* Fall-through */ default: WARN_ON_ONCE(1); ret = -EINVAL; goto register_error; } - ret = _lttng_event_metadata_statedump(chan->session, chan, event); + ret = _lttng_event_metadata_statedump(chan->session, chan, event_recorder); WARN_ON_ONCE(ret > 0); if (ret) { goto statedump_error; } - hlist_add_head(&event->hlist, head); - list_add(&event->list, &chan->session->events); - return event; + hlist_add_head(&event_recorder->priv->hlist, head); + list_add(&event_recorder->priv->node, &chan->session->events); + return event_recorder; statedump_error: /* If a statedump error occurs, events will not be readable. */ register_error: - kmem_cache_free(event_cache, event); + kmem_cache_free(event_recorder_private_cache, event_recorder_priv); +cache_private_error: + kmem_cache_free(event_recorder_cache, event_recorder); cache_error: exist: type_error: @@ -1086,33 +1091,34 @@ full: return ERR_PTR(ret); } -struct lttng_event_notifier *_lttng_event_notifier_create( +struct lttng_kernel_event_notifier *_lttng_event_notifier_create( const struct lttng_kernel_event_desc *event_desc, uint64_t token, uint64_t error_counter_index, struct lttng_event_notifier_group *event_notifier_group, - struct lttng_kernel_event_notifier *event_notifier_param, - void *filter, enum lttng_kernel_instrumentation itype) + struct lttng_kernel_abi_event_notifier *event_notifier_param, + enum lttng_kernel_abi_instrumentation itype) { - struct lttng_event_notifier *event_notifier; + struct lttng_kernel_event_notifier *event_notifier; + struct lttng_kernel_event_notifier_private *event_notifier_priv; struct lttng_counter *error_counter; const char *event_name; struct hlist_head *head; int ret; switch (itype) { - case LTTNG_KERNEL_TRACEPOINT: + case LTTNG_KERNEL_ABI_TRACEPOINT: event_name = event_desc->event_name; break; - case LTTNG_KERNEL_KPROBE: /* Fall-through */ - case LTTNG_KERNEL_UPROBE: /* Fall-through */ - case LTTNG_KERNEL_SYSCALL: + case LTTNG_KERNEL_ABI_KPROBE: /* Fall-through */ + case LTTNG_KERNEL_ABI_UPROBE: /* Fall-through */ + case LTTNG_KERNEL_ABI_SYSCALL: event_name = event_notifier_param->event.name; break; - case LTTNG_KERNEL_KRETPROBE: /* Fall-through */ - case LTTNG_KERNEL_FUNCTION: /* Fall-through */ - case LTTNG_KERNEL_NOOP: /* Fall-through */ + case LTTNG_KERNEL_ABI_KRETPROBE: /* Fall-through */ + case LTTNG_KERNEL_ABI_FUNCTION: /* Fall-through */ + case LTTNG_KERNEL_ABI_NOOP: /* Fall-through */ default: WARN_ON_ONCE(1); ret = -EINVAL; @@ -1121,12 +1127,12 @@ struct lttng_event_notifier *_lttng_event_notifier_create( head = utils_borrow_hash_table_bucket(event_notifier_group->event_notifiers_ht.table, LTTNG_EVENT_NOTIFIER_HT_SIZE, event_name); - lttng_hlist_for_each_entry(event_notifier, head, hlist) { - WARN_ON_ONCE(!event_notifier->desc); - if (!strncmp(event_notifier->desc->event_name, event_name, - LTTNG_KERNEL_SYM_NAME_LEN - 1) - && event_notifier_group == event_notifier->group - && token == event_notifier->user_token) { + lttng_hlist_for_each_entry(event_notifier_priv, head, hlist) { + WARN_ON_ONCE(!event_notifier_priv->parent.desc); + if (!strncmp(event_notifier_priv->parent.desc->event_name, event_name, + LTTNG_KERNEL_ABI_SYM_NAME_LEN - 1) + && event_notifier_group == event_notifier_priv->group + && token == event_notifier_priv->parent.user_token) { ret = -EEXIST; goto exist; } @@ -1137,26 +1143,35 @@ struct lttng_event_notifier *_lttng_event_notifier_create( ret = -ENOMEM; goto cache_error; } - - event_notifier->group = event_notifier_group; - event_notifier->user_token = token; - event_notifier->error_counter_index = error_counter_index; - event_notifier->num_captures = 0; - event_notifier->filter = filter; - event_notifier->instrumentation = itype; - event_notifier->evtype = LTTNG_TYPE_EVENT; - event_notifier->send_notification = lttng_event_notifier_notification_send; - INIT_LIST_HEAD(&event_notifier->filter_bytecode_runtime_head); - INIT_LIST_HEAD(&event_notifier->capture_bytecode_runtime_head); - INIT_LIST_HEAD(&event_notifier->enablers_ref_head); + event_notifier_priv = kmem_cache_zalloc(event_notifier_private_cache, GFP_KERNEL); + if (!event_notifier_priv) { + ret = -ENOMEM; + goto cache_private_error; + } + event_notifier_priv->pub = event_notifier; + event_notifier_priv->parent.pub = &event_notifier->parent; + event_notifier->priv = event_notifier_priv; + event_notifier->parent.priv = &event_notifier_priv->parent; + event_notifier->parent.type = LTTNG_KERNEL_EVENT_TYPE_NOTIFIER; + + event_notifier->priv->group = event_notifier_group; + event_notifier->priv->parent.user_token = token; + event_notifier->priv->error_counter_index = error_counter_index; + event_notifier->priv->num_captures = 0; + event_notifier->priv->parent.instrumentation = itype; + event_notifier->notification_send = lttng_event_notifier_notification_send; + INIT_LIST_HEAD(&event_notifier->priv->parent.filter_bytecode_runtime_head); + INIT_LIST_HEAD(&event_notifier->priv->parent.enablers_ref_head); + INIT_LIST_HEAD(&event_notifier->priv->capture_bytecode_runtime_head); + event_notifier->parent.run_filter = lttng_kernel_interpret_event_filter; switch (itype) { - case LTTNG_KERNEL_TRACEPOINT: + case LTTNG_KERNEL_ABI_TRACEPOINT: /* Event will be enabled by enabler sync. */ - event_notifier->enabled = 0; - event_notifier->registered = 0; - event_notifier->desc = lttng_event_desc_get(event_name); - if (!event_notifier->desc) { + event_notifier->parent.enabled = 0; + event_notifier->priv->parent.registered = 0; + event_notifier->priv->parent.desc = lttng_event_desc_get(event_name); + if (!event_notifier->priv->parent.desc) { ret = -ENOENT; goto register_error; } @@ -1164,13 +1179,13 @@ struct lttng_event_notifier *_lttng_event_notifier_create( smp_wmb(); break; - case LTTNG_KERNEL_KPROBE: + case LTTNG_KERNEL_ABI_KPROBE: /* * Needs to be explicitly enabled after creation, since * we may want to apply filters. */ - event_notifier->enabled = 0; - event_notifier->registered = 1; + event_notifier->parent.enabled = 0; + event_notifier->priv->parent.registered = 1; /* * Populate lttng_event_notifier structure before event * registration. @@ -1185,54 +1200,54 @@ struct lttng_event_notifier *_lttng_event_notifier_create( ret = -EINVAL; goto register_error; } - ret = try_module_get(event_notifier->desc->owner); + ret = try_module_get(event_notifier->priv->parent.desc->owner); WARN_ON_ONCE(!ret); break; - case LTTNG_KERNEL_SYSCALL: + case LTTNG_KERNEL_ABI_SYSCALL: /* * Needs to be explicitly enabled after creation, since * we may want to apply filters. */ - event_notifier->enabled = 0; - event_notifier->registered = 0; - event_notifier->desc = event_desc; + event_notifier->parent.enabled = 0; + event_notifier->priv->parent.registered = 0; + event_notifier->priv->parent.desc = event_desc; switch (event_notifier_param->event.u.syscall.entryexit) { - case LTTNG_KERNEL_SYSCALL_ENTRYEXIT: + case LTTNG_KERNEL_ABI_SYSCALL_ENTRYEXIT: ret = -EINVAL; goto register_error; - case LTTNG_KERNEL_SYSCALL_ENTRY: - event_notifier->u.syscall.entryexit = LTTNG_SYSCALL_ENTRY; + case LTTNG_KERNEL_ABI_SYSCALL_ENTRY: + event_notifier->priv->parent.u.syscall.entryexit = LTTNG_SYSCALL_ENTRY; break; - case LTTNG_KERNEL_SYSCALL_EXIT: - event_notifier->u.syscall.entryexit = LTTNG_SYSCALL_EXIT; + case LTTNG_KERNEL_ABI_SYSCALL_EXIT: + event_notifier->priv->parent.u.syscall.entryexit = LTTNG_SYSCALL_EXIT; break; } switch (event_notifier_param->event.u.syscall.abi) { - case LTTNG_KERNEL_SYSCALL_ABI_ALL: + case LTTNG_KERNEL_ABI_SYSCALL_ABI_ALL: ret = -EINVAL; goto register_error; - case LTTNG_KERNEL_SYSCALL_ABI_NATIVE: - event_notifier->u.syscall.abi = LTTNG_SYSCALL_ABI_NATIVE; + case LTTNG_KERNEL_ABI_SYSCALL_ABI_NATIVE: + event_notifier->priv->parent.u.syscall.abi = LTTNG_SYSCALL_ABI_NATIVE; break; - case LTTNG_KERNEL_SYSCALL_ABI_COMPAT: - event_notifier->u.syscall.abi = LTTNG_SYSCALL_ABI_COMPAT; + case LTTNG_KERNEL_ABI_SYSCALL_ABI_COMPAT: + event_notifier->priv->parent.u.syscall.abi = LTTNG_SYSCALL_ABI_COMPAT; break; } - if (!event_notifier->desc) { + if (!event_notifier->priv->parent.desc) { ret = -EINVAL; goto register_error; } break; - case LTTNG_KERNEL_UPROBE: + case LTTNG_KERNEL_ABI_UPROBE: /* * Needs to be explicitly enabled after creation, since * we may want to apply filters. */ - event_notifier->enabled = 0; - event_notifier->registered = 1; + event_notifier->parent.enabled = 0; + event_notifier->priv->parent.registered = 1; /* * Populate lttng_event_notifier structure before @@ -1246,21 +1261,21 @@ struct lttng_event_notifier *_lttng_event_notifier_create( event_notifier); if (ret) goto register_error; - ret = try_module_get(event_notifier->desc->owner); + ret = try_module_get(event_notifier->priv->parent.desc->owner); WARN_ON_ONCE(!ret); break; - case LTTNG_KERNEL_KRETPROBE: /* Fall-through */ - case LTTNG_KERNEL_FUNCTION: /* Fall-through */ - case LTTNG_KERNEL_NOOP: /* Fall-through */ + case LTTNG_KERNEL_ABI_KRETPROBE: /* Fall-through */ + case LTTNG_KERNEL_ABI_FUNCTION: /* Fall-through */ + case LTTNG_KERNEL_ABI_NOOP: /* Fall-through */ default: WARN_ON_ONCE(1); ret = -EINVAL; goto register_error; } - list_add(&event_notifier->list, &event_notifier_group->event_notifiers_head); - hlist_add_head(&event_notifier->hlist, head); + list_add(&event_notifier->priv->node, &event_notifier_group->event_notifiers_head); + hlist_add_head(&event_notifier->priv->hlist, head); /* * Clear the error counter bucket. The sessiond keeps track of which @@ -1275,18 +1290,18 @@ struct lttng_event_notifier *_lttng_event_notifier_create( /* * Check that the index is within the boundary of the counter. */ - if (event_notifier->error_counter_index >= event_notifier_group->error_counter_len) { + if (event_notifier->priv->error_counter_index >= event_notifier_group->error_counter_len) { printk(KERN_INFO "LTTng: event_notifier: Error counter index out-of-bound: counter-len=%zu, index=%llu\n", - event_notifier_group->error_counter_len, event_notifier->error_counter_index); + event_notifier_group->error_counter_len, event_notifier->priv->error_counter_index); ret = -EINVAL; goto register_error; } - dimension_index[0] = event_notifier->error_counter_index; + dimension_index[0] = event_notifier->priv->error_counter_index; ret = error_counter->ops->counter_clear(error_counter->counter, dimension_index); if (ret) { printk(KERN_INFO "LTTng: event_notifier: Unable to clear error counter bucket %llu\n", - event_notifier->error_counter_index); + event_notifier->priv->error_counter_index); goto register_error; } } @@ -1294,6 +1309,8 @@ struct lttng_event_notifier *_lttng_event_notifier_create( return event_notifier; register_error: + kmem_cache_free(event_notifier_private_cache, event_notifier_priv); +cache_private_error: kmem_cache_free(event_notifier_cache, event_notifier); cache_error: exist: @@ -1323,203 +1340,202 @@ int lttng_kernel_counter_clear(struct lttng_counter *counter, return counter->ops->counter_clear(counter->counter, dim_indexes); } -struct lttng_event *lttng_event_create(struct lttng_channel *chan, - struct lttng_kernel_event *event_param, - void *filter, +struct lttng_kernel_event_recorder *lttng_kernel_event_recorder_create(struct lttng_channel *chan, + struct lttng_kernel_abi_event *event_param, const struct lttng_kernel_event_desc *event_desc, - enum lttng_kernel_instrumentation itype) + enum lttng_kernel_abi_instrumentation itype) { - struct lttng_event *event; + struct lttng_kernel_event_recorder *event; mutex_lock(&sessions_mutex); - event = _lttng_event_create(chan, event_param, filter, event_desc, - itype); + event = _lttng_kernel_event_recorder_create(chan, event_param, event_desc, itype); mutex_unlock(&sessions_mutex); return event; } -struct lttng_event_notifier *lttng_event_notifier_create( +struct lttng_kernel_event_notifier *lttng_event_notifier_create( const struct lttng_kernel_event_desc *event_desc, uint64_t id, uint64_t error_counter_index, struct lttng_event_notifier_group *event_notifier_group, - struct lttng_kernel_event_notifier *event_notifier_param, - void *filter, enum lttng_kernel_instrumentation itype) + struct lttng_kernel_abi_event_notifier *event_notifier_param, + enum lttng_kernel_abi_instrumentation itype) { - struct lttng_event_notifier *event_notifier; + struct lttng_kernel_event_notifier *event_notifier; mutex_lock(&sessions_mutex); event_notifier = _lttng_event_notifier_create(event_desc, id, error_counter_index, event_notifier_group, - event_notifier_param, filter, itype); + event_notifier_param, itype); mutex_unlock(&sessions_mutex); return event_notifier; } /* Only used for tracepoints for now. */ static -void register_event(struct lttng_event *event) +void register_event(struct lttng_kernel_event_recorder *event_recorder) { const struct lttng_kernel_event_desc *desc; int ret = -EINVAL; - if (event->registered) + if (event_recorder->priv->parent.registered) return; - desc = event->desc; - switch (event->instrumentation) { - case LTTNG_KERNEL_TRACEPOINT: + desc = event_recorder->priv->parent.desc; + switch (event_recorder->priv->parent.instrumentation) { + case LTTNG_KERNEL_ABI_TRACEPOINT: ret = lttng_wrapper_tracepoint_probe_register(desc->event_kname, desc->probe_callback, - event); + event_recorder); break; - case LTTNG_KERNEL_SYSCALL: - ret = lttng_syscall_filter_enable_event(event->chan, event); + case LTTNG_KERNEL_ABI_SYSCALL: + ret = lttng_syscall_filter_enable_event(event_recorder->chan, event_recorder); break; - case LTTNG_KERNEL_KPROBE: /* Fall-through */ - case LTTNG_KERNEL_UPROBE: /* Fall-through */ - case LTTNG_KERNEL_KRETPROBE: + case LTTNG_KERNEL_ABI_KPROBE: /* Fall-through */ + case LTTNG_KERNEL_ABI_UPROBE: /* Fall-through */ + case LTTNG_KERNEL_ABI_KRETPROBE: ret = 0; break; - case LTTNG_KERNEL_FUNCTION: /* Fall-through */ - case LTTNG_KERNEL_NOOP: /* Fall-through */ + case LTTNG_KERNEL_ABI_FUNCTION: /* Fall-through */ + case LTTNG_KERNEL_ABI_NOOP: /* Fall-through */ default: WARN_ON_ONCE(1); } if (!ret) - event->registered = 1; + event_recorder->priv->parent.registered = 1; } /* * Only used internally at session destruction. */ -int _lttng_event_unregister(struct lttng_event *event) +int _lttng_event_unregister(struct lttng_kernel_event_recorder *event_recorder) { + struct lttng_kernel_event_common_private *event_priv = &event_recorder->priv->parent; const struct lttng_kernel_event_desc *desc; int ret = -EINVAL; - if (!event->registered) + if (!event_priv->registered) return 0; - desc = event->desc; - switch (event->instrumentation) { - case LTTNG_KERNEL_TRACEPOINT: - ret = lttng_wrapper_tracepoint_probe_unregister(event->desc->event_kname, - event->desc->probe_callback, - event); + desc = event_priv->desc; + switch (event_priv->instrumentation) { + case LTTNG_KERNEL_ABI_TRACEPOINT: + ret = lttng_wrapper_tracepoint_probe_unregister(event_priv->desc->event_kname, + event_priv->desc->probe_callback, + event_recorder); break; - case LTTNG_KERNEL_KPROBE: - lttng_kprobes_unregister_event(event); + case LTTNG_KERNEL_ABI_KPROBE: + lttng_kprobes_unregister_event(event_recorder); ret = 0; break; - case LTTNG_KERNEL_KRETPROBE: - lttng_kretprobes_unregister(event); + case LTTNG_KERNEL_ABI_KRETPROBE: + lttng_kretprobes_unregister(event_recorder); ret = 0; break; - case LTTNG_KERNEL_SYSCALL: - ret = lttng_syscall_filter_disable_event(event->chan, event); + case LTTNG_KERNEL_ABI_SYSCALL: + ret = lttng_syscall_filter_disable_event(event_recorder->chan, event_recorder); break; - case LTTNG_KERNEL_NOOP: + case LTTNG_KERNEL_ABI_NOOP: ret = 0; break; - case LTTNG_KERNEL_UPROBE: - lttng_uprobes_unregister_event(event); + case LTTNG_KERNEL_ABI_UPROBE: + lttng_uprobes_unregister_event(event_recorder); ret = 0; break; - case LTTNG_KERNEL_FUNCTION: /* Fall-through */ + case LTTNG_KERNEL_ABI_FUNCTION: /* Fall-through */ default: WARN_ON_ONCE(1); } if (!ret) - event->registered = 0; + event_priv->registered = 0; return ret; } /* Only used for tracepoints for now. */ static -void register_event_notifier(struct lttng_event_notifier *event_notifier) +void register_event_notifier(struct lttng_kernel_event_notifier *event_notifier) { const struct lttng_kernel_event_desc *desc; int ret = -EINVAL; - if (event_notifier->registered) + if (event_notifier->priv->parent.registered) return; - desc = event_notifier->desc; - switch (event_notifier->instrumentation) { - case LTTNG_KERNEL_TRACEPOINT: + desc = event_notifier->priv->parent.desc; + switch (event_notifier->priv->parent.instrumentation) { + case LTTNG_KERNEL_ABI_TRACEPOINT: ret = lttng_wrapper_tracepoint_probe_register(desc->event_kname, - desc->event_notifier_callback, + desc->probe_callback, event_notifier); break; - case LTTNG_KERNEL_SYSCALL: + case LTTNG_KERNEL_ABI_SYSCALL: ret = lttng_syscall_filter_enable_event_notifier(event_notifier); break; - case LTTNG_KERNEL_KPROBE: /* Fall-through */ - case LTTNG_KERNEL_UPROBE: + case LTTNG_KERNEL_ABI_KPROBE: /* Fall-through */ + case LTTNG_KERNEL_ABI_UPROBE: ret = 0; break; - case LTTNG_KERNEL_KRETPROBE: /* Fall-through */ - case LTTNG_KERNEL_FUNCTION: /* Fall-through */ - case LTTNG_KERNEL_NOOP: /* Fall-through */ + case LTTNG_KERNEL_ABI_KRETPROBE: /* Fall-through */ + case LTTNG_KERNEL_ABI_FUNCTION: /* Fall-through */ + case LTTNG_KERNEL_ABI_NOOP: /* Fall-through */ default: WARN_ON_ONCE(1); } if (!ret) - event_notifier->registered = 1; + event_notifier->priv->parent.registered = 1; } static int _lttng_event_notifier_unregister( - struct lttng_event_notifier *event_notifier) + struct lttng_kernel_event_notifier *event_notifier) { const struct lttng_kernel_event_desc *desc; int ret = -EINVAL; - if (!event_notifier->registered) + if (!event_notifier->priv->parent.registered) return 0; - desc = event_notifier->desc; - switch (event_notifier->instrumentation) { - case LTTNG_KERNEL_TRACEPOINT: - ret = lttng_wrapper_tracepoint_probe_unregister(event_notifier->desc->event_kname, - event_notifier->desc->event_notifier_callback, + desc = event_notifier->priv->parent.desc; + switch (event_notifier->priv->parent.instrumentation) { + case LTTNG_KERNEL_ABI_TRACEPOINT: + ret = lttng_wrapper_tracepoint_probe_unregister(event_notifier->priv->parent.desc->event_kname, + event_notifier->priv->parent.desc->probe_callback, event_notifier); break; - case LTTNG_KERNEL_KPROBE: + case LTTNG_KERNEL_ABI_KPROBE: lttng_kprobes_unregister_event_notifier(event_notifier); ret = 0; break; - case LTTNG_KERNEL_UPROBE: + case LTTNG_KERNEL_ABI_UPROBE: lttng_uprobes_unregister_event_notifier(event_notifier); ret = 0; break; - case LTTNG_KERNEL_SYSCALL: + case LTTNG_KERNEL_ABI_SYSCALL: ret = lttng_syscall_filter_disable_event_notifier(event_notifier); break; - case LTTNG_KERNEL_KRETPROBE: /* Fall-through */ - case LTTNG_KERNEL_FUNCTION: /* Fall-through */ - case LTTNG_KERNEL_NOOP: /* Fall-through */ + case LTTNG_KERNEL_ABI_KRETPROBE: /* Fall-through */ + case LTTNG_KERNEL_ABI_FUNCTION: /* Fall-through */ + case LTTNG_KERNEL_ABI_NOOP: /* Fall-through */ default: WARN_ON_ONCE(1); } if (!ret) - event_notifier->registered = 0; + event_notifier->priv->parent.registered = 0; return ret; } @@ -1527,87 +1543,93 @@ int _lttng_event_notifier_unregister( * Only used internally at session destruction. */ static -void _lttng_event_destroy(struct lttng_event *event) +void _lttng_event_destroy(struct lttng_kernel_event_common *event) { + struct lttng_kernel_event_common_private *event_priv = event->priv; struct lttng_enabler_ref *enabler_ref, *tmp_enabler_ref; - switch (event->instrumentation) { - case LTTNG_KERNEL_TRACEPOINT: - lttng_event_desc_put(event->desc); - break; + lttng_free_event_filter_runtime(event); + /* Free event enabler refs */ + list_for_each_entry_safe(enabler_ref, tmp_enabler_ref, + &event_priv->enablers_ref_head, node) + kfree(enabler_ref); - case LTTNG_KERNEL_KPROBE: - module_put(event->desc->owner); - lttng_kprobes_destroy_event_private(event); - break; + switch (event->type) { + case LTTNG_KERNEL_EVENT_TYPE_RECORDER: + { + struct lttng_kernel_event_recorder *event_recorder = + container_of(event, struct lttng_kernel_event_recorder, parent); - case LTTNG_KERNEL_KRETPROBE: - module_put(event->desc->owner); - lttng_kretprobes_destroy_private(event); - break; + switch (event_priv->instrumentation) { + case LTTNG_KERNEL_ABI_TRACEPOINT: + lttng_event_desc_put(event_priv->desc); + break; - case LTTNG_KERNEL_SYSCALL: - break; + case LTTNG_KERNEL_ABI_KPROBE: + module_put(event_priv->desc->owner); + lttng_kprobes_destroy_event_private(event_recorder); + break; - case LTTNG_KERNEL_UPROBE: - module_put(event->desc->owner); - lttng_uprobes_destroy_event_private(event); - break; + case LTTNG_KERNEL_ABI_KRETPROBE: + module_put(event_priv->desc->owner); + lttng_kretprobes_destroy_private(event_recorder); + break; - case LTTNG_KERNEL_FUNCTION: /* Fall-through */ - case LTTNG_KERNEL_NOOP: /* Fall-through */ - default: - WARN_ON_ONCE(1); - } - list_del(&event->list); - lttng_kernel_destroy_context(event->ctx); - lttng_free_event_filter_runtime(event); - /* Free event enabler refs */ - list_for_each_entry_safe(enabler_ref, tmp_enabler_ref, - &event->enablers_ref_head, node) - kfree(enabler_ref); - kmem_cache_free(event_cache, event); -} + case LTTNG_KERNEL_ABI_SYSCALL: + break; -/* - * Only used internally at session destruction. - */ -static -void _lttng_event_notifier_destroy(struct lttng_event_notifier *event_notifier) -{ - struct lttng_enabler_ref *enabler_ref, *tmp_enabler_ref; + case LTTNG_KERNEL_ABI_UPROBE: + module_put(event_priv->desc->owner); + lttng_uprobes_destroy_event_private(event_recorder); + break; - switch (event_notifier->instrumentation) { - case LTTNG_KERNEL_TRACEPOINT: - lttng_event_desc_put(event_notifier->desc); + case LTTNG_KERNEL_ABI_FUNCTION: /* Fall-through */ + case LTTNG_KERNEL_ABI_NOOP: /* Fall-through */ + default: + WARN_ON_ONCE(1); + } + list_del(&event_recorder->priv->node); + kmem_cache_free(event_recorder_private_cache, event_recorder->priv); + kmem_cache_free(event_recorder_cache, event_recorder); break; + } + case LTTNG_KERNEL_EVENT_TYPE_NOTIFIER: + { + struct lttng_kernel_event_notifier *event_notifier = + container_of(event, struct lttng_kernel_event_notifier, parent); - case LTTNG_KERNEL_KPROBE: - module_put(event_notifier->desc->owner); - lttng_kprobes_destroy_event_notifier_private(event_notifier); - break; + switch (event_notifier->priv->parent.instrumentation) { + case LTTNG_KERNEL_ABI_TRACEPOINT: + lttng_event_desc_put(event_notifier->priv->parent.desc); + break; - case LTTNG_KERNEL_SYSCALL: - break; + case LTTNG_KERNEL_ABI_KPROBE: + module_put(event_notifier->priv->parent.desc->owner); + lttng_kprobes_destroy_event_notifier_private(event_notifier); + break; - case LTTNG_KERNEL_UPROBE: - module_put(event_notifier->desc->owner); - lttng_uprobes_destroy_event_notifier_private(event_notifier); - break; + case LTTNG_KERNEL_ABI_SYSCALL: + break; + + case LTTNG_KERNEL_ABI_UPROBE: + module_put(event_notifier->priv->parent.desc->owner); + lttng_uprobes_destroy_event_notifier_private(event_notifier); + break; - case LTTNG_KERNEL_KRETPROBE: /* Fall-through */ - case LTTNG_KERNEL_FUNCTION: /* Fall-through */ - case LTTNG_KERNEL_NOOP: /* Fall-through */ + case LTTNG_KERNEL_ABI_KRETPROBE: /* Fall-through */ + case LTTNG_KERNEL_ABI_FUNCTION: /* Fall-through */ + case LTTNG_KERNEL_ABI_NOOP: /* Fall-through */ + default: + WARN_ON_ONCE(1); + } + list_del(&event_notifier->priv->node); + kmem_cache_free(event_notifier_private_cache, event_notifier->priv); + kmem_cache_free(event_notifier_cache, event_notifier); + break; + } default: WARN_ON_ONCE(1); } - list_del(&event_notifier->list); - lttng_free_event_notifier_filter_runtime(event_notifier); - /* Free event enabler refs */ - list_for_each_entry_safe(enabler_ref, tmp_enabler_ref, - &event_notifier->enablers_ref_head, node) - kfree(enabler_ref); - kmem_cache_free(event_notifier_cache, event_notifier); } struct lttng_id_tracker *get_tracker(struct lttng_session *session, @@ -1893,7 +1915,7 @@ int lttng_desc_match_enabler(const struct lttng_kernel_event_desc *desc, enabler_name = enabler->event_param.name; switch (enabler->event_param.instrumentation) { - case LTTNG_KERNEL_TRACEPOINT: + case LTTNG_KERNEL_ABI_TRACEPOINT: desc_name = desc->event_name; switch (enabler->format_type) { case LTTNG_ENABLER_FORMAT_STAR_GLOB: @@ -1905,7 +1927,7 @@ int lttng_desc_match_enabler(const struct lttng_kernel_event_desc *desc, } break; - case LTTNG_KERNEL_SYSCALL: + case LTTNG_KERNEL_ABI_SYSCALL: desc_name = desc->event_name; if (!strncmp(desc_name, "compat_", strlen("compat_"))) { desc_name += strlen("compat_"); @@ -1923,13 +1945,13 @@ int lttng_desc_match_enabler(const struct lttng_kernel_event_desc *desc, return -EINVAL; } switch (enabler->event_param.u.syscall.entryexit) { - case LTTNG_KERNEL_SYSCALL_ENTRYEXIT: + case LTTNG_KERNEL_ABI_SYSCALL_ENTRYEXIT: break; - case LTTNG_KERNEL_SYSCALL_ENTRY: + case LTTNG_KERNEL_ABI_SYSCALL_ENTRY: if (!entry) return 0; break; - case LTTNG_KERNEL_SYSCALL_EXIT: + case LTTNG_KERNEL_ABI_SYSCALL_EXIT: if (entry) return 0; break; @@ -1937,13 +1959,13 @@ int lttng_desc_match_enabler(const struct lttng_kernel_event_desc *desc, return -EINVAL; } switch (enabler->event_param.u.syscall.abi) { - case LTTNG_KERNEL_SYSCALL_ABI_ALL: + case LTTNG_KERNEL_ABI_SYSCALL_ABI_ALL: break; - case LTTNG_KERNEL_SYSCALL_ABI_NATIVE: + case LTTNG_KERNEL_ABI_SYSCALL_ABI_NATIVE: if (compat) return 0; break; - case LTTNG_KERNEL_SYSCALL_ABI_COMPAT: + case LTTNG_KERNEL_ABI_SYSCALL_ABI_COMPAT: if (!compat) return 0; break; @@ -1951,7 +1973,7 @@ int lttng_desc_match_enabler(const struct lttng_kernel_event_desc *desc, return -EINVAL; } switch (enabler->event_param.u.syscall.match) { - case LTTNG_KERNEL_SYSCALL_MATCH_NAME: + case LTTNG_KERNEL_ABI_SYSCALL_MATCH_NAME: switch (enabler->format_type) { case LTTNG_ENABLER_FORMAT_STAR_GLOB: return lttng_match_enabler_star_glob(desc_name, enabler_name); @@ -1961,7 +1983,7 @@ int lttng_desc_match_enabler(const struct lttng_kernel_event_desc *desc, return -EINVAL; } break; - case LTTNG_KERNEL_SYSCALL_MATCH_NR: + case LTTNG_KERNEL_ABI_SYSCALL_MATCH_NR: return -EINVAL; /* Not implemented. */ default: return -EINVAL; @@ -1976,15 +1998,15 @@ int lttng_desc_match_enabler(const struct lttng_kernel_event_desc *desc, static int lttng_event_enabler_match_event(struct lttng_event_enabler *event_enabler, - struct lttng_event *event) + struct lttng_kernel_event_recorder *event_recorder) { struct lttng_enabler *base_enabler = lttng_event_enabler_as_enabler( event_enabler); - if (base_enabler->event_param.instrumentation != event->instrumentation) + if (base_enabler->event_param.instrumentation != event_recorder->priv->parent.instrumentation) return 0; - if (lttng_desc_match_enabler(event->desc, base_enabler) - && event->chan == event_enabler->chan) + if (lttng_desc_match_enabler(event_recorder->priv->parent.desc, base_enabler) + && event_recorder->chan == event_enabler->chan) return 1; else return 0; @@ -1992,16 +2014,16 @@ int lttng_event_enabler_match_event(struct lttng_event_enabler *event_enabler, static int lttng_event_notifier_enabler_match_event_notifier(struct lttng_event_notifier_enabler *event_notifier_enabler, - struct lttng_event_notifier *event_notifier) + struct lttng_kernel_event_notifier *event_notifier) { struct lttng_enabler *base_enabler = lttng_event_notifier_enabler_as_enabler( event_notifier_enabler); - if (base_enabler->event_param.instrumentation != event_notifier->instrumentation) + if (base_enabler->event_param.instrumentation != event_notifier->priv->parent.instrumentation) return 0; - if (lttng_desc_match_enabler(event_notifier->desc, base_enabler) - && event_notifier->group == event_notifier_enabler->group - && event_notifier->user_token == event_notifier_enabler->base.user_token) + if (lttng_desc_match_enabler(event_notifier->priv->parent.desc, base_enabler) + && event_notifier->priv->group == event_notifier_enabler->group + && event_notifier->priv->parent.user_token == event_notifier_enabler->base.user_token) return 1; else return 0; @@ -2040,7 +2062,8 @@ void lttng_create_tracepoint_event_if_missing(struct lttng_event_enabler *event_ for (i = 0; i < probe_desc->nr_events; i++) { int found = 0; struct hlist_head *head; - struct lttng_event *event; + struct lttng_kernel_event_recorder_private *event_recorder_private; + struct lttng_kernel_event_recorder *event_recorder; desc = probe_desc->event_desc[i]; if (!lttng_desc_match_enabler(desc, @@ -2053,9 +2076,9 @@ void lttng_create_tracepoint_event_if_missing(struct lttng_event_enabler *event_ head = utils_borrow_hash_table_bucket( session->events_ht.table, LTTNG_EVENT_HT_SIZE, desc->event_name); - lttng_hlist_for_each_entry(event, head, hlist) { - if (event->desc == desc - && event->chan == event_enabler->chan) + lttng_hlist_for_each_entry(event_recorder_private, head, hlist) { + if (event_recorder_private->parent.desc == desc + && event_recorder_private->pub->chan == event_enabler->chan) found = 1; } if (found) @@ -2065,10 +2088,9 @@ void lttng_create_tracepoint_event_if_missing(struct lttng_event_enabler *event_ * We need to create an event for this * event probe. */ - event = _lttng_event_create(event_enabler->chan, - NULL, NULL, desc, - LTTNG_KERNEL_TRACEPOINT); - if (!event) { + event_recorder = _lttng_kernel_event_recorder_create(event_enabler->chan, + NULL, desc, LTTNG_KERNEL_ABI_TRACEPOINT); + if (!event_recorder) { printk(KERN_INFO "LTTng: Unable to create event %s\n", probe_desc->event_desc[i]->event_name); } @@ -2095,7 +2117,8 @@ void lttng_create_tracepoint_event_notifier_if_missing(struct lttng_event_notifi for (i = 0; i < probe_desc->nr_events; i++) { int found = 0; struct hlist_head *head; - struct lttng_event_notifier *event_notifier; + struct lttng_kernel_event_notifier_private *event_notifier_priv; + struct lttng_kernel_event_notifier *event_notifier; desc = probe_desc->event_desc[i]; if (!lttng_desc_match_enabler(desc, @@ -2108,9 +2131,9 @@ void lttng_create_tracepoint_event_notifier_if_missing(struct lttng_event_notifi head = utils_borrow_hash_table_bucket( event_notifier_group->event_notifiers_ht.table, LTTNG_EVENT_NOTIFIER_HT_SIZE, desc->event_name); - lttng_hlist_for_each_entry(event_notifier, head, hlist) { - if (event_notifier->desc == desc - && event_notifier->user_token == event_notifier_enabler->base.user_token) + lttng_hlist_for_each_entry(event_notifier_priv, head, hlist) { + if (event_notifier_priv->parent.desc == desc + && event_notifier_priv->parent.user_token == event_notifier_enabler->base.user_token) found = 1; } if (found) @@ -2122,8 +2145,8 @@ void lttng_create_tracepoint_event_notifier_if_missing(struct lttng_event_notifi event_notifier = _lttng_event_notifier_create(desc, event_notifier_enabler->base.user_token, event_notifier_enabler->error_counter_index, - event_notifier_group, NULL, NULL, - LTTNG_KERNEL_TRACEPOINT); + event_notifier_group, NULL, + LTTNG_KERNEL_ABI_TRACEPOINT); if (IS_ERR(event_notifier)) { printk(KERN_INFO "Unable to create event_notifier %s\n", probe_desc->event_desc[i]->event_name); @@ -2137,7 +2160,7 @@ void lttng_create_syscall_event_if_missing(struct lttng_event_enabler *event_ena { int ret; - ret = lttng_syscalls_register_event(event_enabler, NULL); + ret = lttng_syscalls_register_event(event_enabler); WARN_ON_ONCE(ret); } @@ -2146,14 +2169,14 @@ void lttng_create_syscall_event_notifier_if_missing(struct lttng_event_notifier_ { int ret; - ret = lttng_syscalls_register_event_notifier(event_notifier_enabler, NULL); + ret = lttng_syscalls_register_event_notifier(event_notifier_enabler); WARN_ON_ONCE(ret); - ret = lttng_syscals_create_matching_event_notifiers(event_notifier_enabler, NULL); + ret = lttng_syscalls_create_matching_event_notifiers(event_notifier_enabler); WARN_ON_ONCE(ret); } /* - * Create struct lttng_event if it is missing and present in the list of + * Create struct lttng_kernel_event_recorder if it is missing and present in the list of * tracepoint probes. * Should be called with sessions mutex held. */ @@ -2161,11 +2184,11 @@ static void lttng_create_event_if_missing(struct lttng_event_enabler *event_enabler) { switch (event_enabler->base.event_param.instrumentation) { - case LTTNG_KERNEL_TRACEPOINT: + case LTTNG_KERNEL_ABI_TRACEPOINT: lttng_create_tracepoint_event_if_missing(event_enabler); break; - case LTTNG_KERNEL_SYSCALL: + case LTTNG_KERNEL_ABI_SYSCALL: lttng_create_syscall_event_if_missing(event_enabler); break; @@ -2186,19 +2209,19 @@ int lttng_event_enabler_ref_events(struct lttng_event_enabler *event_enabler) struct lttng_channel *chan = event_enabler->chan; struct lttng_session *session = event_enabler->chan->session; struct lttng_enabler *base_enabler = lttng_event_enabler_as_enabler(event_enabler); - struct lttng_event *event; + struct lttng_kernel_event_recorder_private *event_recorder_priv; - if (base_enabler->event_param.instrumentation == LTTNG_KERNEL_SYSCALL && - base_enabler->event_param.u.syscall.abi == LTTNG_KERNEL_SYSCALL_ABI_ALL && - base_enabler->event_param.u.syscall.match == LTTNG_KERNEL_SYSCALL_MATCH_NAME && + if (base_enabler->event_param.instrumentation == LTTNG_KERNEL_ABI_SYSCALL && + base_enabler->event_param.u.syscall.abi == LTTNG_KERNEL_ABI_SYSCALL_ABI_ALL && + base_enabler->event_param.u.syscall.match == LTTNG_KERNEL_ABI_SYSCALL_MATCH_NAME && !strcmp(base_enabler->event_param.name, "*")) { int enabled = base_enabler->enabled; - enum lttng_kernel_syscall_entryexit entryexit = base_enabler->event_param.u.syscall.entryexit; + enum lttng_kernel_abi_syscall_entryexit entryexit = base_enabler->event_param.u.syscall.entryexit; - if (entryexit == LTTNG_KERNEL_SYSCALL_ENTRY || entryexit == LTTNG_KERNEL_SYSCALL_ENTRYEXIT) + if (entryexit == LTTNG_KERNEL_ABI_SYSCALL_ENTRY || entryexit == LTTNG_KERNEL_ABI_SYSCALL_ENTRYEXIT) WRITE_ONCE(chan->syscall_all_entry, enabled); - if (entryexit == LTTNG_KERNEL_SYSCALL_EXIT || entryexit == LTTNG_KERNEL_SYSCALL_ENTRYEXIT) + if (entryexit == LTTNG_KERNEL_ABI_SYSCALL_EXIT || entryexit == LTTNG_KERNEL_ABI_SYSCALL_ENTRYEXIT) WRITE_ONCE(chan->syscall_all_exit, enabled); } @@ -2206,12 +2229,13 @@ int lttng_event_enabler_ref_events(struct lttng_event_enabler *event_enabler) lttng_create_event_if_missing(event_enabler); /* For each event matching event_enabler in session event list. */ - list_for_each_entry(event, &session->events, list) { + list_for_each_entry(event_recorder_priv, &session->events, node) { + struct lttng_kernel_event_recorder *event_recorder = event_recorder_priv->pub; struct lttng_enabler_ref *enabler_ref; - if (!lttng_event_enabler_match_event(event_enabler, event)) + if (!lttng_event_enabler_match_event(event_enabler, event_recorder)) continue; - enabler_ref = lttng_enabler_ref(&event->enablers_ref_head, + enabler_ref = lttng_enabler_ref(&event_recorder_priv->parent.enablers_ref_head, lttng_event_enabler_as_enabler(event_enabler)); if (!enabler_ref) { /* @@ -2223,24 +2247,22 @@ int lttng_event_enabler_ref_events(struct lttng_event_enabler *event_enabler) return -ENOMEM; enabler_ref->ref = lttng_event_enabler_as_enabler(event_enabler); list_add(&enabler_ref->node, - &event->enablers_ref_head); + &event_recorder_priv->parent.enablers_ref_head); } /* * Link filter bytecodes if not linked yet. */ - lttng_enabler_link_bytecode(event->desc, + lttng_enabler_link_bytecode(event_recorder_priv->parent.desc, lttng_static_ctx, - &event->filter_bytecode_runtime_head, + &event_recorder_priv->parent.filter_bytecode_runtime_head, <tng_event_enabler_as_enabler(event_enabler)->filter_bytecode_head); - - /* TODO: merge event context. */ } return 0; } /* - * Create struct lttng_event_notifier if it is missing and present in the list of + * Create struct lttng_kernel_event_notifier if it is missing and present in the list of * tracepoint probes. * Should be called with sessions mutex held. */ @@ -2248,11 +2270,11 @@ static void lttng_create_event_notifier_if_missing(struct lttng_event_notifier_enabler *event_notifier_enabler) { switch (event_notifier_enabler->base.event_param.instrumentation) { - case LTTNG_KERNEL_TRACEPOINT: + case LTTNG_KERNEL_ABI_TRACEPOINT: lttng_create_tracepoint_event_notifier_if_missing(event_notifier_enabler); break; - case LTTNG_KERNEL_SYSCALL: + case LTTNG_KERNEL_ABI_SYSCALL: lttng_create_syscall_event_notifier_if_missing(event_notifier_enabler); break; @@ -2271,20 +2293,20 @@ int lttng_event_notifier_enabler_ref_event_notifiers( { struct lttng_event_notifier_group *event_notifier_group = event_notifier_enabler->group; struct lttng_enabler *base_enabler = lttng_event_notifier_enabler_as_enabler(event_notifier_enabler); - struct lttng_event_notifier *event_notifier; + struct lttng_kernel_event_notifier_private *event_notifier_priv; - if (base_enabler->event_param.instrumentation == LTTNG_KERNEL_SYSCALL && - base_enabler->event_param.u.syscall.abi == LTTNG_KERNEL_SYSCALL_ABI_ALL && - base_enabler->event_param.u.syscall.match == LTTNG_KERNEL_SYSCALL_MATCH_NAME && + if (base_enabler->event_param.instrumentation == LTTNG_KERNEL_ABI_SYSCALL && + base_enabler->event_param.u.syscall.abi == LTTNG_KERNEL_ABI_SYSCALL_ABI_ALL && + base_enabler->event_param.u.syscall.match == LTTNG_KERNEL_ABI_SYSCALL_MATCH_NAME && !strcmp(base_enabler->event_param.name, "*")) { int enabled = base_enabler->enabled; - enum lttng_kernel_syscall_entryexit entryexit = base_enabler->event_param.u.syscall.entryexit; + enum lttng_kernel_abi_syscall_entryexit entryexit = base_enabler->event_param.u.syscall.entryexit; - if (entryexit == LTTNG_KERNEL_SYSCALL_ENTRY || entryexit == LTTNG_KERNEL_SYSCALL_ENTRYEXIT) + if (entryexit == LTTNG_KERNEL_ABI_SYSCALL_ENTRY || entryexit == LTTNG_KERNEL_ABI_SYSCALL_ENTRYEXIT) WRITE_ONCE(event_notifier_group->syscall_all_entry, enabled); - if (entryexit == LTTNG_KERNEL_SYSCALL_EXIT || entryexit == LTTNG_KERNEL_SYSCALL_ENTRYEXIT) + if (entryexit == LTTNG_KERNEL_ABI_SYSCALL_EXIT || entryexit == LTTNG_KERNEL_ABI_SYSCALL_ENTRYEXIT) WRITE_ONCE(event_notifier_group->syscall_all_exit, enabled); } @@ -2293,13 +2315,14 @@ int lttng_event_notifier_enabler_ref_event_notifiers( lttng_create_event_notifier_if_missing(event_notifier_enabler); /* Link the created event_notifier with its associated enabler. */ - list_for_each_entry(event_notifier, &event_notifier_group->event_notifiers_head, list) { + list_for_each_entry(event_notifier_priv, &event_notifier_group->event_notifiers_head, node) { + struct lttng_kernel_event_notifier *event_notifier = event_notifier_priv->pub; struct lttng_enabler_ref *enabler_ref; if (!lttng_event_notifier_enabler_match_event_notifier(event_notifier_enabler, event_notifier)) continue; - enabler_ref = lttng_enabler_ref(&event_notifier->enablers_ref_head, + enabler_ref = lttng_enabler_ref(&event_notifier_priv->parent.enablers_ref_head, lttng_event_notifier_enabler_as_enabler(event_notifier_enabler)); if (!enabler_ref) { /* @@ -2313,22 +2336,22 @@ int lttng_event_notifier_enabler_ref_event_notifiers( enabler_ref->ref = lttng_event_notifier_enabler_as_enabler( event_notifier_enabler); list_add(&enabler_ref->node, - &event_notifier->enablers_ref_head); + &event_notifier_priv->parent.enablers_ref_head); } /* * Link filter bytecodes if not linked yet. */ - lttng_enabler_link_bytecode(event_notifier->desc, - lttng_static_ctx, &event_notifier->filter_bytecode_runtime_head, + lttng_enabler_link_bytecode(event_notifier_priv->parent.desc, + lttng_static_ctx, &event_notifier_priv->parent.filter_bytecode_runtime_head, <tng_event_notifier_enabler_as_enabler(event_notifier_enabler)->filter_bytecode_head); /* Link capture bytecodes if not linked yet. */ - lttng_enabler_link_bytecode(event_notifier->desc, - lttng_static_ctx, &event_notifier->capture_bytecode_runtime_head, + lttng_enabler_link_bytecode(event_notifier_priv->parent.desc, + lttng_static_ctx, &event_notifier_priv->capture_bytecode_runtime_head, &event_notifier_enabler->capture_bytecode_head); - event_notifier->num_captures = event_notifier_enabler->num_captures; + event_notifier_priv->num_captures = event_notifier_enabler->num_captures; } return 0; } @@ -2382,7 +2405,7 @@ int lttng_fix_pending_event_notifiers(void) struct lttng_event_enabler *lttng_event_enabler_create( enum lttng_enabler_format_type format_type, - struct lttng_kernel_event *event_param, + struct lttng_kernel_abi_event *event_param, struct lttng_channel *chan) { struct lttng_event_enabler *event_enabler; @@ -2397,7 +2420,6 @@ struct lttng_event_enabler *lttng_event_enabler_create( event_enabler->chan = chan; /* ctx left NULL */ event_enabler->base.enabled = 0; - event_enabler->base.evtype = LTTNG_TYPE_ENABLER; mutex_lock(&sessions_mutex); list_add(&event_enabler->node, &event_enabler->chan->session->enablers_head); lttng_session_lazy_sync_event_enablers(event_enabler->chan->session); @@ -2425,9 +2447,9 @@ int lttng_event_enabler_disable(struct lttng_event_enabler *event_enabler) static int lttng_enabler_attach_filter_bytecode(struct lttng_enabler *enabler, - struct lttng_kernel_filter_bytecode __user *bytecode) + struct lttng_kernel_abi_filter_bytecode __user *bytecode) { - struct lttng_bytecode_node *bytecode_node; + struct lttng_kernel_bytecode_node *bytecode_node; uint32_t bytecode_len; int ret; @@ -2443,7 +2465,7 @@ int lttng_enabler_attach_filter_bytecode(struct lttng_enabler *enabler, if (ret) goto error_free; - bytecode_node->type = LTTNG_BYTECODE_NODE_TYPE_FILTER; + bytecode_node->type = LTTNG_KERNEL_BYTECODE_TYPE_FILTER; bytecode_node->enabler = enabler; /* Enforce length based on allocated size */ bytecode_node->bc.len = bytecode_len; @@ -2457,7 +2479,7 @@ error_free: } int lttng_event_enabler_attach_filter_bytecode(struct lttng_event_enabler *event_enabler, - struct lttng_kernel_filter_bytecode __user *bytecode) + struct lttng_kernel_abi_filter_bytecode __user *bytecode) { int ret; ret = lttng_enabler_attach_filter_bytecode( @@ -2472,28 +2494,22 @@ error: return ret; } -int lttng_event_add_callsite(struct lttng_event *event, - struct lttng_kernel_event_callsite __user *callsite) +int lttng_event_add_callsite(struct lttng_kernel_event_common *event, + struct lttng_kernel_abi_event_callsite __user *callsite) { - switch (event->instrumentation) { - case LTTNG_KERNEL_UPROBE: + switch (event->priv->instrumentation) { + case LTTNG_KERNEL_ABI_UPROBE: return lttng_uprobes_event_add_callsite(event, callsite); default: return -EINVAL; } } -int lttng_event_enabler_attach_context(struct lttng_event_enabler *event_enabler, - struct lttng_kernel_context *context_param) -{ - return -ENOSYS; -} - static void lttng_enabler_destroy(struct lttng_enabler *enabler) { - struct lttng_bytecode_node *filter_node, *tmp_filter_node; + struct lttng_kernel_bytecode_node *filter_node, *tmp_filter_node; /* Destroy filter bytecode */ list_for_each_entry_safe(filter_node, tmp_filter_node, @@ -2507,9 +2523,6 @@ void lttng_event_enabler_destroy(struct lttng_event_enabler *event_enabler) { lttng_enabler_destroy(lttng_event_enabler_as_enabler(event_enabler)); - /* Destroy contexts */ - lttng_kernel_destroy_context(event_enabler->ctx); - list_del(&event_enabler->node); kfree(event_enabler); } @@ -2517,7 +2530,7 @@ void lttng_event_enabler_destroy(struct lttng_event_enabler *event_enabler) struct lttng_event_notifier_enabler *lttng_event_notifier_enabler_create( struct lttng_event_notifier_group *event_notifier_group, enum lttng_enabler_format_type format_type, - struct lttng_kernel_event_notifier *event_notifier_param) + struct lttng_kernel_abi_event_notifier *event_notifier_param) { struct lttng_event_notifier_enabler *event_notifier_enabler; @@ -2534,7 +2547,6 @@ struct lttng_event_notifier_enabler *lttng_event_notifier_enabler_create( memcpy(&event_notifier_enabler->base.event_param, &event_notifier_param->event, sizeof(event_notifier_enabler->base.event_param)); - event_notifier_enabler->base.evtype = LTTNG_TYPE_ENABLER; event_notifier_enabler->base.enabled = 0; event_notifier_enabler->base.user_token = event_notifier_param->event.token; @@ -2571,7 +2583,7 @@ int lttng_event_notifier_enabler_disable( int lttng_event_notifier_enabler_attach_filter_bytecode( struct lttng_event_notifier_enabler *event_notifier_enabler, - struct lttng_kernel_filter_bytecode __user *bytecode) + struct lttng_kernel_abi_filter_bytecode __user *bytecode) { int ret; @@ -2590,9 +2602,9 @@ error: int lttng_event_notifier_enabler_attach_capture_bytecode( struct lttng_event_notifier_enabler *event_notifier_enabler, - struct lttng_kernel_capture_bytecode __user *bytecode) + struct lttng_kernel_abi_capture_bytecode __user *bytecode) { - struct lttng_bytecode_node *bytecode_node; + struct lttng_kernel_bytecode_node *bytecode_node; struct lttng_enabler *enabler = lttng_event_notifier_enabler_as_enabler(event_notifier_enabler); uint32_t bytecode_len; @@ -2612,7 +2624,7 @@ int lttng_event_notifier_enabler_attach_capture_bytecode( if (ret) goto error_free; - bytecode_node->type = LTTNG_BYTECODE_NODE_TYPE_CAPTURE; + bytecode_node->type = LTTNG_KERNEL_BYTECODE_TYPE_CAPTURE; bytecode_node->enabler = enabler; /* Enforce length based on allocated size */ @@ -2630,26 +2642,6 @@ end: return ret; } -int lttng_event_notifier_add_callsite(struct lttng_event_notifier *event_notifier, - struct lttng_kernel_event_callsite __user *callsite) -{ - - switch (event_notifier->instrumentation) { - case LTTNG_KERNEL_UPROBE: - return lttng_uprobes_event_notifier_add_callsite(event_notifier, - callsite); - default: - return -EINVAL; - } -} - -int lttng_event_notifier_enabler_attach_context( - struct lttng_event_notifier_enabler *event_notifier_enabler, - struct lttng_kernel_context *context_param) -{ - return -ENOSYS; -} - static void lttng_event_notifier_enabler_destroy( struct lttng_event_notifier_enabler *event_notifier_enabler) @@ -2673,7 +2665,7 @@ static void lttng_session_sync_event_enablers(struct lttng_session *session) { struct lttng_event_enabler *event_enabler; - struct lttng_event *event; + struct lttng_kernel_event_recorder_private *event_recorder_priv; list_for_each_entry(event_enabler, &session->enablers_head, node) lttng_event_enabler_ref_events(event_enabler); @@ -2682,17 +2674,19 @@ void lttng_session_sync_event_enablers(struct lttng_session *session) * and its channel and session transient states are enabled, we * enable the event, else we disable it. */ - list_for_each_entry(event, &session->events, list) { + list_for_each_entry(event_recorder_priv, &session->events, node) { + struct lttng_kernel_event_recorder *event_recorder = event_recorder_priv->pub; struct lttng_enabler_ref *enabler_ref; - struct lttng_bytecode_runtime *runtime; - int enabled = 0, has_enablers_without_bytecode = 0; + struct lttng_kernel_bytecode_runtime *runtime; + int enabled = 0, has_enablers_without_filter_bytecode = 0; + int nr_filters = 0; - switch (event->instrumentation) { - case LTTNG_KERNEL_TRACEPOINT: /* Fall-through */ - case LTTNG_KERNEL_SYSCALL: + switch (event_recorder_priv->parent.instrumentation) { + case LTTNG_KERNEL_ABI_TRACEPOINT: /* Fall-through */ + case LTTNG_KERNEL_ABI_SYSCALL: /* Enable events */ list_for_each_entry(enabler_ref, - &event->enablers_ref_head, node) { + &event_recorder_priv->parent.enablers_ref_head, node) { if (enabler_ref->ref->enabled) { enabled = 1; break; @@ -2709,35 +2703,39 @@ void lttng_session_sync_event_enablers(struct lttng_session *session) * intesection of session and channel transient enable * states. */ - enabled = enabled && session->tstate && event->chan->tstate; + enabled = enabled && session->tstate && event_recorder->chan->tstate; - WRITE_ONCE(event->enabled, enabled); + WRITE_ONCE(event_recorder->parent.enabled, enabled); /* * Sync tracepoint registration with event enabled * state. */ if (enabled) { - register_event(event); + register_event(event_recorder); } else { - _lttng_event_unregister(event); + _lttng_event_unregister(event_recorder); } /* Check if has enablers without bytecode enabled */ list_for_each_entry(enabler_ref, - &event->enablers_ref_head, node) { + &event_recorder_priv->parent.enablers_ref_head, node) { if (enabler_ref->ref->enabled && list_empty(&enabler_ref->ref->filter_bytecode_head)) { - has_enablers_without_bytecode = 1; + has_enablers_without_filter_bytecode = 1; break; } } - event->has_enablers_without_bytecode = - has_enablers_without_bytecode; + event_recorder_priv->parent.has_enablers_without_filter_bytecode = + has_enablers_without_filter_bytecode; /* Enable filters */ list_for_each_entry(runtime, - &event->filter_bytecode_runtime_head, node) - lttng_bytecode_filter_sync_state(runtime); + &event_recorder_priv->parent.filter_bytecode_runtime_head, node) { + lttng_bytecode_sync_state(runtime); + nr_filters++; + } + WRITE_ONCE(event_recorder_priv->parent.pub->eval_filter, + !(has_enablers_without_filter_bytecode || !nr_filters)); } } @@ -2761,7 +2759,7 @@ static void lttng_event_notifier_group_sync_enablers(struct lttng_event_notifier_group *event_notifier_group) { struct lttng_event_notifier_enabler *event_notifier_enabler; - struct lttng_event_notifier *event_notifier; + struct lttng_kernel_event_notifier_private *event_notifier_priv; list_for_each_entry(event_notifier_enabler, &event_notifier_group->enablers_head, node) lttng_event_notifier_enabler_ref_event_notifiers(event_notifier_enabler); @@ -2770,17 +2768,19 @@ void lttng_event_notifier_group_sync_enablers(struct lttng_event_notifier_group * For each event_notifier, if at least one of its enablers is enabled, * we enable the event_notifier, else we disable it. */ - list_for_each_entry(event_notifier, &event_notifier_group->event_notifiers_head, list) { + list_for_each_entry(event_notifier_priv, &event_notifier_group->event_notifiers_head, node) { + struct lttng_kernel_event_notifier *event_notifier = event_notifier_priv->pub; struct lttng_enabler_ref *enabler_ref; - struct lttng_bytecode_runtime *runtime; - int enabled = 0, has_enablers_without_bytecode = 0; + struct lttng_kernel_bytecode_runtime *runtime; + int enabled = 0, has_enablers_without_filter_bytecode = 0; + int nr_filters = 0, nr_captures = 0; - switch (event_notifier->instrumentation) { - case LTTNG_KERNEL_TRACEPOINT: /* Fall-through */ - case LTTNG_KERNEL_SYSCALL: + switch (event_notifier_priv->parent.instrumentation) { + case LTTNG_KERNEL_ABI_TRACEPOINT: /* Fall-through */ + case LTTNG_KERNEL_ABI_SYSCALL: /* Enable event_notifiers */ list_for_each_entry(enabler_ref, - &event_notifier->enablers_ref_head, node) { + &event_notifier_priv->parent.enablers_ref_head, node) { if (enabler_ref->ref->enabled) { enabled = 1; break; @@ -2793,42 +2793,47 @@ void lttng_event_notifier_group_sync_enablers(struct lttng_event_notifier_group continue; } - WRITE_ONCE(event_notifier->enabled, enabled); + WRITE_ONCE(event_notifier->parent.enabled, enabled); /* * Sync tracepoint registration with event_notifier enabled * state. */ if (enabled) { - if (!event_notifier->registered) + if (!event_notifier_priv->parent.registered) register_event_notifier(event_notifier); } else { - if (event_notifier->registered) + if (event_notifier_priv->parent.registered) _lttng_event_notifier_unregister(event_notifier); } /* Check if has enablers without bytecode enabled */ list_for_each_entry(enabler_ref, - &event_notifier->enablers_ref_head, node) { + &event_notifier_priv->parent.enablers_ref_head, node) { if (enabler_ref->ref->enabled && list_empty(&enabler_ref->ref->filter_bytecode_head)) { - has_enablers_without_bytecode = 1; + has_enablers_without_filter_bytecode = 1; break; } } - event_notifier->has_enablers_without_bytecode = - has_enablers_without_bytecode; + event_notifier_priv->parent.has_enablers_without_filter_bytecode = + has_enablers_without_filter_bytecode; /* Enable filters */ list_for_each_entry(runtime, - &event_notifier->filter_bytecode_runtime_head, node) - lttng_bytecode_filter_sync_state(runtime); + &event_notifier_priv->parent.filter_bytecode_runtime_head, node) { + lttng_bytecode_sync_state(runtime); + nr_filters++; + } + WRITE_ONCE(event_notifier_priv->parent.pub->eval_filter, + !(has_enablers_without_filter_bytecode || !nr_filters)); /* Enable captures */ list_for_each_entry(runtime, - &event_notifier->capture_bytecode_runtime_head, node) - lttng_bytecode_capture_sync_state(runtime); - - WRITE_ONCE(event_notifier->eval_capture, !!event_notifier->num_captures); + &event_notifier_priv->capture_bytecode_runtime_head, node) { + lttng_bytecode_sync_state(runtime); + nr_captures++; + } + WRITE_ONCE(event_notifier->eval_capture, !!nr_captures); } } @@ -2874,14 +2879,14 @@ int lttng_metadata_output_channel(struct lttng_metadata_stream *stream, if (!len) goto end; reserve_len = min_t(size_t, - stream->transport->ops.packet_avail_size(chan), + stream->transport->ops.priv->packet_avail_size(chan), len); - lib_ring_buffer_ctx_init(&ctx, chan, NULL, reserve_len, - sizeof(char), -1); + lib_ring_buffer_ctx_init(&ctx, chan, reserve_len, + sizeof(char), NULL); /* * If reservation failed, return an error to the caller. */ - ret = stream->transport->ops.event_reserve(&ctx, 0); + ret = stream->transport->ops.event_reserve(&ctx); if (ret != 0) { printk(KERN_WARNING "LTTng: Metadata event reservation failed\n"); stream->coherent = false; @@ -3047,6 +3052,7 @@ int _lttng_struct_type_statedump(struct lttng_session *session, const struct lttng_kernel_type_struct *type, size_t nesting) { + const char *prev_field_name = NULL; int ret; uint32_t i, nr_fields; unsigned int alignment; @@ -3063,7 +3069,7 @@ int _lttng_struct_type_statedump(struct lttng_session *session, const struct lttng_kernel_event_field *iter_field; iter_field = type->fields[i]; - ret = _lttng_field_statedump(session, iter_field, nesting + 1); + ret = _lttng_field_statedump(session, iter_field, nesting + 1, &prev_field_name); if (ret) return ret; } @@ -3105,11 +3111,18 @@ int _lttng_struct_field_statedump(struct lttng_session *session, static int _lttng_variant_type_statedump(struct lttng_session *session, const struct lttng_kernel_type_variant *type, - size_t nesting) + size_t nesting, + const char *prev_field_name) { + const char *tag_name; int ret; uint32_t i, nr_choices; + tag_name = type->tag_name; + if (!tag_name) + tag_name = prev_field_name; + if (!tag_name) + return -EINVAL; /* * CTF 1.8 does not allow expressing nonzero variant alignment in a nestable way. */ @@ -3120,7 +3133,7 @@ int _lttng_variant_type_statedump(struct lttng_session *session, return ret; ret = lttng_metadata_printf(session, "variant <_%s> {\n", - type->tag_name); + tag_name); if (ret) return ret; nr_choices = type->nr_choices; @@ -3128,7 +3141,7 @@ int _lttng_variant_type_statedump(struct lttng_session *session, const struct lttng_kernel_event_field *iter_field; iter_field = type->choices[i]; - ret = _lttng_field_statedump(session, iter_field, nesting + 1); + ret = _lttng_field_statedump(session, iter_field, nesting + 1, NULL); if (ret) return ret; } @@ -3146,12 +3159,14 @@ int _lttng_variant_type_statedump(struct lttng_session *session, static int _lttng_variant_field_statedump(struct lttng_session *session, const struct lttng_kernel_event_field *field, - size_t nesting) + size_t nesting, + const char *prev_field_name) { int ret; ret = _lttng_variant_type_statedump(session, - lttng_kernel_get_type_variant(field->type), nesting); + lttng_kernel_get_type_variant(field->type), nesting, + prev_field_name); if (ret) return ret; return lttng_field_name_statedump(session, field, nesting); @@ -3214,7 +3229,8 @@ int _lttng_array_field_statedump(struct lttng_session *session, static int _lttng_sequence_field_statedump(struct lttng_session *session, const struct lttng_kernel_event_field *field, - size_t nesting) + size_t nesting, + const char *prev_field_name) { int ret; const char *length_name; @@ -3225,6 +3241,10 @@ int _lttng_sequence_field_statedump(struct lttng_session *session, WARN_ON_ONCE(!sequence_type); length_name = sequence_type->length_name; + if (!length_name) + length_name = prev_field_name; + if (!length_name) + return -EINVAL; if (sequence_type->alignment) { ret = print_tabs(session, nesting); @@ -3259,7 +3279,7 @@ int _lttng_sequence_field_statedump(struct lttng_session *session, ret = lttng_metadata_printf(session, " _%s[ _%s ];\n", field->name, - sequence_type->length_name); + length_name); return ret; } @@ -3482,7 +3502,7 @@ int _lttng_type_statedump(struct lttng_session *session, case lttng_kernel_type_variant: ret = _lttng_variant_type_statedump(session, lttng_kernel_get_type_variant(type), - nesting); + nesting, NULL); break; /* Nested arrays and sequences are not supported yet. */ @@ -3501,10 +3521,14 @@ int _lttng_type_statedump(struct lttng_session *session, static int _lttng_field_statedump(struct lttng_session *session, const struct lttng_kernel_event_field *field, - size_t nesting) + size_t nesting, + const char **prev_field_name_p) { + const char *prev_field_name = NULL; int ret = 0; + if (prev_field_name_p) + prev_field_name = *prev_field_name_p; switch (field->type->type) { case lttng_kernel_type_integer: ret = _lttng_integer_field_statedump(session, field, nesting); @@ -3522,16 +3546,18 @@ int _lttng_field_statedump(struct lttng_session *session, ret = _lttng_array_field_statedump(session, field, nesting); break; case lttng_kernel_type_sequence: - ret = _lttng_sequence_field_statedump(session, field, nesting); + ret = _lttng_sequence_field_statedump(session, field, nesting, prev_field_name); break; case lttng_kernel_type_variant: - ret = _lttng_variant_field_statedump(session, field, nesting); + ret = _lttng_variant_field_statedump(session, field, nesting, prev_field_name); break; default: WARN_ON_ONCE(1); return -EINVAL; } + if (prev_field_name_p) + *prev_field_name_p = field->name; return ret; } @@ -3539,6 +3565,7 @@ static int _lttng_context_metadata_statedump(struct lttng_session *session, struct lttng_kernel_ctx *ctx) { + const char *prev_field_name = NULL; int ret = 0; int i; @@ -3547,7 +3574,7 @@ int _lttng_context_metadata_statedump(struct lttng_session *session, for (i = 0; i < ctx->nr_fields; i++) { const struct lttng_kernel_ctx_field *field = &ctx->fields[i]; - ret = _lttng_field_statedump(session, field->event_field, 2); + ret = _lttng_field_statedump(session, field->event_field, 2, &prev_field_name); if (ret) return ret; } @@ -3556,16 +3583,17 @@ int _lttng_context_metadata_statedump(struct lttng_session *session, static int _lttng_fields_metadata_statedump(struct lttng_session *session, - struct lttng_event *event) + struct lttng_kernel_event_recorder *event_recorder) { - const struct lttng_kernel_event_desc *desc = event->desc; + const char *prev_field_name = NULL; + const struct lttng_kernel_event_desc *desc = event_recorder->priv->parent.desc; int ret = 0; int i; for (i = 0; i < desc->nr_fields; i++) { const struct lttng_kernel_event_field *field = desc->fields[i]; - ret = _lttng_field_statedump(session, field, 2); + ret = _lttng_field_statedump(session, field, 2, &prev_field_name); if (ret) return ret; } @@ -3580,11 +3608,11 @@ int _lttng_fields_metadata_statedump(struct lttng_session *session, static int _lttng_event_metadata_statedump(struct lttng_session *session, struct lttng_channel *chan, - struct lttng_event *event) + struct lttng_kernel_event_recorder *event_recorder) { int ret = 0; - if (event->metadata_dumped || !LTTNG_READ_ONCE(session->active)) + if (event_recorder->priv->metadata_dumped || !LTTNG_READ_ONCE(session->active)) return 0; if (chan->channel_type == METADATA_CHANNEL) return 0; @@ -3596,27 +3624,11 @@ int _lttng_event_metadata_statedump(struct lttng_session *session, " name = \"%s\";\n" " id = %u;\n" " stream_id = %u;\n", - event->desc->event_name, - event->id, - event->chan->id); - if (ret) - goto end; - - if (event->ctx) { - ret = lttng_metadata_printf(session, - " context := struct {\n"); - if (ret) - goto end; - } - ret = _lttng_context_metadata_statedump(session, event->ctx); + event_recorder->priv->parent.desc->event_name, + event_recorder->priv->id, + event_recorder->chan->id); if (ret) goto end; - if (event->ctx) { - ret = lttng_metadata_printf(session, - " };\n"); - if (ret) - goto end; - } ret = lttng_metadata_printf(session, " fields := struct {\n" @@ -3624,7 +3636,7 @@ int _lttng_event_metadata_statedump(struct lttng_session *session, if (ret) goto end; - ret = _lttng_fields_metadata_statedump(session, event); + ret = _lttng_fields_metadata_statedump(session, event_recorder); if (ret) goto end; @@ -3638,7 +3650,7 @@ int _lttng_event_metadata_statedump(struct lttng_session *session, if (ret) goto end; - event->metadata_dumped = 1; + event_recorder->priv->metadata_dumped = 1; end: lttng_metadata_end(session); return ret; @@ -3880,7 +3892,7 @@ int _lttng_session_metadata_statedump(struct lttng_session *session) unsigned char uuid_s[37], clock_uuid_s[BOOT_ID_LEN]; const char *product_uuid; struct lttng_channel *chan; - struct lttng_event *event; + struct lttng_kernel_event_recorder_private *event_recorder_priv; int ret = 0; if (!LTTNG_READ_ONCE(session->active)) @@ -4053,8 +4065,9 @@ skip_session: goto end; } - list_for_each_entry(event, &session->events, list) { - ret = _lttng_event_metadata_statedump(session, event->chan, event); + list_for_each_entry(event_recorder_priv, &session->events, node) { + ret = _lttng_event_metadata_statedump(session, event_recorder_priv->pub->chan, + event_recorder_priv->pub); if (ret) goto end; } @@ -4275,16 +4288,26 @@ static int __init lttng_events_init(void) ret = lttng_tracepoint_init(); if (ret) goto error_tp; - event_cache = KMEM_CACHE(lttng_event, 0); - if (!event_cache) { + event_recorder_cache = KMEM_CACHE(lttng_kernel_event_recorder, 0); + if (!event_recorder_cache) { + ret = -ENOMEM; + goto error_kmem_event_recorder; + } + event_recorder_private_cache = KMEM_CACHE(lttng_kernel_event_recorder_private, 0); + if (!event_recorder_private_cache) { ret = -ENOMEM; - goto error_kmem_event; + goto error_kmem_event_recorder_private; } - event_notifier_cache = KMEM_CACHE(lttng_event_notifier, 0); + event_notifier_cache = KMEM_CACHE(lttng_kernel_event_notifier, 0); if (!event_notifier_cache) { ret = -ENOMEM; goto error_kmem_event_notifier; } + event_notifier_private_cache = KMEM_CACHE(lttng_kernel_event_notifier_private, 0); + if (!event_notifier_private_cache) { + ret = -ENOMEM; + goto error_kmem_event_notifier_private; + } ret = lttng_abi_init(); if (ret) goto error_abi; @@ -4317,10 +4340,14 @@ error_hotplug: error_logger: lttng_abi_exit(); error_abi: + kmem_cache_destroy(event_notifier_private_cache); +error_kmem_event_notifier_private: kmem_cache_destroy(event_notifier_cache); error_kmem_event_notifier: - kmem_cache_destroy(event_cache); -error_kmem_event: + kmem_cache_destroy(event_recorder_private_cache); +error_kmem_event_recorder_private: + kmem_cache_destroy(event_recorder_cache); +error_kmem_event_recorder: lttng_tracepoint_exit(); error_tp: lttng_context_exit(); @@ -4354,8 +4381,10 @@ static void __exit lttng_events_exit(void) lttng_abi_exit(); list_for_each_entry_safe(session, tmpsession, &sessions, list) lttng_session_destroy(session); - kmem_cache_destroy(event_cache); + kmem_cache_destroy(event_recorder_cache); + kmem_cache_destroy(event_recorder_private_cache); kmem_cache_destroy(event_notifier_cache); + kmem_cache_destroy(event_notifier_private_cache); lttng_tracepoint_exit(); lttng_context_exit(); printk(KERN_NOTICE "LTTng: Unloaded modules v%s.%s.%s%s (%s)%s%s\n",