X-Git-Url: https://git.lttng.org/?a=blobdiff_plain;f=src%2Flib%2Flttng-ctl%2Fload.c;h=0f9ccfa0e86143800a7be426f0574df1d6ba8274;hb=28ab59d0baef178a8629ec9fb517ba75efb46ea8;hp=be236f242b25b9fb0096ba42e73167d6400fb38b;hpb=0d4bab5e4bd1654515ce754a3d9699cafe9b41b2;p=lttng-tools.git

diff --git a/src/lib/lttng-ctl/load.c b/src/lib/lttng-ctl/load.c
index be236f242..0f9ccfa0e 100644
--- a/src/lib/lttng-ctl/load.c
+++ b/src/lib/lttng-ctl/load.c
@@ -43,19 +43,49 @@ void reset_load_session_attr_urls(struct lttng_load_session_attr *attr)
 	free(attr->raw_override_path_url);
 	free(attr->raw_override_ctrl_url);
 	free(attr->raw_override_data_url);
-	free(attr->override_attr.path_url);
-	free(attr->override_attr.ctrl_url);
-	free(attr->override_attr.data_url);
+	if (attr->override_attr) {
+		free(attr->override_attr->path_url);
+		free(attr->override_attr->ctrl_url);
+		free(attr->override_attr->data_url);
+		free(attr->override_attr->session_name);
+	}
 }
 
 void lttng_load_session_attr_destroy(struct lttng_load_session_attr *attr)
 {
 	if (attr) {
 		reset_load_session_attr_urls(attr);
+		free(attr->override_attr);
 		free(attr);
 	}
 }
 
+static int validate_attr(const struct lttng_load_session_attr *attr)
+{
+	int ret = 0;
+
+	if (!attr) {
+		ret = -LTTNG_ERR_INVALID;
+		goto end;
+	}
+
+	if (!attr->override_attr) {
+		goto end;
+	}
+
+	/*
+	 * Refuse override name if the objective is to load multiple session
+	 * since this operation is ambiguous while loading multiple session.
+	 */
+	if (attr->override_attr->session_name
+			&& attr->session_name[0] == '\0') {
+		ret = -LTTNG_ERR_INVALID;
+		goto end;
+	}
+end:
+	return ret;
+}
+
 const char *lttng_load_session_attr_get_session_name(
 	struct lttng_load_session_attr *attr)
 {
@@ -86,53 +116,63 @@ int lttng_load_session_attr_get_overwrite(
 	return attr ? attr->overwrite : -LTTNG_ERR_INVALID;
 }
 
-const char *lttng_load_session_attr_get_override_path_url(
+const char *lttng_load_session_attr_get_override_ctrl_url(
 	struct lttng_load_session_attr *attr)
 {
 	const char *ret = NULL;
 
-	if (attr && attr->override_attr.path_url) {
-		ret = attr->raw_override_path_url;
+	if (!attr || !attr->override_attr) {
+		goto end;
 	}
 
+	ret = attr->raw_override_ctrl_url;
+end:
 	return ret;
 }
 
-const char *lttng_load_session_attr_get_override_ctrl_url(
+const char *lttng_load_session_attr_get_override_data_url(
 	struct lttng_load_session_attr *attr)
 {
 	const char *ret = NULL;
 
-	if (attr && attr->override_attr.ctrl_url) {
-		ret = attr->raw_override_ctrl_url;
+	if (!attr || !attr->override_attr) {
+		goto end;
 	}
 
+	ret = attr->raw_override_data_url;
+end:
 	return ret;
 }
 
-const char *lttng_load_session_attr_get_override_data_url(
-	struct lttng_load_session_attr *attr)
+const char *lttng_load_session_attr_get_override_url(
+		struct lttng_load_session_attr *attr)
 {
 	const char *ret = NULL;
 
-	if (attr && attr->override_attr.data_url) {
-		ret = attr->raw_override_data_url;
+	if (!attr || !attr->override_attr) {
+		goto end;
 	}
 
+	if ((attr->override_attr->path_url ||
+		(attr->override_attr->ctrl_url &&
+		 attr->override_attr->data_url))) {
+		ret = attr->raw_override_url;
+	}
+end:
 	return ret;
 }
 
-const char *lttng_load_session_attr_get_override_url(
+const char *lttng_load_session_attr_get_override_session_name(
 		struct lttng_load_session_attr *attr)
 {
 	const char *ret = NULL;
 
-	if (attr && (attr->override_attr.path_url ||
-		(attr->override_attr.ctrl_url &&
-		 attr->override_attr.data_url))) {
-		ret = attr->raw_override_url;
+	if (!attr || !attr->override_attr) {
+		goto end;
 	}
 
+	ret = attr->override_attr->session_name;
+end:
 	return ret;
 }
 
@@ -155,7 +195,12 @@ int lttng_load_session_attr_set_session_name(
 			goto error;
 		}
 
-		strncpy(attr->session_name, session_name, len);
+		ret = lttng_strncpy(attr->session_name, session_name,
+				sizeof(attr->session_name));
+		if (ret) {
+			ret = -LTTNG_ERR_INVALID;
+			goto error;
+		}
 	} else {
 		attr->session_name[0] = '\0';
 	}
@@ -233,12 +278,19 @@ int lttng_load_session_attr_set_override_ctrl_url(
 		goto end;
 	}
 
-	if (attr->override_attr.path_url) {
+	if (!attr->override_attr) {
+		attr->override_attr = zmalloc(
+			sizeof(struct config_load_session_override_attr));
+		if (!attr->override_attr) {
+			ret = -LTTNG_ERR_NOMEM;
+			goto end;
+		}
+	}
+
+	if (attr->override_attr->path_url) {
 		/*
-		 * FIXME: return a more meaningful error.
-		 * Setting a ctrl override after a path override make no
-		 * sense.
-		 * */
+		 * Setting a ctrl override after a path override makes no sense.
+		 */
 		ret = -LTTNG_ERR_INVALID;
 		goto end;
 	}
@@ -279,11 +331,11 @@ int lttng_load_session_attr_set_override_ctrl_url(
 	}
 
 	/* Squash old value if any */
-	free(attr->override_attr.ctrl_url);
+	free(attr->override_attr->ctrl_url);
 	free(attr->raw_override_ctrl_url);
 
 	/* Populate the object */
-	attr->override_attr.ctrl_url = url_str;
+	attr->override_attr->ctrl_url = url_str;
 	attr->raw_override_ctrl_url = raw_str;
 
 	/* Ownership passed to attr. */
@@ -311,7 +363,19 @@ int lttng_load_session_attr_set_override_data_url(
 		goto end;
 	}
 
-	if (attr->override_attr.path_url) {
+	if (!attr->override_attr) {
+		attr->override_attr = zmalloc(
+			sizeof(struct config_load_session_override_attr));
+		if (!attr->override_attr) {
+			ret = -LTTNG_ERR_NOMEM;
+			goto end;
+		}
+	}
+
+	if (attr->override_attr->path_url) {
+		/*
+		 * Setting a data override after a path override makes no sense.
+		 */
 		ret = -LTTNG_ERR_INVALID;
 		goto end;
 	}
@@ -351,11 +415,11 @@ int lttng_load_session_attr_set_override_data_url(
 	}
 
 	/* Squash old value if any */
-	free(attr->override_attr.data_url);
+	free(attr->override_attr->data_url);
 	free(attr->raw_override_data_url);
 
 	/* Populate the object */
-	attr->override_attr.data_url = url_str;
+	attr->override_attr->data_url = url_str;
 	attr->raw_override_data_url = raw_str;
 
 	/* Ownership passed to attr. */
@@ -388,6 +452,15 @@ int lttng_load_session_attr_set_override_url(
 		goto end;
 	}
 
+	if (!attr->override_attr) {
+		attr->override_attr = zmalloc(
+			sizeof(struct config_load_session_override_attr));
+		if (!attr->override_attr) {
+			ret = -LTTNG_ERR_NOMEM;
+			goto end;
+		}
+	}
+
 	/*
 	 * FIXME: uri_parse should be able to take as parameter the protocol
 	 * type to validate "url". For now only check the parsing goes through;
@@ -475,9 +548,9 @@ int lttng_load_session_attr_set_override_url(
 
 	reset_load_session_attr_urls(attr);
 
-	attr->override_attr.path_url = path_str;
-	attr->override_attr.ctrl_url = ctrl_str;
-	attr->override_attr.data_url = data_str;
+	attr->override_attr->path_url = path_str;
+	attr->override_attr->ctrl_url = ctrl_str;
+	attr->override_attr->data_url = data_str;
 
 	attr->raw_override_url = raw_url_str;
 	attr->raw_override_path_url = raw_path_str;
@@ -505,6 +578,42 @@ end:
 	return ret;
 }
 
+int lttng_load_session_attr_set_override_session_name(
+	struct lttng_load_session_attr *attr, const char *session_name)
+{
+	int ret = 0;
+	size_t len;
+
+	if (!attr ||!session_name) {
+		ret = -LTTNG_ERR_INVALID;
+		goto end;
+	}
+
+	if (!attr->override_attr) {
+		attr->override_attr = zmalloc(
+			sizeof(struct config_load_session_override_attr));
+		if (!attr->override_attr) {
+			ret = -LTTNG_ERR_NOMEM;
+			goto end;
+		}
+	}
+
+	len = strlen(session_name);
+	if (len >= LTTNG_NAME_MAX) {
+		ret = -LTTNG_ERR_INVALID;
+		goto end;
+	}
+
+	attr->override_attr->session_name = lttng_strndup(session_name,
+		len);
+	if (!attr->override_attr->session_name) {
+		ret = -LTTNG_ERR_NOMEM;
+		goto end;
+	}
+end:
+	return ret;
+}
+
 int lttng_load_session(struct lttng_load_session_attr *attr)
 {
 	int ret;
@@ -515,11 +624,17 @@ int lttng_load_session(struct lttng_load_session_attr *attr)
 		goto end;
 	}
 
+	ret = validate_attr(attr);
+	if (ret) {
+		goto end;
+	}
+
 	url = attr->input_url[0] != '\0' ? attr->input_url : NULL;
 	session_name = attr->session_name[0] != '\0' ?
 			attr->session_name : NULL;
 
-	ret = config_load_session(url, session_name, attr->overwrite, 0);
+	ret = config_load_session(url, session_name, attr->overwrite, 0,
+			attr->override_attr);
 
 end:
 	return ret;