X-Git-Url: https://git.lttng.org/?a=blobdiff_plain;f=src%2Fcommon%2Frunas.c;h=ddb2f18bf62c34f3508dfbae8c0a1d080dec4c69;hb=a5ae566aaff1a5f9cb85cb2dadd520ab8be9a214;hp=bee107951d8664e6f111ed5ff260574407f0c3a3;hpb=a440509044c2828bf6dbfb05e8d9d6d0277ce1a4;p=lttng-tools.git diff --git a/src/common/runas.c b/src/common/runas.c index bee107951..ddb2f18bf 100644 --- a/src/common/runas.c +++ b/src/common/runas.c @@ -42,6 +42,14 @@ #define MAP_STACK 0 #endif +#ifndef MAP_GROWSDOWN +#define GROWSDOWN 0 +#endif + +#ifndef MAP_ANONYMOUS +#define MAP_ANONYMOUS MAP_ANON +#endif + struct run_as_data { int (*cmd)(void *data); void *data; @@ -217,6 +225,7 @@ int run_as(int (*cmd)(void *data), void *data, uid_t uid, gid_t gid) ret = pipe(retval_pipe); if (ret < 0) { perror("pipe"); + retval.i = ret; goto end; } run_as_data.data = data; @@ -230,19 +239,18 @@ int run_as(int (*cmd)(void *data), void *data, uid_t uid, gid_t gid) -1, 0); if (child_stack == MAP_FAILED) { perror("mmap"); - ret = -ENOMEM; + retval.i = -ENOMEM; goto close_pipe; } /* * Pointing to the middle of the stack to support architectures * where the stack grows up (HPPA). */ - pid = clone(child_run_as, child_stack + (RUNAS_CHILD_STACK_SIZE / 2), - CLONE_FILES | SIGCHLD, - &run_as_data, NULL); + pid = lttng_clone_files(child_run_as, child_stack + (RUNAS_CHILD_STACK_SIZE / 2), + &run_as_data); if (pid < 0) { perror("clone"); - ret = pid; + retval.i = pid; goto unmap_stack; } /* receive return value */ @@ -266,12 +274,13 @@ int run_as(int (*cmd)(void *data), void *data, uid_t uid, gid_t gid) pid = waitpid(pid, &status, 0); if (pid < 0 || !WIFEXITED(status) || WEXITSTATUS(status) != 0) { perror("wait"); - ret = -1; + retval.i = -1; } unmap_stack: ret = munmap(child_stack, RUNAS_CHILD_STACK_SIZE); if (ret < 0) { perror("munmap"); + retval.i = ret; } close_pipe: close(retval_pipe[0]);