X-Git-Url: https://git.lttng.org/?a=blobdiff_plain;f=src%2Fcommon%2Freadwrite.c;h=a862d1cffd1f9e195ed294e13f1a3438dbf094f4;hb=df5b86c84d896eb2d74a8757c234492c1d1fc3be;hp=43d4e39eeeaed22896337995b440ba2e5fe46952;hpb=33b141366b29aa086ecb8d06808d7ba91f83cb1e;p=lttng-tools.git

diff --git a/src/common/readwrite.c b/src/common/readwrite.c
index 43d4e39ee..a862d1cff 100644
--- a/src/common/readwrite.c
+++ b/src/common/readwrite.c
@@ -15,7 +15,13 @@
  * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
  */
 
+#define _GNU_SOURCE
+#define _LGPL_SOURCE
+#include <assert.h>
+#include <errno.h>
+#include <limits.h>
 #include <unistd.h>
+
 #include "readwrite.h"
 
 /*
@@ -31,8 +37,18 @@ ssize_t lttng_read(int fd, void *buf, size_t count)
 	size_t i = 0;
 	ssize_t ret;
 
+	assert(buf);
+
+	/*
+	 * Deny a read count that can be bigger then the returned value max size.
+	 * This makes the function to never return an overflow value.
+	 */
+	if (count > SSIZE_MAX) {
+		return -EINVAL;
+	}
+
 	do {
-		ret = read(fd, &buf[i], count - i);
+		ret = read(fd, buf + i, count - i);
 		if (ret < 0) {
 			if (errno == EINTR) {
 				continue;	/* retry operation */
@@ -58,8 +74,18 @@ ssize_t lttng_write(int fd, const void *buf, size_t count)
 	size_t i = 0;
 	ssize_t ret;
 
+	assert(buf);
+
+	/*
+	 * Deny a write count that can be bigger then the returned value max size.
+	 * This makes the function to never return an overflow value.
+	 */
+	if (count > SSIZE_MAX) {
+		return -EINVAL;
+	}
+
 	do {
-		ret = write(fd, &buf[i], count - i);
+		ret = write(fd, buf + i, count - i);
 		if (ret < 0) {
 			if (errno == EINTR) {
 				continue;	/* retry operation */