X-Git-Url: https://git.lttng.org/?a=blobdiff_plain;f=src%2Fcommon%2Fnotification.c;h=a4e971bd572c159b4a54d90643965dd1479b937d;hb=e957bf98e634c79b13281d0a2fe144be0245d310;hp=2544d042fd8192ee309558df6b41e483dc4db3ca;hpb=9e620ea7b016fc3fd4e08b5d094ffa40b36b50f6;p=lttng-tools.git diff --git a/src/common/notification.c b/src/common/notification.c index 2544d042f..a4e971bd5 100644 --- a/src/common/notification.c +++ b/src/common/notification.c @@ -78,16 +78,25 @@ ssize_t lttng_notification_create_from_payload( struct lttng_notification **notification) { ssize_t ret, notification_size = 0, condition_size, evaluation_size; - const struct lttng_notification_comm *notification_comm; struct lttng_condition *condition; struct lttng_evaluation *evaluation; + const struct lttng_notification_comm *notification_comm; + const struct lttng_payload_view notification_comm_view = + lttng_payload_view_from_view( + src_view, 0, sizeof(*notification_comm)); if (!src_view || !notification) { ret = -1; goto end; } - notification_comm = (typeof(notification_comm)) src_view->buffer.data; + if (!lttng_payload_view_is_valid(¬ification_comm_view)) { + /* Payload not large enough to contain the header. */ + ret = -1; + goto end; + } + + notification_comm = (typeof(notification_comm)) notification_comm_view.buffer.data; notification_size += sizeof(*notification_comm); { /* struct lttng_condition */ @@ -113,7 +122,7 @@ ssize_t lttng_notification_create_from_payload( notification_size, -1); evaluation_size = lttng_evaluation_create_from_payload( - &evaluation_view, &evaluation); + condition, &evaluation_view, &evaluation); } if (evaluation_size < 0) {