X-Git-Url: https://git.lttng.org/?a=blobdiff_plain;f=src%2Fcommon%2Fevent-rule%2Fsyscall.c;h=88cfde6b6a268d7c1a016af22fd71194b88e8548;hb=b2eeb0d5db1245d03f5bfc300a42ee3e9615237f;hp=b2feb2c6ecf4c772049d9c41d304544f185959d1;hpb=58daac01d91347336f24e1fc1cacd4e7a3101e93;p=lttng-tools.git

diff --git a/src/common/event-rule/syscall.c b/src/common/event-rule/syscall.c
index b2feb2c6e..88cfde6b6 100644
--- a/src/common/event-rule/syscall.c
+++ b/src/common/event-rule/syscall.c
@@ -12,6 +12,9 @@
 #include <common/payload.h>
 #include <common/payload-view.h>
 #include <common/runas.h>
+#include <common/hashtable/hashtable.h>
+#include <common/hashtable/utils.h>
+#include <common/string-utils/string-utils.h>
 #include <lttng/event-rule/event-rule-internal.h>
 #include <lttng/event-rule/syscall-internal.h>
 
@@ -85,6 +88,7 @@ static int lttng_event_rule_syscall_serialize(
 
 	syscall_comm.pattern_len = pattern_len;
 	syscall_comm.filter_expression_len = filter_expression_len;
+	syscall_comm.emission_site_type = syscall->emission_site_type;
 
 	ret = lttng_dynamic_buffer_append(
 			&payload->buffer, &syscall_comm, sizeof(syscall_comm));
@@ -146,7 +150,7 @@ static enum lttng_error_code lttng_event_rule_syscall_generate_filter_bytecode(
 	struct lttng_event_rule_syscall *syscall;
 	enum lttng_event_rule_status status;
 	const char *filter;
-	struct lttng_filter_bytecode *bytecode = NULL;
+	struct lttng_bytecode *bytecode = NULL;
 
 	assert(rule);
 
@@ -203,7 +207,7 @@ static const char *lttng_event_rule_syscall_get_internal_filter(
 	return syscall->internal_filter.filter;
 }
 
-static const struct lttng_filter_bytecode *
+static const struct lttng_bytecode *
 lttng_event_rule_syscall_get_internal_filter_bytecode(
 		const struct lttng_event_rule *rule)
 {
@@ -215,18 +219,52 @@ lttng_event_rule_syscall_get_internal_filter_bytecode(
 	return syscall->internal_filter.bytecode;
 }
 
-static struct lttng_event_exclusion *
-lttng_event_rule_syscall_generate_exclusions(
+static enum lttng_event_rule_generate_exclusions_status
+lttng_event_rule_syscall_generate_exclusions(const struct lttng_event_rule *rule,
+		struct lttng_event_exclusion **exclusions)
+{
+	/* Unsupported. */
+	*exclusions = NULL;
+	return LTTNG_EVENT_RULE_GENERATE_EXCLUSIONS_STATUS_NONE;
+}
+
+static unsigned long
+lttng_event_rule_syscall_hash(
 		const struct lttng_event_rule *rule)
 {
-	/* Not supported. */
-	return NULL;
+	unsigned long hash;
+	struct lttng_event_rule_syscall *syscall_rule =
+			container_of(rule, typeof(*syscall_rule), parent);
+
+	hash = hash_key_ulong((void *) LTTNG_EVENT_RULE_TYPE_SYSCALL,
+			lttng_ht_seed);
+	hash ^= hash_key_str(syscall_rule->pattern, lttng_ht_seed);
+	if (syscall_rule->filter_expression) {
+		hash ^= hash_key_str(syscall_rule->filter_expression,
+				lttng_ht_seed);
+	}
+
+	return hash;
 }
 
-struct lttng_event_rule *lttng_event_rule_syscall_create()
+struct lttng_event_rule *lttng_event_rule_syscall_create(
+		enum lttng_event_rule_syscall_emission_site_type
+				emission_site_type)
 {
 	struct lttng_event_rule *rule = NULL;
 	struct lttng_event_rule_syscall *syscall_rule;
+	enum lttng_event_rule_status status;
+
+	/* Validate the emission site type */
+	switch (emission_site_type) {
+	case LTTNG_EVENT_RULE_SYSCALL_EMISSION_SITE_ENTRY_EXIT:
+	case LTTNG_EVENT_RULE_SYSCALL_EMISSION_SITE_ENTRY:
+	case LTTNG_EVENT_RULE_SYSCALL_EMISSION_SITE_EXIT:
+		break;
+	default:
+		/* Invalid emission type */
+		goto end;
+	}
 
 	syscall_rule = zmalloc(sizeof(struct lttng_event_rule_syscall));
 	if (!syscall_rule) {
@@ -248,6 +286,18 @@ struct lttng_event_rule *lttng_event_rule_syscall_create()
 			lttng_event_rule_syscall_get_internal_filter_bytecode;
 	syscall_rule->parent.generate_exclusions =
 			lttng_event_rule_syscall_generate_exclusions;
+	syscall_rule->parent.hash = lttng_event_rule_syscall_hash;
+
+	/* Default pattern is '*'. */
+	status = lttng_event_rule_syscall_set_name_pattern(rule, "*");
+	if (status != LTTNG_EVENT_RULE_STATUS_OK) {
+		lttng_event_rule_destroy(rule);
+		rule = NULL;
+	}
+
+	/* Emission site type */
+	syscall_rule->emission_site_type = emission_site_type;
+
 end:
 	return rule;
 }
@@ -284,7 +334,7 @@ ssize_t lttng_event_rule_syscall_create_from_payload(
 	}
 
 	syscall_comm = (typeof(syscall_comm)) current_buffer_view.data;
-	rule = lttng_event_rule_syscall_create();
+	rule = lttng_event_rule_syscall_create(syscall_comm->emission_site_type);
 	if (!rule) {
 		ERR("Failed to create event rule syscall");
 		ret = -1;
@@ -337,7 +387,7 @@ ssize_t lttng_event_rule_syscall_create_from_payload(
 
 skip_filter_expression:
 
-	status = lttng_event_rule_syscall_set_pattern(rule, pattern);
+	status = lttng_event_rule_syscall_set_name_pattern(rule, pattern);
 	if (status != LTTNG_EVENT_RULE_STATUS_OK) {
 		ERR("Failed to set event rule syscall pattern");
 		ret = -1;
@@ -362,7 +412,7 @@ end:
 	return ret;
 }
 
-enum lttng_event_rule_status lttng_event_rule_syscall_set_pattern(
+enum lttng_event_rule_status lttng_event_rule_syscall_set_name_pattern(
 		struct lttng_event_rule *rule, const char *pattern)
 {
 	char *pattern_copy = NULL;
@@ -382,9 +432,9 @@ enum lttng_event_rule_status lttng_event_rule_syscall_set_pattern(
 		goto end;
 	}
 
-	if (syscall->pattern) {
-		free(syscall->pattern);
-	}
+	strutils_normalize_star_glob_pattern(pattern_copy);
+
+	free(syscall->pattern);
 
 	syscall->pattern = pattern_copy;
 	pattern_copy = NULL;
@@ -392,7 +442,7 @@ end:
 	return status;
 }
 
-enum lttng_event_rule_status lttng_event_rule_syscall_get_pattern(
+enum lttng_event_rule_status lttng_event_rule_syscall_get_name_pattern(
 		const struct lttng_event_rule *rule, const char **pattern)
 {
 	struct lttng_event_rule_syscall *syscall;
@@ -467,3 +517,37 @@ enum lttng_event_rule_status lttng_event_rule_syscall_get_filter(
 end:
 	return status;
 }
+extern enum lttng_event_rule_syscall_emission_site_type
+lttng_event_rule_syscall_get_emission_site_type(
+		const struct lttng_event_rule *rule)
+{
+	enum lttng_event_rule_syscall_emission_site_type emission_site_type =
+		LTTNG_EVENT_RULE_SYSCALL_EMISSION_SITE_UNKNOWN;
+	struct lttng_event_rule_syscall *syscall;
+
+	if (!rule || !IS_SYSCALL_EVENT_RULE(rule)) {
+		goto end;
+	}
+
+	syscall = container_of(rule, struct lttng_event_rule_syscall, parent);
+	emission_site_type = syscall->emission_site_type;
+
+end:
+	return emission_site_type;
+}
+
+LTTNG_HIDDEN
+const char *lttng_event_rule_syscall_emission_site_str(
+		enum lttng_event_rule_syscall_emission_site_type type)
+{
+	switch (type) {
+	case LTTNG_EVENT_RULE_SYSCALL_EMISSION_SITE_ENTRY:
+		return "entry";
+	case LTTNG_EVENT_RULE_SYSCALL_EMISSION_SITE_ENTRY_EXIT:
+		return "entry+exit";
+	case LTTNG_EVENT_RULE_SYSCALL_EMISSION_SITE_EXIT:
+		return "exit";
+	default:
+		return "???";
+	}
+}