X-Git-Url: https://git.lttng.org/?a=blobdiff_plain;f=src%2Fcommon%2Factions%2Faction.c;h=f9236c87811e1d3241b22b6bfbe60117102a4bd8;hb=ad63a966ae7a204528fa77599f92100d7341be7a;hp=07eefeeb050ab14877abcf2d55ac4b93e78d91b1;hpb=2d57482cbac710612a36b7beae7b59c277006185;p=lttng-tools.git

diff --git a/src/common/actions/action.c b/src/common/actions/action.c
index 07eefeeb0..f9236c878 100644
--- a/src/common/actions/action.c
+++ b/src/common/actions/action.c
@@ -8,13 +8,14 @@
 #include <assert.h>
 #include <common/error.h>
 #include <lttng/action/action-internal.h>
-#include <lttng/action/firing-policy-internal.h>
-#include <lttng/action/group-internal.h>
+#include <lttng/action/list-internal.h>
 #include <lttng/action/notify-internal.h>
+#include <lttng/action/rate-policy-internal.h>
 #include <lttng/action/rotate-session-internal.h>
 #include <lttng/action/snapshot-session-internal.h>
 #include <lttng/action/start-session-internal.h>
 #include <lttng/action/stop-session-internal.h>
+#include <lttng/error-query-internal.h>
 
 LTTNG_HIDDEN
 const char *lttng_action_type_string(enum lttng_action_type action_type)
@@ -51,7 +52,8 @@ void lttng_action_init(struct lttng_action *action,
 		action_serialize_cb serialize,
 		action_equal_cb equal,
 		action_destroy_cb destroy,
-		action_get_firing_policy_cb get_firing_policy)
+		action_get_rate_policy_cb get_rate_policy,
+		action_add_error_query_results_cb add_error_query_results)
 {
 	urcu_ref_init(&action->ref);
 	action->type = type;
@@ -59,7 +61,8 @@ void lttng_action_init(struct lttng_action *action,
 	action->serialize = serialize;
 	action->equal = equal;
 	action->destroy = destroy;
-	action->get_firing_policy = get_firing_policy;
+	action->get_rate_policy = get_rate_policy;
+	action->add_error_query_results = add_error_query_results;
 
 	action->execution_request_counter = 0;
 	action->execution_counter = 0;
@@ -189,7 +192,7 @@ ssize_t lttng_action_create_from_payload(struct lttng_payload_view *view,
 				lttng_action_stop_session_create_from_payload;
 		break;
 	case LTTNG_ACTION_TYPE_GROUP:
-		create_from_payload_cb = lttng_action_group_create_from_payload;
+		create_from_payload_cb = lttng_action_list_create_from_payload;
 		break;
 	default:
 		ERR("Failed to create action from payload, unhandled action type: action-type=%u (%s)",
@@ -265,28 +268,69 @@ void lttng_action_increase_execution_count(struct lttng_action *action)
 LTTNG_HIDDEN
 void lttng_action_increase_execution_failure_count(struct lttng_action *action)
 {
-	action->execution_failure_counter++;
+	uatomic_inc(&action->execution_failure_counter);
 }
 
 LTTNG_HIDDEN
 bool lttng_action_should_execute(const struct lttng_action *action)
 {
-	const struct lttng_firing_policy *policy = NULL;
+	const struct lttng_rate_policy *policy = NULL;
 	bool execute = false;
 
-	if (action->get_firing_policy == NULL) {
+	if (action->get_rate_policy == NULL) {
 		execute = true;
 		goto end;
 	}
 
-	policy = action->get_firing_policy(action);
+	policy = action->get_rate_policy(action);
 	if (policy == NULL) {
 		execute = true;
 		goto end;
 	}
 
-	execute = lttng_firing_policy_should_execute(
+	execute = lttng_rate_policy_should_execute(
 			policy, action->execution_request_counter);
 end:
 	return execute;
 }
+
+LTTNG_HIDDEN
+enum lttng_action_status lttng_action_add_error_query_results(
+		const struct lttng_action *action,
+		struct lttng_error_query_results *results)
+{
+	return action->add_error_query_results(action, results);
+}
+
+LTTNG_HIDDEN
+enum lttng_action_status lttng_action_generic_add_error_query_results(
+		const struct lttng_action *action,
+		struct lttng_error_query_results *results)
+{
+	enum lttng_action_status action_status;
+	struct lttng_error_query_result *error_counter = NULL;
+	const uint64_t execution_failure_counter =
+			uatomic_read(&action->execution_failure_counter);
+
+	error_counter = lttng_error_query_result_counter_create(
+			"total execution failures",
+			"Aggregated count of errors encountered when executing the action",
+			execution_failure_counter);
+	if (!error_counter) {
+		action_status = LTTNG_ACTION_STATUS_ERROR;
+		goto end;
+	}
+
+	if (lttng_error_query_results_add_result(
+			    results, error_counter)) {
+		action_status = LTTNG_ACTION_STATUS_ERROR;
+		goto end;
+	}
+
+	/* Ownership transferred to the results. */
+	error_counter = NULL;
+	action_status = LTTNG_ACTION_STATUS_OK;
+end:
+	lttng_error_query_result_destroy(error_counter);
+	return action_status;
+}