X-Git-Url: https://git.lttng.org/?a=blobdiff_plain;f=src%2Fbin%2Flttng-sessiond%2Fust-app.c;h=9112cd14e39cf37cafb1d904d3bada5042cfe00b;hb=2b29c638278807c1536634ce49f0c9c053b3ab5f;hp=54479e23c03416b2a6d44b6bf7c780b949141d01;hpb=66ff8e3f938e33a59c55ecf8011422a4c0174ce7;p=lttng-tools.git

diff --git a/src/bin/lttng-sessiond/ust-app.c b/src/bin/lttng-sessiond/ust-app.c
index 54479e23c..9112cd14e 100644
--- a/src/bin/lttng-sessiond/ust-app.c
+++ b/src/bin/lttng-sessiond/ust-app.c
@@ -2845,6 +2845,8 @@ error:
 /*
  * Create and send to the application the created buffers with per UID buffers.
  *
+ * This MUST be called with a RCU read side lock acquired.
+ *
  * Return 0 on success else a negative value.
  */
 static int create_channel_per_uid(struct ust_app *app,
@@ -2923,7 +2925,6 @@ static int create_channel_per_uid(struct ust_app *app,
 		uint64_t chan_reg_key;
 		struct ust_registry_channel *chan_reg;
 
-		rcu_read_lock();
 		chan_reg_key = ua_chan->tracing_channel_id;
 
 		pthread_mutex_lock(&reg_uid->registry->reg.ust->lock);
@@ -2944,7 +2945,6 @@ static int create_channel_per_uid(struct ust_app *app,
 				ua_chan->key,
 				LTTNG_DOMAIN_UST,
 				ua_chan->attr.subbuf_size * ua_chan->attr.num_subbuf);
-		rcu_read_unlock();
 		if (cmd_ret != LTTNG_OK) {
 			ret = - (int) cmd_ret;
 			ERR("Failed to add channel to notification thread");
@@ -3577,8 +3577,8 @@ void ust_app_unregister(int sock)
 	/*
 	 * Remove application from notify hash table. The thread handling the
 	 * notify socket could have deleted the node so ignore on error because
-	 * either way it's valid. The close of that socket is handled by the other
-	 * thread.
+	 * either way it's valid. The close of that socket is handled by the
+	 * apps_notify_thread.
 	 */
 	iter.iter.node = &lta->notify_sock_n.node;
 	(void) lttng_ht_del(ust_app_ht_by_notify_sock, &iter);
@@ -4417,9 +4417,32 @@ int ust_app_start_trace(struct ltt_ust_session *usess, struct ust_app *app)
 
 	/* Create directories if consumer is LOCAL and has a path defined. */
 	if (usess->consumer->type == CONSUMER_DST_LOCAL &&
-			strlen(usess->consumer->dst.trace_path) > 0) {
-		ret = run_as_mkdir_recursive(usess->consumer->dst.trace_path,
-				S_IRWXU | S_IRWXG, ua_sess->euid, ua_sess->egid);
+			usess->consumer->dst.session_root_path[0] != '\0') {
+		char *tmp_path;
+
+		tmp_path = zmalloc(PATH_MAX * sizeof(char));
+		if (!tmp_path) {
+			ERR("Alloc tmp_path");
+			goto error_unlock;
+		}
+		ret = snprintf(tmp_path, PATH_MAX, "%s%s%s",
+				usess->consumer->dst.session_root_path,
+				usess->consumer->chunk_path,
+				usess->consumer->subdir);
+		if (ret >= PATH_MAX) {
+			ERR("Local destination path exceeds the maximal allowed length of %i bytes (needs %i bytes) with path = \"%s%s%s\"",
+					PATH_MAX, ret,
+					usess->consumer->dst.session_root_path,
+					usess->consumer->chunk_path,
+					usess->consumer->subdir);
+			goto error_unlock;
+		}
+
+		DBG("Creating directory path for local tracing: \"%s\"",
+				tmp_path);
+		ret = run_as_mkdir_recursive(tmp_path, S_IRWXU | S_IRWXG,
+				ua_sess->euid, ua_sess->egid);
+		free(tmp_path);
 		if (ret < 0) {
 			if (errno != EEXIST) {
 				ERR("Trace directory creation error");