X-Git-Url: https://git.lttng.org/?a=blobdiff_plain;f=src%2Fbin%2Flttng-sessiond%2Frotate.c;h=5e2eb5932a6a36e9f6781f0930d39cf88d91fb76;hb=69d5d2ae78d1835f4547a2946d226c2a7a2e513c;hp=e2a3ef9eaac221ef97cc611004db602d7af347f0;hpb=683c4b91592e8986ffad62f89f08c736497aabb3;p=lttng-tools.git

diff --git a/src/bin/lttng-sessiond/rotate.c b/src/bin/lttng-sessiond/rotate.c
index e2a3ef9ea..5e2eb5932 100644
--- a/src/bin/lttng-sessiond/rotate.c
+++ b/src/bin/lttng-sessiond/rotate.c
@@ -25,6 +25,8 @@
 
 #include <lttng/notification/channel-internal.h>
 #include <lttng/rotate-internal.h>
+#include <lttng/condition/condition-internal.h>
+#include <lttng/action/action-internal.h>
 
 #include "session.h"
 #include "rotate.h"
@@ -45,17 +47,22 @@ int subscribe_session_consumed_size_rotation(struct ltt_session *session, uint64
 	int ret;
 	enum lttng_condition_status condition_status;
 	enum lttng_notification_channel_status nc_status;
-	struct lttng_action *action;
-
-	session->rotate_condition = lttng_condition_session_consumed_size_create();
-	if (!session->rotate_condition) {
+	struct lttng_condition *rotate_condition = NULL;
+	struct lttng_action *notify_action = NULL;
+	const struct lttng_credentials session_creds = {
+		.uid = LTTNG_OPTIONAL_INIT_VALUE(session->uid),
+		.gid = LTTNG_OPTIONAL_INIT_VALUE(session->gid),
+	};
+
+	rotate_condition = lttng_condition_session_consumed_size_create();
+	if (!rotate_condition) {
 		ERR("Failed to create session consumed size condition object");
 		ret = -1;
 		goto end;
 	}
 
 	condition_status = lttng_condition_session_consumed_size_set_threshold(
-			session->rotate_condition, size);
+			rotate_condition, size);
 	if (condition_status != LTTNG_CONDITION_STATUS_OK) {
 		ERR("Could not set session consumed size condition threshold (size = %" PRIu64 ")",
 				size);
@@ -65,7 +72,7 @@ int subscribe_session_consumed_size_rotation(struct ltt_session *session, uint64
 
 	condition_status =
 			lttng_condition_session_consumed_size_set_session_name(
-				session->rotate_condition, session->name);
+				rotate_condition, session->name);
 	if (condition_status != LTTNG_CONDITION_STATUS_OK) {
 		ERR("Could not set session consumed size condition session name (name = %s)",
 				session->name);
@@ -73,15 +80,16 @@ int subscribe_session_consumed_size_rotation(struct ltt_session *session, uint64
 		goto end;
 	}
 
-	action = lttng_action_notify_create();
-	if (!action) {
+	notify_action = lttng_action_notify_create();
+	if (!notify_action) {
 		ERR("Could not create notify action");
 		ret = -1;
 		goto end;
 	}
 
-	session->rotate_trigger = lttng_trigger_create(session->rotate_condition,
-			action);
+	assert(!session->rotate_trigger);
+	session->rotate_trigger = lttng_trigger_create(rotate_condition,
+			notify_action);
 	if (!session->rotate_trigger) {
 		ERR("Could not create size-based rotation trigger");
 		ret = -1;
@@ -89,7 +97,7 @@ int subscribe_session_consumed_size_rotation(struct ltt_session *session, uint64
 	}
 
 	nc_status = lttng_notification_channel_subscribe(
-			rotate_notification_channel, session->rotate_condition);
+			rotate_notification_channel, rotate_condition);
 	if (nc_status != LTTNG_NOTIFICATION_CHANNEL_STATUS_OK) {
 		ERR("Could not subscribe to session consumed size notification");
 		ret = -1;
@@ -107,6 +115,11 @@ int subscribe_session_consumed_size_rotation(struct ltt_session *session, uint64
 	ret = 0;
 
 end:
+	lttng_condition_put(rotate_condition);
+	lttng_action_put(notify_action);
+	if (ret) {
+		lttng_trigger_put(session->rotate_trigger);
+	}
 	return ret;
 }
 
@@ -116,9 +129,10 @@ int unsubscribe_session_consumed_size_rotation(struct ltt_session *session,
 	int ret = 0;
 	enum lttng_notification_channel_status status;
 
+	assert(session->rotate_trigger);
 	status = lttng_notification_channel_unsubscribe(
 			rotate_notification_channel,
-			session->rotate_condition);
+			lttng_trigger_get_const_condition(session->rotate_trigger));
 	if (status != LTTNG_NOTIFICATION_CHANNEL_STATUS_OK) {
 		ERR("Session unsubscribe error: %d", (int) status);
 		ret = -1;
@@ -132,6 +146,9 @@ int unsubscribe_session_consumed_size_rotation(struct ltt_session *session,
 		goto end;
 	}
 
+	lttng_trigger_put(session->rotate_trigger);
+	session->rotate_trigger = NULL;
+
 	ret = 0;
 end:
 	return ret;