X-Git-Url: https://git.lttng.org/?a=blobdiff_plain;f=src%2Fbin%2Flttng-sessiond%2Fnotification-thread-events.c;h=0836620b59262413c43b8cb97addb8e0f468746b;hb=c0e2990d32d1e55c783c7eb3299f23a7ce062270;hp=d3b6cd855da47b872ae11e7fa3cbc4446e8de6a3;hpb=a3ed2a4e441779205ea3b0d97a3a7f223237214b;p=lttng-tools.git

diff --git a/src/bin/lttng-sessiond/notification-thread-events.c b/src/bin/lttng-sessiond/notification-thread-events.c
index d3b6cd855..0836620b5 100644
--- a/src/bin/lttng-sessiond/notification-thread-events.c
+++ b/src/bin/lttng-sessiond/notification-thread-events.c
@@ -1139,9 +1139,10 @@ int notification_thread_client_subscribe(struct notification_client *client,
 	 * at this point so that conditions that are already TRUE result
 	 * in a notification being sent out.
 	 *
-	 * The client_list's trigger is used without locking the list itself.
-	 * This is correct since the list doesn't own the trigger and the
-	 * object is immutable.
+	 * Note the iteration on all triggers which share an identical
+	 * `condition` than the one to which the client is registering. This is
+	 * done to ensure that the client receives a distinct notification for
+	 * all triggers that have a `notify` action that have this condition.
 	 */
 	pthread_mutex_lock(&client_list->lock);
 	cds_list_for_each_entry(trigger_ht_element,
@@ -1151,6 +1152,7 @@ int notification_thread_client_subscribe(struct notification_client *client,
 			WARN("[notification-thread] Evaluation of a condition on client subscription failed, aborting.");
 			ret = -1;
 			free(client_list_element);
+			pthread_mutex_unlock(&client_list->lock);
 			goto end;
 		}
 	}