X-Git-Url: https://git.lttng.org/?a=blobdiff_plain;f=src%2Fbin%2Flttng-sessiond%2Fcmd.c;h=58506b2b225e5e0e306d9fad8682013e52a0723d;hb=ce34fcd0419afa029cec4a093a96d81e3c338eea;hp=33ab492daf330eacacc239646b866b612d5975e8;hpb=b11feea58d73a097e4e1447473798822da28a70d;p=lttng-tools.git

diff --git a/src/bin/lttng-sessiond/cmd.c b/src/bin/lttng-sessiond/cmd.c
index 33ab492da..58506b2b2 100644
--- a/src/bin/lttng-sessiond/cmd.c
+++ b/src/bin/lttng-sessiond/cmd.c
@@ -18,6 +18,7 @@
 #define _GNU_SOURCE
 #define _LGPL_SOURCE
 #include <assert.h>
+#include <string.h>
 #include <inttypes.h>
 #include <urcu/list.h>
 #include <urcu/uatomic.h>
@@ -939,11 +940,21 @@ int cmd_enable_channel(struct ltt_session *session,
 	int ret;
 	struct ltt_ust_session *usess = session->ust_session;
 	struct lttng_ht *chan_ht;
+	size_t len;
 
 	assert(session);
 	assert(attr);
 	assert(domain);
 
+	len = strnlen(attr->name, sizeof(attr->name));
+
+	/* Validate channel name */
+	if (attr->name[0] == '.' ||
+		memchr(attr->name, '/', len) != NULL) {
+		ret = LTTNG_ERR_INVALID_CHANNEL_NAME;
+		goto end;
+	}
+
 	DBG("Enabling channel %s for session %s", attr->name, session->name);
 
 	rcu_read_lock();
@@ -1024,6 +1035,7 @@ int cmd_enable_channel(struct ltt_session *session,
 
 error:
 	rcu_read_unlock();
+end:
 	return ret;
 }
 
@@ -1042,7 +1054,8 @@ int cmd_disable_event(struct ltt_session *session, int domain,
 
 	event_name = event->name;
 
-	if (event->loglevel_type || event->loglevel || event->enabled
+	/* Error out on unhandled search criteria */
+	if (event->loglevel_type || event->loglevel != -1 || event->enabled
 			|| event->pid || event->filter || event->exclusion) {
 		return LTTNG_ERR_UNK;
 	}
@@ -2006,13 +2019,12 @@ error:
 /*
  * Command LTTNG_SET_CONSUMER_URI processed by the client thread.
  */
-int cmd_set_consumer_uri(int domain, struct ltt_session *session,
-		size_t nb_uri, struct lttng_uri *uris)
+int cmd_set_consumer_uri(struct ltt_session *session, size_t nb_uri,
+		struct lttng_uri *uris)
 {
 	int ret, i;
 	struct ltt_kernel_session *ksess = session->kernel_session;
 	struct ltt_ust_session *usess = session->ust_session;
-	struct consumer_output *consumer = NULL;
 
 	assert(session);
 	assert(uris);
@@ -2024,41 +2036,41 @@ int cmd_set_consumer_uri(int domain, struct ltt_session *session,
 		goto error;
 	}
 
-	/*
-	 * This case switch makes sure the domain session has a temporary consumer
-	 * so the URL can be set.
-	 */
-	switch (domain) {
-	case 0:
-		/* Code flow error. A session MUST always have a consumer object */
-		assert(session->consumer);
-		/*
-		 * The URL will be added to the tracing session consumer instead of a
-		 * specific domain consumer.
-		 */
-		consumer = session->consumer;
-		break;
-	case LTTNG_DOMAIN_KERNEL:
-		/* Code flow error if we don't have a kernel session here. */
-		assert(ksess);
-		assert(ksess->consumer);
-		consumer = ksess->consumer;
-		break;
-	case LTTNG_DOMAIN_UST:
-		/* Code flow error if we don't have a kernel session here. */
-		assert(usess);
-		assert(usess->consumer);
-		consumer = usess->consumer;
-		break;
-	}
-
+	/* Set the "global" consumer URIs */
 	for (i = 0; i < nb_uri; i++) {
-		ret = add_uri_to_consumer(consumer, &uris[i], domain, session->name);
+		ret = add_uri_to_consumer(session->consumer,
+				&uris[i], 0, session->name);
 		if (ret != LTTNG_OK) {
 			goto error;
 		}
 	}
 
+	/* Set UST session URIs */
+	if (session->ust_session) {
+		for (i = 0; i < nb_uri; i++) {
+			ret = add_uri_to_consumer(
+					session->ust_session->consumer,
+					&uris[i], LTTNG_DOMAIN_UST,
+					session->name);
+			if (ret != LTTNG_OK) {
+				goto error;
+			}
+		}
+	}
+
+	/* Set kernel session URIs */
+	if (session->kernel_session) {
+		for (i = 0; i < nb_uri; i++) {
+			ret = add_uri_to_consumer(
+					session->kernel_session->consumer,
+					&uris[i], LTTNG_DOMAIN_KERNEL,
+					session->name);
+			if (ret != LTTNG_OK) {
+				goto error;
+			}
+		}
+	}
+
 	/*
 	 * Make sure to set the session in output mode after we set URI since a
 	 * session can be created without URL (thus flagged in no output mode).
@@ -2066,7 +2078,9 @@ int cmd_set_consumer_uri(int domain, struct ltt_session *session,
 	session->output_traces = 1;
 	if (ksess) {
 		ksess->output_traces = 1;
-	} else if (usess) {
+	}
+
+	if (usess) {
 		usess->output_traces = 1;
 	}
 
@@ -2128,7 +2142,7 @@ int cmd_create_session_uri(char *name, struct lttng_uri *uris,
 	}
 
 	if (uris) {
-		ret = cmd_set_consumer_uri(0, session, nb_uri, uris);
+		ret = cmd_set_consumer_uri(session, nb_uri, uris);
 		if (ret != LTTNG_OK) {
 			goto consumer_error;
 		}
@@ -2965,11 +2979,13 @@ static int record_kernel_snapshot(struct ltt_kernel_session *ksess,
 	}
 
 	ret = LTTNG_OK;
+	goto end;
 
 error_snapshot:
 	/* Clean up copied sockets so this output can use some other later on. */
 	consumer_destroy_output_sockets(output->consumer);
 error:
+end:
 	return ret;
 }