X-Git-Url: https://git.lttng.org/?a=blobdiff_plain;f=src%2Fbin%2Flttng%2Fcommands%2Fview.c;h=9283c242f8e6a380393a215e8b031d9f1f975bb5;hb=b7f4ea0f4c6ac71da5e4e6fe988df4d35734332a;hp=a2623fe49e0ccb66b4baecbf1f27552d22ffad43;hpb=32aef76c03b38dfb5f423299357c478147358af4;p=lttng-tools.git

diff --git a/src/bin/lttng/commands/view.c b/src/bin/lttng/commands/view.c
index a2623fe49..9283c242f 100644
--- a/src/bin/lttng/commands/view.c
+++ b/src/bin/lttng/commands/view.c
@@ -17,7 +17,6 @@
 #include <common/spawn-viewer.h>
 #include "../command.h"
 
-static char *opt_session_name;
 static char *opt_viewer;
 static char *opt_trace_path;
 
@@ -73,7 +72,7 @@ error:
 /*
  * Exec viewer if found and use session name path.
  */
-static int view_trace(void)
+static int view_trace(const char *arg_session_name)
 {
 	int ret;
 	char *session_name, *trace_path = NULL;
@@ -99,14 +98,20 @@ static int view_trace(void)
 	/* User define trace path override the session name */
 	if (opt_trace_path) {
 		session_name = NULL;
-	} else if(opt_session_name == NULL) {
-		session_name = get_session_name();
+	} else {
+		if (arg_session_name == NULL) {
+			session_name = get_session_name();
+		} else {
+			session_name = strdup(arg_session_name);
+			if (session_name == NULL) {
+				PERROR("Failed to copy session name");
+			}
+		}
+
 		if (session_name == NULL) {
 			ret = CMD_ERROR;
 			goto error;
 		}
-	} else {
-		session_name = opt_session_name;
 	}
 
 	DBG("Viewing trace for session %s", session_name);
@@ -179,9 +184,7 @@ free_sessions:
 	}
 	free(sessions);
 free_error:
-	if (opt_session_name == NULL) {
-		free(session_name);
-	}
+	free(session_name);
 error:
 	return ret;
 }
@@ -193,6 +196,7 @@ int cmd_view(int argc, const char **argv)
 {
 	int opt, ret = CMD_SUCCESS;
 	static poptContext pc;
+	const char *arg_session_name = NULL;
 	const char *leftover = NULL;
 
 	pc = poptGetContext(NULL, argc, argv, long_options, 0);
@@ -216,7 +220,7 @@ int cmd_view(int argc, const char **argv)
 		}
 	}
 
-	opt_session_name = (char*) poptGetArg(pc);
+	arg_session_name = poptGetArg(pc);
 
 	leftover = poptGetArg(pc);
 	if (leftover) {
@@ -225,7 +229,7 @@ int cmd_view(int argc, const char **argv)
 		goto end;
 	}
 
-	ret = view_trace();
+	ret = view_trace(arg_session_name);
 
 end:
 	poptFreeContext(pc);