X-Git-Url: https://git.lttng.org/?a=blobdiff_plain;ds=sidebyside;f=src%2Fbin%2Flttng-sessiond%2Fcmd.c;h=56c7633a07fc55b7a648a27e199c7a138d6043b1;hb=d2678a0d274cb95b653a3f119979c98ecd35acc6;hp=ad635a9a96b631880171e012aeb462311424bade;hpb=a5df8828164272c26e88028b00e6e1ec88ee222d;p=lttng-tools.git

diff --git a/src/bin/lttng-sessiond/cmd.c b/src/bin/lttng-sessiond/cmd.c
index ad635a9a9..56c7633a0 100644
--- a/src/bin/lttng-sessiond/cmd.c
+++ b/src/bin/lttng-sessiond/cmd.c
@@ -47,7 +47,7 @@
 #include "kernel-consumer.h"
 #include "lttng-sessiond.h"
 #include "utils.h"
-#include "syscall.h"
+#include "lttng-syscall.h"
 #include "agent.h"
 #include "buffer-registry.h"
 #include "notification-thread.h"
@@ -55,6 +55,7 @@
 #include "rotate.h"
 #include "rotation-thread.h"
 #include "sessiond-timer.h"
+#include "agent-thread.h"
 
 #include "cmd.h"
 
@@ -1384,9 +1385,15 @@ int cmd_enable_channel(struct ltt_session *session,
 		break;
 	}
 	case LTTNG_DOMAIN_UST:
+		break;
 	case LTTNG_DOMAIN_JUL:
 	case LTTNG_DOMAIN_LOG4J:
 	case LTTNG_DOMAIN_PYTHON:
+		if (!agent_tracing_is_enabled()) {
+			DBG("Attempted to enable a channel in an agent domain but the agent thread is not running");
+			ret = LTTNG_ERR_AGENT_TRACING_DISABLED;
+			goto error;
+		}
 		break;
 	default:
 		ret = LTTNG_ERR_UNKNOWN_DOMAIN;
@@ -2094,6 +2101,12 @@ static int _cmd_enable_event(struct ltt_session *session,
 
 		assert(usess);
 
+		if (!agent_tracing_is_enabled()) {
+			DBG("Attempted to enable an event in an agent domain but the agent thread is not running");
+			ret = LTTNG_ERR_AGENT_TRACING_DISABLED;
+			goto error;
+		}
+
 		agt = trace_ust_find_agent(usess, domain->type);
 		if (!agt) {
 			agt = agent_create(domain->type);
@@ -2600,7 +2613,7 @@ int rename_active_chunk(struct ltt_session *session)
 {
 	int ret;
 
-	session->rotate_count++;
+	session->current_archive_id++;
 
 	/*
 	 * The currently active tracing path is now the folder we
@@ -2633,7 +2646,7 @@ int rename_active_chunk(struct ltt_session *session)
 		goto end;
 	}
 end:
-	session->rotate_count--;
+	session->current_archive_id--;
 	return ret;
 }
 
@@ -2669,7 +2682,7 @@ int cmd_stop_trace(struct ltt_session *session)
 		sessiond_rotate_timer_stop(session);
 	}
 
-	if (session->rotate_count > 0 && !session->rotate_pending) {
+	if (session->current_archive_id > 0 && !session->rotate_pending) {
 		ret = rename_active_chunk(session);
 		if (ret) {
 			/*
@@ -4430,7 +4443,7 @@ int cmd_rotate_session(struct ltt_session *session,
 	}
 
 	/* Special case for the first rotation. */
-	if (session->rotate_count == 0) {
+	if (session->current_archive_id == 0) {
 		const char *base_path = NULL;
 
 		/* Either one of the two sessions is enough to get the root path. */
@@ -4466,7 +4479,7 @@ int cmd_rotate_session(struct ltt_session *session,
 	}
 	DBG("Current rotate path %s", session->rotation_chunk.current_rotate_path);
 
-	session->rotate_count++;
+	session->current_archive_id++;
 	session->rotate_pending = true;
 	session->rotation_state = LTTNG_ROTATION_STATE_ONGOING;
 
@@ -4503,7 +4516,7 @@ int cmd_rotate_session(struct ltt_session *session,
 				sizeof(session->rotation_chunk.active_tracing_path),
 				"%s/%s-%" PRIu64,
 				session_get_base_path(session),
-				datetime, session->rotate_count + 1);
+				datetime, session->current_archive_id + 1);
 		if (ret < 0 || ret == sizeof(session->rotation_chunk.active_tracing_path)) {
 			ERR("Failed to format active kernel tracing path in rotate session command");
 			ret = -LTTNG_ERR_UNK;
@@ -4516,7 +4529,7 @@ int cmd_rotate_session(struct ltt_session *session,
 		ret = snprintf(session->kernel_session->consumer->chunk_path,
 				sizeof(session->kernel_session->consumer->chunk_path),
 				"/%s-%" PRIu64, datetime,
-				session->rotate_count + 1);
+				session->current_archive_id + 1);
 		if (ret < 0 || ret == sizeof(session->kernel_session->consumer->chunk_path)) {
 			ERR("Failed to format the kernel consumer's sub-directory in rotate session command");
 			ret = -LTTNG_ERR_UNK;
@@ -4545,7 +4558,7 @@ int cmd_rotate_session(struct ltt_session *session,
 		ret = snprintf(session->rotation_chunk.active_tracing_path,
 				PATH_MAX, "%s/%s-%" PRIu64,
 				session_get_base_path(session),
-				datetime, session->rotate_count + 1);
+				datetime, session->current_archive_id + 1);
 		if (ret < 0) {
 			ERR("Failed to format active UST tracing path in rotate session command");
 			ret = -LTTNG_ERR_UNK;
@@ -4553,7 +4566,7 @@ int cmd_rotate_session(struct ltt_session *session,
 		}
 		ret = snprintf(session->ust_session->consumer->chunk_path,
 				PATH_MAX, "/%s-%" PRIu64, datetime,
-				session->rotate_count + 1);
+				session->current_archive_id + 1);
 		if (ret < 0) {
 			ERR("Failed to format the UST consumer's sub-directory in rotate session command");
 			ret = -LTTNG_ERR_UNK;
@@ -4596,11 +4609,11 @@ int cmd_rotate_session(struct ltt_session *session,
 	}
 
 	if (rotate_return) {
-		rotate_return->rotation_id = session->rotate_count;
+		rotate_return->rotation_id = session->current_archive_id;
 	}
 
-	DBG("Cmd rotate session %s, rotate_id %" PRIu64 " sent", session->name,
-			session->rotate_count);
+	DBG("Cmd rotate session %s, current_archive_id %" PRIu64 " sent",
+			session->name, session->current_archive_id);
 	ret = LTTNG_OK;
 
 end:
@@ -4623,9 +4636,9 @@ int cmd_rotate_get_info(struct ltt_session *session,
 	assert(session);
 
 	DBG("Cmd rotate_get_info session %s, rotation id %" PRIu64, session->name,
-			session->rotate_count);
+			session->current_archive_id);
 
-	if (session->rotate_count != rotation_id) {
+	if (session->current_archive_id != rotation_id) {
 		info_return->status = (int32_t) LTTNG_ROTATION_STATE_EXPIRED;
 		ret = LTTNG_OK;
 		goto end;
@@ -4648,7 +4661,7 @@ int cmd_rotate_get_info(struct ltt_session *session,
 			current_tracing_path_reply_len =
 					sizeof(info_return->location.local.absolute_path);
 			info_return->location_type =
-					(uint8_t) LTTNG_TRACE_ARCHIVE_LOCATION_TYPE_LOCAL;
+					(int8_t) LTTNG_TRACE_ARCHIVE_LOCATION_TYPE_LOCAL;
 			break;
 		case CONSUMER_DST_NET:
 			current_tracing_path_reply =
@@ -4657,7 +4670,7 @@ int cmd_rotate_get_info(struct ltt_session *session,
 					sizeof(info_return->location.relay.relative_path);
 			/* Currently the only supported relay protocol. */
 			info_return->location.relay.protocol =
-					(uint8_t) LTTNG_TRACE_ARCHIVE_LOCATION_RELAY_PROTOCOL_TYPE_TCP;
+					(int8_t) LTTNG_TRACE_ARCHIVE_LOCATION_RELAY_PROTOCOL_TYPE_TCP;
 
 			ret = lttng_strncpy(info_return->location.relay.host,
 					session_get_net_consumer_hostname(session),
@@ -4673,7 +4686,7 @@ int cmd_rotate_get_info(struct ltt_session *session,
 					&info_return->location.relay.ports.control,
 					&info_return->location.relay.ports.data);
 			info_return->location_type =
-					(uint8_t) LTTNG_TRACE_ARCHIVE_LOCATION_TYPE_RELAY;
+					(int8_t) LTTNG_TRACE_ARCHIVE_LOCATION_TYPE_RELAY;
 			break;
 		default:
 			abort();
@@ -4814,7 +4827,7 @@ int cmd_session_get_current_output(struct ltt_session *session,
 	const char *path;
 
 	if (!session->snapshot_mode) {
-		if (session->rotate_count == 0) {
+		if (session->current_archive_id == 0) {
 			if (session->kernel_session) {
 				path = session_get_base_path(session);
 			} else if (session->ust_session) {