From: Mathieu Desnoyers Date: Mon, 17 May 2021 12:40:17 +0000 (-0400) Subject: Fix: handle leak in abi tests X-Git-Url: http://git.lttng.org/?a=commitdiff_plain;h=dbbb73968ec9af48c2b0b9ea65a4b03843109f7d;hp=dbbb73968ec9af48c2b0b9ea65a4b03843109f7d;p=lttng-ust.git Fix: handle leak in abi tests Coverity finds that dlopen_ust leaks handles. Modify the code structure to keep track of those handles in library descriptors so they are not leaked. *** CID 1453155: (RESOURCE_LEAK) /tests/regression/abi0-conflict/app_ust_dlopen.c: 35 in dlopen_ust() 29 printf("Error: dlopen of liblttng-ust shared library (%s).\n", lib_soname); 30 ret = EXIT_FAILURE; 31 } else { 32 printf("Success: dlopen of liblttng-ust shared library (%s).\n", lib_soname); 33 } 34 >>> CID 1453155: (RESOURCE_LEAK) >>> Variable "handle" going out of scope leaks the storage it points to. 35 return ret; 36 } 37 38 static 39 int dlopen_abi0(void) 40 { /tests/regression/abi0-conflict/app_noust_dlopen.c: 31 in dlopen_ust() 25 printf("Error: dlopen of liblttng-ust shared library (%s).\n", lib_soname); 26 ret = EXIT_FAILURE; 27 } else { 28 printf("Success: dlopen of liblttng-ust shared library (%s).\n", lib_soname); 29 } 30 >>> CID 1453155: (RESOURCE_LEAK) >>> Variable "handle" going out of scope leaks the storage it points to. 31 return ret; 32 } 33 34 static 35 int dlopen_abi0(void) 36 { Signed-off-by: Mathieu Desnoyers Change-Id: I967c2e8741c6d42c0c12e19fbadc81e1c91d1e0f ---