summary |
shortlog |
log |
commit | commitdiff |
tree
raw |
patch |
inline | side by side (from parent 1:
dd1cd40)
The test_create_ust_channel() test case erroneously checks for
a NULL session instead of a channel. This can result in a
NULL pointer dereference on failure to create a ust channel.
The scope of usess is reduced to prevent similar mistakes in the
future. Moving 'dom' has made it obvious that this variable is
unused. Hence, it is removed.
Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com>
"abcdefghijklmnopqrstuvwxyz";
static char random_string[RANDOM_STRING_LEN];
"abcdefghijklmnopqrstuvwxyz";
static char random_string[RANDOM_STRING_LEN];
-static struct ltt_ust_session *usess;
-static struct lttng_domain dom;
-
/*
* Return random string of 10 characters.
* Not thread-safe.
/*
* Return random string of 10 characters.
* Not thread-safe.
static void test_create_one_ust_session(void)
{
static void test_create_one_ust_session(void)
{
- dom.type = LTTNG_DOMAIN_UST;
+ struct ltt_ust_session *usess =
+ trace_ust_create_session(42);
- usess = trace_ust_create_session(42);
ok(usess != NULL, "Create UST session");
if (!usess) {
ok(usess != NULL, "Create UST session");
if (!usess) {
uchan = trace_ust_create_channel(&attr, LTTNG_DOMAIN_UST);
ok(uchan != NULL, "Create UST channel");
uchan = trace_ust_create_channel(&attr, LTTNG_DOMAIN_UST);
ok(uchan != NULL, "Create UST channel");
- if (!usess) {
- skip(1, "UST session is null");
+ if (!uchan) {
+ skip(1, "UST channel is null");