X-Git-Url: http://git.lttng.org/?a=blobdiff_plain;f=src%2Flttng-event-notifier-notification.c;h=52b5593ac9325b5324c9169f72ff736044a49cac;hb=7b25fa17c155f7088af45e843a711250ab0e7cb7;hp=b67af11a77ecf0763801030346d6ceefc5f7ace1;hpb=e699ee6c837345eb408d600178cc6054ca131164;p=lttng-modules.git

diff --git a/src/lttng-event-notifier-notification.c b/src/lttng-event-notifier-notification.c
index b67af11a..52b5593a 100644
--- a/src/lttng-event-notifier-notification.c
+++ b/src/lttng-event-notifier-notification.c
@@ -11,6 +11,7 @@
 #include <lttng/events.h>
 #include <lttng/msgpack.h>
 #include <lttng/event-notifier-notification.h>
+#include <wrapper/barrier.h>
 
 /*
  * The capture buffer size needs to be below 1024 bytes to avoid the
@@ -347,6 +348,33 @@ end:
 	return ret;
 }
 
+static
+void record_error(struct lttng_event_notifier *event_notifier)
+{
+
+	struct lttng_event_notifier_group *event_notifier_group = event_notifier->group;
+	struct lttng_counter *error_counter;
+	size_t dimension_index[1];
+	int ret;
+
+	/*
+	 * lttng_smp_load_acquire paired with lttng_smp_store_release orders
+	 * creation of the error counter and setting error_counter_len
+	 * before the error_counter is used.
+	 */
+	error_counter = lttng_smp_load_acquire(&event_notifier_group->error_counter);
+	/* This group may not have an error counter attached to it. */
+	if (!error_counter)
+		return;
+
+	dimension_index[0] = event_notifier->error_counter_index;
+
+	ret = error_counter->ops->counter_add(error_counter->counter,
+			dimension_index, 1);
+	if (ret)
+		WARN_ON_ONCE(1);
+}
+
 static
 void notification_send(struct lttng_event_notifier_notification *notif,
 		struct lttng_event_notifier *event_notifier)
@@ -375,9 +403,7 @@ void notification_send(struct lttng_event_notifier_notification *notif,
 			lttng_alignof(kernel_notif), -1);
 	ret = event_notifier_group->ops->event_reserve(&ctx, 0);
 	if (ret < 0) {
-		//TODO: error handling with counter maps
-		//silently drop for now.
-		WARN_ON_ONCE(1);
+		record_error(event_notifier);
 		return;
 	}