X-Git-Url: http://git.lttng.org/?a=blobdiff_plain;f=probes%2Flttng-kretprobes.c;h=498df620fa3a29d29147f1a5dc386695c3620f9c;hb=a9799a5121562e2e5fa8f31b01151f195efc92fc;hp=eb3f68573dc895554af4484d0a8aad03ddcf284a;hpb=79150a4903b5f31695fcd1d9655555ba6dc4bfa4;p=lttng-modules.git

diff --git a/probes/lttng-kretprobes.c b/probes/lttng-kretprobes.c
index eb3f6857..498df620 100644
--- a/probes/lttng-kretprobes.c
+++ b/probes/lttng-kretprobes.c
@@ -1,5 +1,5 @@
 /*
- * probes/lttng-kretprobes.c
+* probes/lttng-kretprobes.c
  *
  * LTTng kretprobes integration module.
  *
@@ -24,11 +24,11 @@
 #include <linux/kprobes.h>
 #include <linux/slab.h>
 #include <linux/kref.h>
-#include "../lttng-events.h"
-#include "../wrapper/ringbuffer/frontend_types.h"
-#include "../wrapper/vmalloc.h"
-#include "../wrapper/irqflags.h"
-#include "../lttng-tracer.h"
+#include <lttng-events.h>
+#include <wrapper/ringbuffer/frontend_types.h>
+#include <wrapper/vmalloc.h>
+#include <wrapper/irqflags.h>
+#include <lttng-tracer.h>
 
 enum lttng_kretprobe_type {
 	EVENT_ENTRY = 0,
@@ -53,7 +53,7 @@ int _lttng_kretprobes_handler(struct kretprobe_instance *krpi,
 		lttng_krp->event[type];
 	struct lttng_probe_ctx lttng_probe_ctx = {
 		.event = event,
-		.interruptible = lttng_regs_irqs_disabled(regs),
+		.interruptible = !lttng_regs_irqs_disabled(regs),
 	};
 	struct lttng_channel *chan = event->chan;
 	struct lib_ring_buffer_ctx ctx;
@@ -224,9 +224,9 @@ int lttng_kretprobes_register(const char *name,
 	 * unregistered. Same for memory allocation.
 	 */
 	kref_init(&lttng_krp->kref_alloc);
-	kref_get(&lttng_krp->kref_alloc);	/* inc refcount to 2 */
+	kref_get(&lttng_krp->kref_alloc);	/* inc refcount to 2, no overflow. */
 	kref_init(&lttng_krp->kref_register);
-	kref_get(&lttng_krp->kref_register);	/* inc refcount to 2 */
+	kref_get(&lttng_krp->kref_register);	/* inc refcount to 2, no overflow. */
 
 	/*
 	 * Ensure the memory we just allocated don't trigger page faults.