X-Git-Url: http://git.lttng.org/?a=blobdiff_plain;f=include%2Fusterr.h;h=dc51d840b42879d6e8f11e1f7567a9f05dc2edad;hb=30ffe2794fc413035208cdd2a7a061bc208e210f;hp=b97ad6ba3559621d3cd9b4162bbae298926b4c26;hpb=8b6984b8b5c6fb912c2cf3495d322f01a5bbc8eb;p=ust.git diff --git a/include/usterr.h b/include/usterr.h index b97ad6b..dc51d84 100644 --- a/include/usterr.h +++ b/include/usterr.h @@ -15,8 +15,8 @@ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA */ -#ifndef USTERR_H -#define USTERR_H +#ifndef _USTERR_H +#define _USTERR_H #include #include @@ -30,7 +30,6 @@ #include "share.h" #ifndef UST_COMPONENT -//#error UST_COMPONENT is undefined #define UST_COMPONENT libust #endif @@ -38,46 +37,19 @@ #define XSTR(d) STR(d) #define STR(s) #s -/* We sometimes print in the tracing path, and tracing can occur in - * signal handlers, so we must use a print method which is signal safe. - */ - -extern int ust_safe_snprintf(char *str, size_t n, const char *fmt, ...) - __attribute__ ((format (printf, 3, 4))); - +/* A dummy function to force format checking */ static inline void __attribute__ ((format (printf, 1, 2))) __check_ust_safe_fmt(const char *fmt, ...) { } -#define sigsafe_print_err(fmt, args...) \ -{ \ - /* Can't use dynamic allocation. Limit ourselves to 250 chars. */ \ - char ____buf[250]; \ - int ____saved_errno; \ -\ - /* Save the errno. */ \ - ____saved_errno = errno; \ -\ - ust_safe_snprintf(____buf, sizeof(____buf), fmt, ## args); \ -\ - /* Add end of string in case of buffer overflow. */ \ - ____buf[sizeof(____buf)-1] = 0; \ -\ - patient_write(STDERR_FILENO, ____buf, strlen(____buf)); \ - /* Can't print errors because we are in the error printing code path. */ \ -\ - /* Restore errno, in order to be async-signal safe. */ \ - errno = ____saved_errno; \ -} - #define UST_STR_COMPONENT XSTR(UST_COMPONENT) -#define ERRMSG(fmt, args...) do { sigsafe_print_err(UST_STR_COMPONENT "[%ld/%ld]: " fmt " (in %s() at " __FILE__ ":" XSTR(__LINE__) ")\n", (long) getpid(), (long) syscall(SYS_gettid), ## args, __func__); fflush(stderr); } while(0) +#define ERRMSG(fmt, args...) do { fprintf(stderr, UST_STR_COMPONENT "[%ld/%ld]: " fmt " (in %s() at " __FILE__ ":" XSTR(__LINE__) ")\n", (long) getpid(), (long) syscall(SYS_gettid), ## args, __func__); } while(0) #ifdef UST_DEBUG # define DBG(fmt, args...) ERRMSG(fmt, ## args) -# define DBG_raw(fmt, args...) do { sigsafe_print_err(fmt, ## args); fflush(stderr); } while(0) +# define DBG_raw(fmt, args...) do { fprintf(stderr, fmt, ## args); } while(0) #else # define DBG(fmt, args...) __check_ust_safe_fmt(fmt, ## args) # define DBG_raw(fmt, args...) __check_ust_safe_fmt(fmt, ## args) @@ -107,4 +79,4 @@ static inline void __attribute__ ((format (printf, 1, 2))) #define WARN_ON(condition) do { if (unlikely(condition)) WARN("condition not respected on line %s:%d", __FILE__, __LINE__); } while(0) #define WARN_ON_ONCE(condition) WARN_ON(condition) -#endif /* USTERR_H */ +#endif /* _USTERR_H */