int ret;
struct ltt_kernel_channel *kchan;
+ assert(ksession);
+ assert(kctx);
+
DBG("Adding kernel context to all channels");
/* Go over all channels */
{
int ret;
+ assert(kchan);
+ assert(kctx);
+
DBG("Add kernel context to channel '%s'", kchan->channel->name);
ret = kernel_add_channel_context(kchan, kctx);
struct lttng_ht_iter iter;
struct lttng_ht_node_ulong *uctx_node;
+ assert(usess);
+ assert(uchan);
+ assert(ctx);
+
/* Create ltt UST context */
uctx = trace_ust_create_context(ctx);
if (uctx == NULL) {
goto error;
}
+ rcu_read_lock();
+
/* Lookup context before adding it */
lttng_ht_lookup(uchan->ctx, (void *)((unsigned long)uctx->ctx.ctx), &iter);
uctx_node = lttng_ht_iter_get_node_ulong(&iter);
if (uctx_node != NULL) {
ret = -EEXIST;
+ rcu_read_unlock();
goto error;
}
/* Add ltt UST context node to ltt UST channel */
lttng_ht_add_unique_ulong(uchan->ctx, &uctx->node);
+ rcu_read_unlock();
+ cds_list_add_tail(&uctx->list, &uchan->ctx_list);
DBG("Context UST %d added to channel %s", uctx->ctx.ctx, uchan->name);
struct ltt_kernel_channel *kchan;
struct lttng_kernel_context kctx;
+ assert(ksession);
+ assert(ctx);
+ assert(channel_name);
+
/* Setup kernel context structure */
switch (ctx->ctx) {
case LTTNG_EVENT_CONTEXT_PID:
LTTNG_SYMBOL_NAME_LEN);
kctx.u.perf_counter.name[LTTNG_SYMBOL_NAME_LEN - 1] = '\0';
- if (strlen(channel_name) == 0) {
+ if (*channel_name == '\0') {
ret = add_kctx_all_channels(ksession, &kctx);
if (ret != LTTNG_OK) {
goto error;
struct lttng_ht *chan_ht;
struct ltt_ust_channel *uchan = NULL;
+ assert(usess);
+ assert(ctx);
+ assert(channel_name);
+
+ rcu_read_lock();
+
/*
* Define which channel's hashtable to use from the domain or quit if
* unknown domain.
}
/* Get UST channel if defined */
- if (strlen(channel_name) != 0) {
+ if (channel_name[0] != '\0') {
uchan = trace_ust_find_channel_by_name(chan_ht, channel_name);
if (uchan == NULL) {
ret = LTTNG_ERR_UST_CHAN_NOT_FOUND;
/* Add ctx to channel */
ret = add_uctx_to_channel(usess, domain, uchan, ctx);
} else {
+ rcu_read_lock();
/* Add ctx all events, all channels */
cds_lfht_for_each_entry(chan_ht->ht, &iter.iter, uchan, node.node) {
ret = add_uctx_to_channel(usess, domain, uchan, ctx);
continue;
}
}
+ rcu_read_unlock();
}
switch (ret) {
}
error:
+ rcu_read_unlock();
return ret;
}