* @author Alexandre Montplaisir
* @author David Goulet
*/
-class SessiondEnableEventCommand implements ISessiondCommand {
+class SessiondEnableEventCommand extends SessiondCommand {
- private static final int INT_SIZE = 4;
+ /** Fixed event name length. Value defined by the lttng agent protocol. */
+ private static final int EVENT_NAME_LENGTH = 256;
+
+ private final boolean commandIsValid;
/* Parameters of the event rule being enabled */
private final String eventName;
if (data == null) {
throw new IllegalArgumentException();
}
- int dataOffset = INT_SIZE * 2;
-
ByteBuffer buf = ByteBuffer.wrap(data);
- buf.order(ByteOrder.LITTLE_ENDIAN);
+ buf.order(ByteOrder.BIG_ENDIAN);
int logLevel = buf.getInt();
int logLevelType = buf.getInt();
logLevelFilter = new LogLevelSelector(logLevel, logLevelType);
- eventName = new String(data, dataOffset, data.length - dataOffset).trim();
- filterString = null; /* Not yet sent by the sessiond */
+ /* Read the event name */
+ byte[] eventNameBytes = new byte[EVENT_NAME_LENGTH];
+ buf.get(eventNameBytes);
+ eventName = new String(eventNameBytes, SESSIOND_PROTOCOL_CHARSET).trim();
+
+ /* Read the filter string */
+ filterString = readNextString(buf);
+
+ /* The command was invalid if the string could not be read correctly */
+ commandIsValid = (filterString != null);
}
@Override
public LttngAgentResponse execute(ILttngTcpClientListener agent) {
+ if (!commandIsValid) {
+ return LttngAgentResponse.FAILURE_RESPONSE;
+ }
+
EventRule rule = new EventRule(eventName, logLevelFilter, filterString);
boolean success = agent.eventEnabled(rule);
return (success ? LttngAgentResponse.SUCESS_RESPONSE : LttngAgentResponse.FAILURE_RESPONSE);