projects
/
lttng-tools.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
Fix: channel names are not validated
[lttng-tools.git]
/
src
/
bin
/
lttng-sessiond
/
cmd.c
diff --git
a/src/bin/lttng-sessiond/cmd.c
b/src/bin/lttng-sessiond/cmd.c
index c1e33693f913076d58d8dba938975be23e10d4bc..11ff9b489dd2d0be182b14f6743b2807dc4285b8 100644
(file)
--- a/
src/bin/lttng-sessiond/cmd.c
+++ b/
src/bin/lttng-sessiond/cmd.c
@@
-18,6
+18,7
@@
#define _GNU_SOURCE
#define _LGPL_SOURCE
#include <assert.h>
#define _GNU_SOURCE
#define _LGPL_SOURCE
#include <assert.h>
+#include <string.h>
#include <inttypes.h>
#include <urcu/list.h>
#include <urcu/uatomic.h>
#include <inttypes.h>
#include <urcu/list.h>
#include <urcu/uatomic.h>
@@
-939,11
+940,21
@@
int cmd_enable_channel(struct ltt_session *session,
int ret;
struct ltt_ust_session *usess = session->ust_session;
struct lttng_ht *chan_ht;
int ret;
struct ltt_ust_session *usess = session->ust_session;
struct lttng_ht *chan_ht;
+ size_t len;
assert(session);
assert(attr);
assert(domain);
assert(session);
assert(attr);
assert(domain);
+ len = strnlen(attr->name, sizeof(attr->name));
+
+ /* Validate channel name */
+ if (attr->name[0] == '.' ||
+ memchr(attr->name, '/', len) != NULL) {
+ ret = LTTNG_ERR_INVALID_CHANNEL_NAME;
+ goto end;
+ }
+
DBG("Enabling channel %s for session %s", attr->name, session->name);
rcu_read_lock();
DBG("Enabling channel %s for session %s", attr->name, session->name);
rcu_read_lock();
@@
-1024,6
+1035,7
@@
int cmd_enable_channel(struct ltt_session *session,
error:
rcu_read_unlock();
error:
rcu_read_unlock();
+end:
return ret;
}
return ret;
}
This page took
0.023565 seconds
and
4
git commands to generate.