projects
/
lttng-tools.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
Optimization: lttng UI uses sprintf instead of strcpy
[lttng-tools.git]
/
src
/
bin
/
lttng
/
commands
/
list.c
diff --git
a/src/bin/lttng/commands/list.c
b/src/bin/lttng/commands/list.c
index efa1abfd0751e4c9f7858114cbf7009a94ae0a2d..bcada31cd38625b47322d665c9ebbf7ff27a2b8f 100644
(file)
--- a/
src/bin/lttng/commands/list.c
+++ b/
src/bin/lttng/commands/list.c
@@
-214,6
+214,7
@@
static char *get_exclusion_names_msg(struct lttng_event *event)
int count;
size_t i;
const char * const exclusion_fmt = " [exclusions: ";
int count;
size_t i;
const char * const exclusion_fmt = " [exclusions: ";
+ const size_t exclusion_fmt_len = strlen(exclusion_fmt);
exclusion_count = lttng_event_get_exclusion_name_count(event);
if (exclusion_count < 0) {
exclusion_count = lttng_event_get_exclusion_name_count(event);
if (exclusion_count < 0) {
@@
-234,15
+235,12
@@
static char *get_exclusion_names_msg(struct lttng_event *event)
*/
exclusion_msg = malloc(exclusion_count +
exclusion_count * LTTNG_SYMBOL_NAME_LEN +
*/
exclusion_msg = malloc(exclusion_count +
exclusion_count * LTTNG_SYMBOL_NAME_LEN +
-
strlen(exclusion_fmt)
+ 1);
+
exclusion_fmt_len
+ 1);
if (!exclusion_msg) {
goto end;
}
if (!exclusion_msg) {
goto end;
}
- at = exclusion_msg;
- count = sprintf(at, exclusion_fmt);
- at += count;
-
+ at = strcpy(exclusion_msg, exclusion_fmt) + exclusion_fmt_len;
for (i = 0; i < exclusion_count; ++i) {
const char *name;
for (i = 0; i < exclusion_count; ++i) {
const char *name;
@@
-266,7
+264,7
@@
static char *get_exclusion_names_msg(struct lttng_event *event)
}
/* This also puts a final '\0' at the end of exclusion_msg */
}
/* This also puts a final '\0' at the end of exclusion_msg */
- s
printf
(at, "]");
+ s
trcpy
(at, "]");
end:
return exclusion_msg;
end:
return exclusion_msg;
This page took
0.025586 seconds
and
4
git commands to generate.