From 18baca846d9957651fd0f10b6e5c9cdaa42ce748 Mon Sep 17 00:00:00 2001 From: David Goulet Date: Thu, 24 Jun 2010 12:32:29 -0400 Subject: [PATCH] Fix directory creation mode. Unless umask is set to 0 the default umask of the system, commonly 022, will be used and thus it becomes impossible to get the 777 mode. --- libustcomm/ustcomm.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/libustcomm/ustcomm.c b/libustcomm/ustcomm.c index d537eeb..fe29977 100644 --- a/libustcomm/ustcomm.c +++ b/libustcomm/ustcomm.c @@ -46,6 +46,7 @@ static int mkdir_p(const char *path, mode_t mode) int retval = 0; int result; + mode_t old_umask; tmp = malloc(strlen(path) + 1); if (tmp == NULL) @@ -54,6 +55,7 @@ static int mkdir_p(const char *path, mode_t mode) /* skip first / */ path_p = path+1; + old_umask = umask(0); for(;;) { while (*path_p != '/') { if(*path_p == 0) @@ -85,6 +87,7 @@ static int mkdir_p(const char *path, mode_t mode) } free(tmp); + umask(old_umask); return retval; } @@ -645,7 +648,8 @@ static int ensure_dir_exists(const char *dir) /* ENOENT */ int result; - result = mkdir_p(dir, 0777); + /* mkdir mode to 0777 */ + result = mkdir_p(dir, S_IRWXU | S_IRWXG | S_IRWXO); if(result != 0) { ERR("executing in recursive creation of directory %s", dir); return -1; -- 2.34.1