Tracepoint and TRACEPOINT_EVENT API cleanup
[ust.git] / libust / tracepoint.c
index 6fe9cd7569444a79895d0fe7133e8a27c8e1ed4c..6a8795b70c218498446d7b16370cfb62d484c88f 100644 (file)
@@ -4,8 +4,8 @@
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
- * License as published by the Free Software Foundation; either
- * version 2.1 of the License, or (at your option) any later version.
+ * License as published by the Free Software Foundation;
+ * version 2.1 of the License.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * Ported to userspace by Pierre-Marc Fournier.
  */
 
+#define _LGPL_SOURCE
 #include <errno.h>
 #include <ust/tracepoint.h>
+#include <ust/tracepoint-internal.h>
 #include <ust/core.h>
 #include <ust/kcompat/kcompat.h>
-#include "usterr.h"
-
-#define _LGPL_SOURCE
 #include <urcu-bp.h>
+#include <urcu/hlist.h>
+
+#include "usterr_signal_safe.h"
 
 //extern struct tracepoint __start___tracepoints[] __attribute__((visibility("hidden")));
 //extern struct tracepoint __stop___tracepoints[] __attribute__((visibility("hidden")));
@@ -35,7 +37,7 @@
 static const int tracepoint_debug;
 
 /* libraries that contain tracepoints (struct tracepoint_lib) */
-static LIST_HEAD(libs);
+static CDS_LIST_HEAD(libs);
 
 /*
  * tracepoints_mutex nests inside module_mutex. Tracepoints mutex protects the
@@ -49,7 +51,7 @@ static DEFINE_MUTEX(tracepoints_mutex);
  */
 #define TRACEPOINT_HASH_BITS 6
 #define TRACEPOINT_TABLE_SIZE (1 << TRACEPOINT_HASH_BITS)
-static struct hlist_head tracepoint_table[TRACEPOINT_TABLE_SIZE];
+static struct cds_hlist_head tracepoint_table[TRACEPOINT_TABLE_SIZE];
 
 /*
  * Note about RCU :
@@ -58,8 +60,8 @@ static struct hlist_head tracepoint_table[TRACEPOINT_TABLE_SIZE];
  * Tracepoint entries modifications are protected by the tracepoints_mutex.
  */
 struct tracepoint_entry {
-       struct hlist_node hlist;
-       struct probe *probes;
+       struct cds_hlist_node hlist;
+       struct tracepoint_probe *probes;
        int refcount;   /* Number of times armed. 0 if disarmed. */
        char name[0];
 };
@@ -67,14 +69,14 @@ struct tracepoint_entry {
 struct tp_probes {
        union {
 //ust//                struct rcu_head rcu;
-               struct list_head list;
+               struct cds_list_head list;
        } u;
-       struct probe probes[0];
+       struct tracepoint_probe probes[0];
 };
 
 static inline void *allocate_probes(int count)
 {
-       struct tp_probes *p  = zmalloc(count * sizeof(struct probe)
+       struct tp_probes *p  = zmalloc(count * sizeof(struct tracepoint_probe)
                        + sizeof(struct tp_probes));
        return p == NULL ? NULL : p->probes;
 }
@@ -111,7 +113,7 @@ tracepoint_entry_add_probe(struct tracepoint_entry *entry,
                           void *probe, void *data)
 {
        int nr_probes = 0;
-       struct probe *old, *new;
+       struct tracepoint_probe *old, *new;
 
        WARN_ON(!probe);
 
@@ -129,7 +131,7 @@ tracepoint_entry_add_probe(struct tracepoint_entry *entry,
        if (new == NULL)
                return ERR_PTR(-ENOMEM);
        if (old)
-               memcpy(new, old, nr_probes * sizeof(struct probe));
+               memcpy(new, old, nr_probes * sizeof(struct tracepoint_probe));
        new[nr_probes].func = probe;
        new[nr_probes].data = data;
        new[nr_probes + 1].func = NULL;
@@ -144,7 +146,7 @@ tracepoint_entry_remove_probe(struct tracepoint_entry *entry, void *probe,
                              void *data)
 {
        int nr_probes = 0, nr_del = 0, i;
-       struct probe *old, *new;
+       struct tracepoint_probe *old, *new;
 
        old = entry->probes;
 
@@ -192,13 +194,13 @@ tracepoint_entry_remove_probe(struct tracepoint_entry *entry, void *probe,
  */
 static struct tracepoint_entry *get_tracepoint(const char *name)
 {
-       struct hlist_head *head;
-       struct hlist_node *node;
+       struct cds_hlist_head *head;
+       struct cds_hlist_node *node;
        struct tracepoint_entry *e;
        u32 hash = jhash(name, strlen(name), 0);
 
        head = &tracepoint_table[hash & (TRACEPOINT_TABLE_SIZE - 1)];
-       hlist_for_each_entry(e, node, head, hlist) {
+       cds_hlist_for_each_entry(e, node, head, hlist) {
                if (!strcmp(name, e->name))
                        return e;
        }
@@ -211,14 +213,14 @@ static struct tracepoint_entry *get_tracepoint(const char *name)
  */
 static struct tracepoint_entry *add_tracepoint(const char *name)
 {
-       struct hlist_head *head;
-       struct hlist_node *node;
+       struct cds_hlist_head *head;
+       struct cds_hlist_node *node;
        struct tracepoint_entry *e;
        size_t name_len = strlen(name) + 1;
        u32 hash = jhash(name, name_len-1, 0);
 
        head = &tracepoint_table[hash & (TRACEPOINT_TABLE_SIZE - 1)];
-       hlist_for_each_entry(e, node, head, hlist) {
+       cds_hlist_for_each_entry(e, node, head, hlist) {
                if (!strcmp(name, e->name)) {
                        DBG("tracepoint %s busy", name);
                        return ERR_PTR(-EEXIST);        /* Already there */
@@ -234,7 +236,7 @@ static struct tracepoint_entry *add_tracepoint(const char *name)
        memcpy(&e->name[0], name, name_len);
        e->probes = NULL;
        e->refcount = 0;
-       hlist_add_head(&e->hlist, head);
+       cds_hlist_add_head(&e->hlist, head);
        return e;
 }
 
@@ -244,7 +246,7 @@ static struct tracepoint_entry *add_tracepoint(const char *name)
  */
 static inline void remove_tracepoint(struct tracepoint_entry *e)
 {
-       hlist_del(&e->hlist);
+       cds_hlist_del(&e->hlist);
        free(e);
 }
 
@@ -257,14 +259,14 @@ static void set_tracepoint(struct tracepoint_entry **entry,
        WARN_ON(strcmp((*entry)->name, elem->name) != 0);
 
        /*
-        * rcu_assign_pointer has a smp_wmb() which makes sure that the new
+        * rcu_assign_pointer has a cmm_smp_wmb() which makes sure that the new
         * probe callbacks array is consistent before setting a pointer to it.
         * This array is referenced by __DO_TRACE from
-        * include/linux/tracepoints.h. A matching smp_read_barrier_depends()
+        * include/linux/tracepoints.h. A matching cmm_smp_read_barrier_depends()
         * is used.
         */
        rcu_assign_pointer(elem->probes, (*entry)->probes);
-       elem->state__imv = active;
+       elem->state = active;
 }
 
 /*
@@ -275,7 +277,7 @@ static void set_tracepoint(struct tracepoint_entry **entry,
  */
 static void disable_tracepoint(struct tracepoint *elem)
 {
-       elem->state__imv = 0;
+       elem->state = 0;
        rcu_assign_pointer(elem->probes, NULL);
 }
 
@@ -286,24 +288,26 @@ static void disable_tracepoint(struct tracepoint *elem)
  *
  * Updates the probe callback corresponding to a range of tracepoints.
  */
-void tracepoint_update_probe_range(struct tracepoint *begin,
-                                  struct tracepoint *end)
+void tracepoint_update_probe_range(struct tracepoint * const *begin,
+                                  struct tracepoint * const *end)
 {
-       struct tracepoint *iter;
+       struct tracepoint * const *iter;
        struct tracepoint_entry *mark_entry;
 
        pthread_mutex_lock(&tracepoints_mutex);
        for (iter = begin; iter < end; iter++) {
-               if (!iter->name) {
-                       disable_tracepoint(iter);
+               if (!*iter)
+                       continue;       /* skip dummy */
+               if (!(*iter)->name) {
+                       disable_tracepoint(*iter);
                        continue;
                }
-               mark_entry = get_tracepoint(iter->name);
+               mark_entry = get_tracepoint((*iter)->name);
                if (mark_entry) {
-                       set_tracepoint(&mark_entry, iter,
+                       set_tracepoint(&mark_entry, *iter,
                                        !!mark_entry->refcount);
                } else {
-                       disable_tracepoint(iter);
+                       disable_tracepoint(*iter);
                }
        }
        pthread_mutex_unlock(&tracepoints_mutex);
@@ -314,7 +318,7 @@ static void lib_update_tracepoints(void)
        struct tracepoint_lib *lib;
 
 //ust//        pthread_mutex_lock(&module_mutex);
-       list_for_each_entry(lib, &libs, list)
+       cds_list_for_each_entry(lib, &libs, list)
                tracepoint_update_probe_range(lib->tracepoints_start,
                                lib->tracepoints_start + lib->tracepoints_count);
 //ust//        pthread_mutex_unlock(&module_mutex);
@@ -330,22 +334,19 @@ static void tracepoint_update_probes(void)
 //ust//                __stop___tracepoints);
        /* tracepoints in modules. */
        lib_update_tracepoints();
-       /* Update immediate values */
-       core_imv_update();
-//ust//        module_imv_update();
 }
 
-static struct probe *
+static struct tracepoint_probe *
 tracepoint_add_probe(const char *name, void *probe, void *data)
 {
        struct tracepoint_entry *entry;
-       struct probe *old;
+       struct tracepoint_probe *old;
 
        entry = get_tracepoint(name);
        if (!entry) {
                entry = add_tracepoint(name);
                if (IS_ERR(entry))
-                       return (struct probe *)entry;
+                       return (struct tracepoint_probe *)entry;
        }
        old = tracepoint_entry_add_probe(entry, probe, data);
        if (IS_ERR(old) && !entry->refcount)
@@ -354,14 +355,14 @@ tracepoint_add_probe(const char *name, void *probe, void *data)
 }
 
 /**
- * tracepoint_probe_register -  Connect a probe to a tracepoint
+ * __tracepoint_probe_register -  Connect a probe to a tracepoint
  * @name: tracepoint name
  * @probe: probe handler
  *
  * Returns 0 if ok, error value on error.
  * The probe address must at least be aligned on the architecture pointer size.
  */
-int tracepoint_probe_register(const char *name, void *probe, void *data)
+int __tracepoint_probe_register(const char *name, void *probe, void *data)
 {
        void *old;
 
@@ -375,7 +376,6 @@ int tracepoint_probe_register(const char *name, void *probe, void *data)
        release_probes(old);
        return 0;
 }
-//ust// EXPORT_SYMBOL_GPL(tracepoint_probe_register);
 
 static void *tracepoint_remove_probe(const char *name, void *probe, void *data)
 {
@@ -404,7 +404,7 @@ static void *tracepoint_remove_probe(const char *name, void *probe, void *data)
  * itself uses stop_machine(), which insures that every preempt disabled section
  * have finished.
  */
-int tracepoint_probe_unregister(const char *name, void *probe, void *data)
+int __tracepoint_probe_unregister(const char *name, void *probe, void *data)
 {
        void *old;
 
@@ -418,9 +418,8 @@ int tracepoint_probe_unregister(const char *name, void *probe, void *data)
        release_probes(old);
        return 0;
 }
-//ust// EXPORT_SYMBOL_GPL(tracepoint_probe_unregister);
 
-static LIST_HEAD(old_probes);
+static CDS_LIST_HEAD(old_probes);
 static int need_update;
 
 static void tracepoint_add_old_probes(void *old)
@@ -429,7 +428,7 @@ static void tracepoint_add_old_probes(void *old)
        if (old) {
                struct tp_probes *tp_probes = _ust_container_of(old,
                        struct tp_probes, probes[0]);
-               list_add(&tp_probes->u.list, &old_probes);
+               cds_list_add(&tp_probes->u.list, &old_probes);
        }
 }
 
@@ -486,7 +485,7 @@ int tracepoint_probe_unregister_noupdate(const char *name, void *probe,
  */
 void tracepoint_probe_update_all(void)
 {
-       LIST_HEAD(release_probes);
+       CDS_LIST_HEAD(release_probes);
        struct tp_probes *pos, *next;
 
        pthread_mutex_lock(&tracepoints_mutex);
@@ -494,14 +493,14 @@ void tracepoint_probe_update_all(void)
                pthread_mutex_unlock(&tracepoints_mutex);
                return;
        }
-       if (!list_empty(&old_probes))
-               list_replace_init(&old_probes, &release_probes);
+       if (!cds_list_empty(&old_probes))
+               cds_list_replace_init(&old_probes, &release_probes);
        need_update = 0;
        pthread_mutex_unlock(&tracepoints_mutex);
 
        tracepoint_update_probes();
-       list_for_each_entry_safe(pos, next, &release_probes, u.list) {
-               list_del(&pos->u.list);
+       cds_list_for_each_entry_safe(pos, next, &release_probes, u.list) {
+               cds_list_del(&pos->u.list);
 //ust//                call_rcu_sched(&pos->u.rcu, rcu_free_old_probes);
                synchronize_rcu();
                free(pos);
@@ -519,7 +518,7 @@ int lib_get_iter_tracepoints(struct tracepoint_iter *iter)
        int found = 0;
 
 //ust//        pthread_mutex_lock(&module_mutex);
-       list_for_each_entry(iter_lib, &libs, list) {
+       cds_list_for_each_entry(iter_lib, &libs, list) {
                if (iter_lib < iter->lib)
                        continue;
                else if (iter_lib > iter->lib)
@@ -546,15 +545,17 @@ int lib_get_iter_tracepoints(struct tracepoint_iter *iter)
  * Will return the first tracepoint in the range if the input tracepoint is
  * NULL.
  */
-int tracepoint_get_iter_range(struct tracepoint **tracepoint,
-       struct tracepoint *begin, struct tracepoint *end)
+int tracepoint_get_iter_range(struct tracepoint * const **tracepoint,
+       struct tracepoint * const *begin, struct tracepoint * const *end)
 {
-       if (!*tracepoint && begin != end) {
+       if (!*tracepoint && begin != end)
                *tracepoint = begin;
-               return 1;
+       while (*tracepoint >= begin && *tracepoint < end) {
+               if (!**tracepoint)
+                       (*tracepoint)++;        /* skip dummy */
+               else
+                       return 1;
        }
-       if (*tracepoint >= begin && *tracepoint < end)
-               return 1;
        return 0;
 }
 //ust// EXPORT_SYMBOL_GPL(tracepoint_get_iter_range);
@@ -647,19 +648,21 @@ void tracepoint_set_new_tracepoint_cb(void (*cb)(struct tracepoint *))
        new_tracepoint_cb = cb;
 }
 
-static void new_tracepoints(struct tracepoint *start, struct tracepoint *end)
+static void new_tracepoints(struct tracepoint * const *start, struct tracepoint * const *end)
 {
-       if(new_tracepoint_cb) {
-               struct tracepoint *t;
-               for(t=start; t < end; t++) {
-                       new_tracepoint_cb(t);
+       if (new_tracepoint_cb) {
+               struct tracepoint * const *t;
+
+               for(t = start; t < end; t++) {
+                       if (*t)
+                               new_tracepoint_cb(*t);
                }
        }
 }
 
-int tracepoint_register_lib(struct tracepoint *tracepoints_start, int tracepoints_count)
+int tracepoint_register_lib(struct tracepoint * const *tracepoints_start, int tracepoints_count)
 {
-       struct tracepoint_lib *pl;
+       struct tracepoint_lib *pl, *iter;
 
        pl = (struct tracepoint_lib *) zmalloc(sizeof(struct tracepoint_lib));
 
@@ -668,7 +671,20 @@ int tracepoint_register_lib(struct tracepoint *tracepoints_start, int tracepoint
 
        /* FIXME: maybe protect this with its own mutex? */
        pthread_mutex_lock(&tracepoints_mutex);
-       list_add(&pl->list, &libs);
+       /*
+        * We sort the libs by struct lib pointer address.
+        */
+       cds_list_for_each_entry_reverse(iter, &libs, list) {
+               BUG_ON(iter == pl);    /* Should never be in the list twice */
+               if (iter < pl) {
+                       /* We belong to the location right after iter. */
+                       cds_list_add(&pl->list, &iter->list);
+                       goto lib_added;
+               }
+       }
+       /* We should be added at the head of the list */
+       cds_list_add(&pl->list, &libs);
+lib_added:
        pthread_mutex_unlock(&tracepoints_mutex);
 
        new_tracepoints(tracepoints_start, tracepoints_start + tracepoints_count);
@@ -676,21 +692,22 @@ int tracepoint_register_lib(struct tracepoint *tracepoints_start, int tracepoint
        /* FIXME: update just the loaded lib */
        lib_update_tracepoints();
 
-       DBG("just registered a tracepoints section from %p and having %d tracepoints", tracepoints_start, tracepoints_count);
+       /* tracepoints_count - 1: skip dummy */
+       DBG("just registered a tracepoints section from %p and having %d tracepoints (minus dummy tracepoints)", tracepoints_start, tracepoints_count);
 
        return 0;
 }
 
-int tracepoint_unregister_lib(struct tracepoint *tracepoints_start)
+int tracepoint_unregister_lib(struct tracepoint * const *tracepoints_start)
 {
        struct tracepoint_lib *lib;
 
        pthread_mutex_lock(&tracepoints_mutex);
 
-       list_for_each_entry(lib, &libs, list) {
-               if(lib->tracepoints_start == tracepoints_start) {
+       cds_list_for_each_entry(lib, &libs, list) {
+               if (lib->tracepoints_start == tracepoints_start) {
                        struct tracepoint_lib *lib2free = lib;
-                       list_del(&lib->list);
+                       cds_list_del(&lib->list);
                        free(lib2free);
                        break;
                }
This page took 0.029063 seconds and 4 git commands to generate.