Cleanup leftover UST comments, add comments about current implementation limitations Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Privatize headers Remove most installed headers, which should be internal. The header kcompat (kernel-style compatibility header) only makes sense within the UST package: this should never be exported, nor be included into instrumented applications. Move the type-serializer header back into libust/. It is so internal it does not even belong to include/ust/. Standardize all the installed headers on non-kcompat style: use uint64_t instead of u64 for types, open-code likely/unlikely. Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Privatize part of marker.h, and type-serializer.h The current interface we publish is ust_marker(), tracepoint() and TRACEPOINT_EVENT() (and associated _NOARGS, CLASS, INSTANCE and TRACEPOINT_CREATE_PROBES). Besides that, consider any lower-level API showing the UST internals as, well, internal. Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Tracepoint and TRACEPOINT_EVENT API cleanup We want to move towards a TRACEPOINT_EVENT-based API only, so start cleaning up right now. Prefix with _ or __ all members that are internal to UST. Move all the non-exported API members (that don't need to be around in program inclusion) to tracepoint-internal.h (which is not meant to be installed on the system). Unit tests can still use the internal API members for now, but should gradually move to use TRACEPOINT_EVENT as we start implementing the FIELDS() declaration. TRACEPOINT_EVENT is changed from the kernel incarnation (TRACE_EVENT): we take only 3 arguments: proto, args and fields. The "fields" describe the event layout _and_ targets the data source. Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Make libustctl list only online pids v3 Changes since v2: Botox. Changes since v1: Cosmetic surgery at a european cost Previously libustctl would list all pids. This patch changes this so only online pids are listed. This is done by appending on each socket name the mtime from the proc/<pid> directory. This way a socket can be checked to see if the appended mtime matches the mtime of the proc dir for the current pid, thus allowing us to distinguish between old and new socket files. Signed-off-by: Nils Carlson <nils.carlson@ericsson.com> Acked-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Markers: temporarily remove GDB support Remove GDB support temporarily, awaiting a better implementation that does not require so much asm trickery. Imported the kernel LTTng code back into UST to use C declarations for the marker structures. The plan is to move to a SDT-based implementation (using variable number of arguments). This patch is required to make the MIPS port work. Tested by Jason Wessel. Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com> Tested-by: Jason Wessel <jason.wessel@windriver.com>
Remove #define _LGPL_SOURCE from public headers this header can be included by non-LGPL applications. Ensure that use it. Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
LGPLv2.1 relicensing agreements Steven just stated clearly that he only accepts relicencing to LGPLv2.1 (not later). So I think we might have been interpreting his previous acceptance a little too broadly when specifying "LGPLV2.1+". Change the licensing text to reflect this. If some of the contributors specifically said they were OK with "or later", we could add this back upon rechecking their original acceptance email. The pointers to the original public emails should have been present in the relicensing file to make our current job easier, but this is unfortunately not the case. Also updated the stringify.h, tracepoint.c, marker.c and trace_event.c files. Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Markers: Namespace cleanup, with API change. ** API change: MARK_NOARGS becomes UST_MARKER_NOARGS ** Cleanup the "marker" namespace by using "ust_marker/UST_MARKER". Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>