From: Christian Babeux <christian.babeux@efficios.com>
Date: Tue, 4 Dec 2012 21:21:40 +0000 (-0500)
Subject: Cygwin: Remove weak symbols attributes due to semantic differences
X-Git-Url: http://git.lttng.org/?p=lttng-ust.git;a=commitdiff_plain;h=167ff4df850ed5c954ee374db66a04b1c9a4ef34

Cygwin: Remove weak symbols attributes due to semantic differences

Weak symbols on Cygwin/PE platforms do not have the same semantics
as on Linux/ELF platforms [1].

The __start___tracepoints_ptrs and __stop___tracepoints_ptrs symbols
were NULL and tracepoints were not properly registered due to this
difference.

[1] - http://cygwin.com/ml/cygwin/2010-04/msg00281.html
---

diff --git a/include/lttng/tracepoint.h b/include/lttng/tracepoint.h
index 5bab476b..01561d81 100644
--- a/include/lttng/tracepoint.h
+++ b/include/lttng/tracepoint.h
@@ -235,19 +235,14 @@ extern struct tracepoint_dlopen tracepoint_dlopen;
 		__attribute__((used, section("__tracepoints_ptrs"))) =		\
 			&__tracepoint_##_provider##___##_name;
 
-/*
- * These weak symbols, the constructor, and destructor take care of
- * registering only _one_ instance of the tracepoints per shared-ojbect
- * (or for the whole main program).
- */
 extern struct tracepoint * const __start___tracepoints_ptrs[]
-	__attribute__((weak, visibility("hidden")));
+	__attribute__((visibility("hidden")));
 extern struct tracepoint * const __stop___tracepoints_ptrs[]
-	__attribute__((weak, visibility("hidden")));
+	__attribute__((visibility("hidden")));
 int __tracepoint_registered
-	__attribute__((weak, visibility("hidden")));
+	__attribute__((visibility("hidden")));
 struct tracepoint_dlopen tracepoint_dlopen
-	__attribute__((weak, visibility("hidden")));
+	__attribute__((visibility("hidden")));
 
 static void __attribute__((constructor)) __tracepoints__init(void)
 {