X-Git-Url: http://git.lttng.org/?p=lttng-ust.git;a=blobdiff_plain;f=liblttng-ust%2Flttng-ust-elf.c;h=c073e7a545b64d349d3d7bb56932a24b9025f657;hp=f2c098297acab8955df876f01f97d2a738dc0a81;hb=f5c453e975e5d417590b9a1be2a9f8504db063c0;hpb=8a208943e21700211beee3ea64180a5a534c7d2a diff --git a/liblttng-ust/lttng-ust-elf.c b/liblttng-ust/lttng-ust-elf.c index f2c09829..c073e7a5 100644 --- a/liblttng-ust/lttng-ust-elf.c +++ b/liblttng-ust/lttng-ust-elf.c @@ -243,6 +243,7 @@ struct lttng_ust_elf *lttng_ust_elf_create(const char *path) uint8_t e_ident[EI_NIDENT]; struct lttng_ust_elf_shdr *section_names_shdr; struct lttng_ust_elf *elf = NULL; + int ret, fd; elf = zmalloc(sizeof(struct lttng_ust_elf)); if (!elf) { @@ -256,12 +257,23 @@ struct lttng_ust_elf *lttng_ust_elf_create(const char *path) } lttng_ust_lock_fd_tracker(); - elf->fd = open(elf->path, O_RDONLY | O_CLOEXEC); - if (elf->fd < 0) { + fd = open(elf->path, O_RDONLY | O_CLOEXEC); + if (fd < 0) { lttng_ust_unlock_fd_tracker(); goto error; } - lttng_ust_add_fd_to_tracker(elf->fd); + + ret = lttng_ust_add_fd_to_tracker(fd); + if (ret < 0) { + ret = close(fd); + if (ret) { + PERROR("close on elf->fd"); + } + ret = -1; + lttng_ust_unlock_fd_tracker(); + goto error; + } + elf->fd = ret; lttng_ust_unlock_fd_tracker(); if (lttng_ust_read(elf->fd, e_ident, EI_NIDENT) < EI_NIDENT) {