From 2a09e9fb3029858cd04ce36471bc4a9c9d7b6624 Mon Sep 17 00:00:00 2001 From: Mathieu Desnoyers Date: Wed, 11 Jul 2012 18:23:12 -0400 Subject: [PATCH] Fix: The session list count should provide unique identifiers Never decrement it. Reported-by: Amer Alhalabi Signed-off-by: Mathieu Desnoyers --- src/bin/lttng-sessiond/session.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/bin/lttng-sessiond/session.c b/src/bin/lttng-sessiond/session.c index bcdd78d50..13abe424c 100644 --- a/src/bin/lttng-sessiond/session.c +++ b/src/bin/lttng-sessiond/session.c @@ -64,14 +64,12 @@ static unsigned int add_session_list(struct ltt_session *ls) * Delete a ltt_session structure to the global list. * * The caller MUST acquire the session list lock before. + * The session list count CANNOT be decremented, as it is used as unique + * identifier for the session in UST app hash table lookups. */ static void del_session_list(struct ltt_session *ls) { cds_list_del(&ls->list); - /* Sanity check */ - if (ltt_session_list.count > 0) { - ltt_session_list.count--; - } } /* -- 2.34.1