From: Danny Serres Date: Wed, 6 Jun 2012 18:54:30 +0000 (-0400) Subject: Fix: move memset in channel_set_attr after NULL check X-Git-Tag: v2.0.2~2 X-Git-Url: http://git.lttng.org/?p=lttng-tools.git;a=commitdiff_plain;h=afbc6a134cddbfe0721af8e4ec93702804603d62 Fix: move memset in channel_set_attr after NULL check Signed-off-by: Danny Serres Signed-off-by: David Goulet --- diff --git a/src/lib/lttng-ctl/lttng-ctl.c b/src/lib/lttng-ctl/lttng-ctl.c index 36069ef28..356fb34c4 100644 --- a/src/lib/lttng-ctl/lttng-ctl.c +++ b/src/lib/lttng-ctl/lttng-ctl.c @@ -885,13 +885,13 @@ int lttng_calibrate(struct lttng_handle *handle, void lttng_channel_set_default_attr(struct lttng_domain *domain, struct lttng_channel_attr *attr) { - memset(attr, 0, sizeof(struct lttng_channel_attr)); - /* Safety check */ if (attr == NULL || domain == NULL) { return; } + memset(attr, 0, sizeof(struct lttng_channel_attr)); + switch (domain->type) { case LTTNG_DOMAIN_KERNEL: attr->overwrite = DEFAULT_CHANNEL_OVERWRITE;