*
*/
-#include <lttng/trigger/trigger-internal.h>
-#include <lttng/condition/condition-internal.h>
-#include <lttng/condition/on-event-internal.h>
-#include <lttng/condition/on-event.h>
-#include <lttng/condition/on-event-internal.h>
-#include <lttng/condition/buffer-usage.h>
-#include <lttng/event-rule/event-rule-internal.h>
-#include <lttng/event-expr-internal.h>
-#include <lttng/action/action-internal.h>
+#include <assert.h>
#include <common/credentials.h>
-#include <common/payload.h>
-#include <common/payload-view.h>
-#include <lttng/domain.h>
-#include <common/error.h>
#include <common/dynamic-array.h>
+#include <common/error.h>
#include <common/optional.h>
-#include <assert.h>
+#include <common/payload-view.h>
+#include <common/payload.h>
#include <inttypes.h>
+#include <lttng/action/action-internal.h>
+#include <lttng/condition/buffer-usage.h>
+#include <lttng/condition/condition-internal.h>
+#include <lttng/condition/event-rule-matches-internal.h>
+#include <lttng/condition/event-rule-matches.h>
+#include <lttng/domain.h>
+#include <lttng/event-expr-internal.h>
+#include <lttng/event-rule/event-rule-internal.h>
+#include <lttng/trigger/trigger-internal.h>
+#include <pthread.h>
LTTNG_HIDDEN
bool lttng_trigger_validate(const struct lttng_trigger *trigger)
lttng_action_get(action);
trigger->action = action;
+ pthread_mutex_init(&trigger->lock, NULL);
+ trigger->registered = false;
+
end:
return trigger;
}
lttng_action_put(action);
lttng_condition_put(condition);
+ pthread_mutex_destroy(&trigger->lock);
+
free(trigger->name);
free(trigger);
}
struct lttng_trigger *trigger, uid_t uid)
{
enum lttng_trigger_status ret = LTTNG_TRIGGER_STATUS_OK;
+ const uid_t euid = geteuid();
const struct lttng_credentials creds = {
.uid = LTTNG_OPTIONAL_INIT_VALUE(uid),
.gid = LTTNG_OPTIONAL_INIT_UNSET,
}
/* Client-side validation only to report a clearer error. */
- if (geteuid() != 0) {
+ if (euid != 0 && euid != uid) {
ret = LTTNG_TRIGGER_STATUS_PERMISSION_DENIED;
goto end;
}
/* Apply to any domain. */
type = LTTNG_DOMAIN_NONE;
break;
- case LTTNG_CONDITION_TYPE_ON_EVENT:
+ case LTTNG_CONDITION_TYPE_EVENT_RULE_MATCHES:
/* Return the domain of the event rule. */
- c_status = lttng_condition_on_event_get_rule(
+ c_status = lttng_condition_event_rule_matches_get_rule(
trigger->condition, &event_rule);
assert(c_status == LTTNG_CONDITION_STATUS_OK);
type = lttng_event_rule_get_domain_type(event_rule);
}
switch (lttng_condition_get_type(condition)) {
- case LTTNG_CONDITION_TYPE_ON_EVENT:
+ case LTTNG_CONDITION_TYPE_EVENT_RULE_MATCHES:
{
struct lttng_event_rule *event_rule;
const enum lttng_condition_status condition_status =
- lttng_condition_on_event_borrow_rule_mutable(
- condition, &event_rule);
+ lttng_condition_event_rule_matches_borrow_rule_mutable(
+ condition, &event_rule);
assert(condition_status == LTTNG_CONDITION_STATUS_OK);
}
/* Generate the capture bytecode. */
- ret = lttng_condition_on_event_generate_capture_descriptor_bytecode(
+ ret = lttng_condition_event_rule_matches_generate_capture_descriptor_bytecode(
condition);
if (ret != LTTNG_OK) {
goto end;
{
int ret;
struct lttng_payload copy_buffer;
+ struct lttng_condition *condition_copy = NULL;
+ struct lttng_action *action_copy = NULL;
struct lttng_trigger *copy = NULL;
+ enum lttng_trigger_status trigger_status;
+ const char *trigger_name;
+ uid_t trigger_owner_uid;
lttng_payload_init(©_buffer);
- ret = lttng_trigger_serialize(trigger, ©_buffer);
+ ret = lttng_condition_serialize(trigger->condition, ©_buffer);
if (ret < 0) {
goto end;
}
struct lttng_payload_view view =
lttng_payload_view_from_payload(
©_buffer, 0, -1);
- ret = lttng_trigger_create_from_payload(
- &view, ©);
+
+ ret = lttng_condition_create_from_payload(
+ &view, &condition_copy);
if (ret < 0) {
- copy = NULL;
goto end;
}
}
+ lttng_payload_clear(©_buffer);
+
+ ret = lttng_action_serialize(trigger->action, ©_buffer);
+ if (ret < 0) {
+ goto end;
+ }
+
+ {
+ struct lttng_payload_view view =
+ lttng_payload_view_from_payload(
+ ©_buffer, 0, -1);
+
+ ret = lttng_action_create_from_payload(
+ &view, &action_copy);
+ if (ret < 0) {
+ goto end;
+ }
+ }
+
+ copy = lttng_trigger_create(condition_copy, action_copy);
+ if (!copy) {
+ ERR("Failed to allocate trigger during trigger copy");
+ goto end;
+ }
+
+ trigger_status = lttng_trigger_get_name(trigger, &trigger_name);
+ switch (trigger_status) {
+ case LTTNG_TRIGGER_STATUS_OK:
+ trigger_status = lttng_trigger_set_name(copy, trigger_name);
+ if (trigger_status != LTTNG_TRIGGER_STATUS_OK) {
+ ERR("Failed to set name of new trigger during copy");
+ goto error_cleanup_trigger;
+ }
+ break;
+ case LTTNG_TRIGGER_STATUS_UNSET:
+ break;
+ default:
+ ERR("Failed to get name of original trigger during copy");
+ goto error_cleanup_trigger;
+ }
+
+ trigger_status = lttng_trigger_get_owner_uid(
+ trigger, &trigger_owner_uid);
+ switch (trigger_status) {
+ case LTTNG_TRIGGER_STATUS_OK:
+ LTTNG_OPTIONAL_SET(©->creds.uid, trigger_owner_uid);
+ break;
+ case LTTNG_TRIGGER_STATUS_UNSET:
+ break;
+ default:
+ ERR("Failed to get owner uid of original trigger during copy");
+ goto error_cleanup_trigger;
+ }
+
+ copy->tracer_token = trigger->tracer_token;
+ copy->registered = trigger->registered;
+ goto end;
+
+error_cleanup_trigger:
+ lttng_trigger_destroy(copy);
+ copy = NULL;
end:
+ lttng_condition_put(condition_copy);
+ lttng_action_put(action_copy);
lttng_payload_reset(©_buffer);
return copy;
}
lttng_trigger_get_const_condition(trigger);
switch (lttng_condition_get_type(condition)) {
- case LTTNG_CONDITION_TYPE_ON_EVENT:
+ case LTTNG_CONDITION_TYPE_EVENT_RULE_MATCHES:
needs_tracer_notifier = true;
goto end;
case LTTNG_CONDITION_TYPE_SESSION_CONSUMED_SIZE:
end:
return needs_tracer_notifier;
}
+
+LTTNG_HIDDEN
+void lttng_trigger_set_as_registered(struct lttng_trigger *trigger)
+{
+ pthread_mutex_lock(&trigger->lock);
+ trigger->registered = true;
+ pthread_mutex_unlock(&trigger->lock);
+}
+
+LTTNG_HIDDEN
+void lttng_trigger_set_as_unregistered(struct lttng_trigger *trigger)
+{
+ pthread_mutex_lock(&trigger->lock);
+ trigger->registered = false;
+ pthread_mutex_unlock(&trigger->lock);
+}
+
+/*
+ * The trigger must be locked before calling lttng_trigger_registered.
+ * The lock is necessary since a trigger can be unregistered at anytime.
+ * Manipulations requiring that the trigger be registered must always acquire
+ * the trigger lock for the duration of the manipulation using
+ * `lttng_trigger_lock` and `lttng_trigger_unlock`.
+ */
+LTTNG_HIDDEN
+bool lttng_trigger_is_registered(struct lttng_trigger *trigger)
+{
+ ASSERT_LOCKED(trigger->lock);
+ return trigger->registered;
+}
+
+LTTNG_HIDDEN
+void lttng_trigger_lock(struct lttng_trigger *trigger)
+{
+ pthread_mutex_lock(&trigger->lock);
+}
+
+LTTNG_HIDDEN
+void lttng_trigger_unlock(struct lttng_trigger *trigger)
+{
+ pthread_mutex_unlock(&trigger->lock);
+}
projects / lttng-tools.git / blobdiff