From e699ee6c837345eb408d600178cc6054ca131164 Mon Sep 17 00:00:00 2001 From: Mathieu Desnoyers Date: Wed, 25 Nov 2020 13:44:38 -0500 Subject: [PATCH] capture: Replace FIXME by explanation of the limit Signed-off-by: Mathieu Desnoyers --- src/lttng-event-notifier-notification.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/lttng-event-notifier-notification.c b/src/lttng-event-notifier-notification.c index f675de4b..b67af11a 100644 --- a/src/lttng-event-notifier-notification.c +++ b/src/lttng-event-notifier-notification.c @@ -13,8 +13,12 @@ #include /* - * FIXME: this probably too low but it needs to be below 1024 bytes to avoid - * the frame to be larger than the 1024 limit enforced by the kernel. + * The capture buffer size needs to be below 1024 bytes to avoid the + * frame to be larger than the 1024 limit enforced by the kernel. If we + * ever need to increase it, we will need to use a memory allocation + * scheme which allows allocating temporary memory chunks from the + * instrumentation sites. This could be done by adapting lttng + * tp-mempool to become nmi-safe and lock-free. */ #define CAPTURE_BUFFER_SIZE 512 -- 2.34.1