From: Francis Deslauriers Date: Thu, 12 Dec 2019 14:32:00 +0000 (-0500) Subject: liblttng-ust-comm: move `_unlock_fd_tracker()` after `close()` on error paths X-Git-Tag: v2.13.0-rc1~536 X-Git-Url: http://git.lttng.org/?a=commitdiff_plain;h=20d1999d42392063fd530d1f6c00b93c25d178d6;hp=20d1999d42392063fd530d1f6c00b93c25d178d6;p=lttng-ust.git liblttng-ust-comm: move `_unlock_fd_tracker()` after `close()` on error paths Right now, receiving an error from `lttng_ust_add_fd_to_tracker()` means that the fd was _not_ added to the fd set. So the `lttng_ust_safe_close_fd()` (overriding `close()`) call will indeed close the fd as expected. So, it doesn't matter if the `close()` is before or after the `_unlock_`. Even considering that, I believe that it's clearer and more common to have all related operations within the `_lock_` and `_unlock_` functions. Also, `lttng_ust_add_fd_to_tracker()` might be modified in the future and fail for some other reason. Signed-off-by: Francis Deslauriers Signed-off-by: Mathieu Desnoyers Change-Id: Id29a6ab004cfd5ca601615e1a70c74cf754b12e2 ---