X-Git-Url: http://git.lttng.org/?a=blobdiff_plain;f=lttng-kernel-version.h;h=d23578357839777e402777bd3f186fc631e14862;hb=refs%2Fheads%2Fstable-2.11;hp=ec2f084d6b34d610db44c5ba4f870b1477daeb98;hpb=661063751b6ee9dab80a248b06e0e5fb84658553;p=lttng-modules.git diff --git a/lttng-kernel-version.h b/lttng-kernel-version.h index ec2f084d..d2357835 100644 --- a/lttng-kernel-version.h +++ b/lttng-kernel-version.h @@ -39,19 +39,22 @@ * of LINUX_VERSION_CODE from the kernel headers and allocate 16bits. * Otherwise, keep using the version code from the headers to minimise the * behavior change and avoid regressions. + * + * Cast the result to uint64_t to prevent overflowing when we append distro + * specific version information. */ #if (LTTNG_LINUX_PATCH >= 256) #define LTTNG_KERNEL_VERSION(a, b, c) \ - (((a) << 24) + ((b) << 16) + (c)) + ((((a) << 24) + ((b) << 16) + (c)) * 1ULL) #define LTTNG_LINUX_VERSION_CODE \ LTTNG_KERNEL_VERSION(LTTNG_LINUX_MAJOR, LTTNG_LINUX_MINOR, LTTNG_LINUX_PATCH) #else -#define LTTNG_KERNEL_VERSION(a, b, c) KERNEL_VERSION(a, b, c) -#define LTTNG_LINUX_VERSION_CODE LINUX_VERSION_CODE +#define LTTNG_KERNEL_VERSION(a, b, c) (KERNEL_VERSION(a, b, c) * 1ULL) +#define LTTNG_LINUX_VERSION_CODE (LINUX_VERSION_CODE * 1ULL) #endif @@ -108,13 +111,13 @@ LTTNG_DEBIAN_KERNEL_VERSION(a_high, b_high, c_high, d_high, e_high, f_high)) #define LTTNG_RHEL_KERNEL_VERSION(a, b, c, d, e, f) \ - (((LTTNG_KERNEL_VERSION(a, b, c)) * 10000000ULL) + ((d) * 10000) + ((e) * 100) + (f)) + (((LTTNG_KERNEL_VERSION(a, b, c)) * 100000000ULL) + ((d) * 10000) + ((e) * 100) + (f)) /* RHEL */ #ifdef RHEL_API_VERSION #define LTTNG_RHEL_VERSION_CODE \ - ((LTTNG_LINUX_VERSION_CODE * 10000000ULL) + RHEL_API_VERSION) + ((LTTNG_LINUX_VERSION_CODE * 100000000ULL) + RHEL_API_VERSION) #else #define LTTNG_RHEL_VERSION_CODE 0 #endif @@ -129,11 +132,11 @@ /* SUSE Linux enterprise */ #define LTTNG_SLE_KERNEL_VERSION(a, b, c, d, e, f) \ - (((LTTNG_KERNEL_VERSION(a, b, c)) * 10000000ULL) + ((d) * 10000) + ((e) * 100) + (f)) + (((LTTNG_KERNEL_VERSION(a, b, c)) * 100000000ULL) + ((d) * 100000) + ((e) * 100) + (f)) #ifdef SLE_API_VERSION #define LTTNG_SLE_VERSION_CODE \ - ((LTTNG_LINUX_VERSION_CODE * 10000000ULL) + SLE_API_VERSION) + ((LTTNG_LINUX_VERSION_CODE * 100000000ULL) + SLE_API_VERSION) #else #define LTTNG_SLE_VERSION_CODE 0 #endif @@ -167,11 +170,11 @@ /* RT patch */ #define LTTNG_RT_KERNEL_VERSION(a, b, c, d) \ - (((LTTNG_KERNEL_VERSION(a, b, c)) << 8) + (d)) + (((LTTNG_KERNEL_VERSION(a, b, c)) << 16) + (d)) #ifdef RT_PATCH_VERSION #define LTTNG_RT_VERSION_CODE \ - ((LTTNG_LINUX_VERSION_CODE << 8) + RT_PATCH_VERSION) + ((LTTNG_LINUX_VERSION_CODE << 16) + RT_PATCH_VERSION) #else #define LTTNG_RT_VERSION_CODE 0 #endif