X-Git-Url: http://git.lttng.org/?a=blobdiff_plain;f=lttng-context-vppid.c;h=f723a5c0cf78202dd2915a0217b10dcb647a4fdf;hb=aa29f2d33bae1396b7bd4766b7442ca780fa712e;hp=3d55fc5d6a09750f23bb08561e9f8d9725ffb75e;hpb=886d51a3d7ed5fa6b41d7f19b3e14ae6c535a44c;p=lttng-modules.git

diff --git a/lttng-context-vppid.c b/lttng-context-vppid.c
index 3d55fc5d..f723a5c0 100644
--- a/lttng-context-vppid.c
+++ b/lttng-context-vppid.c
@@ -48,11 +48,21 @@ void vppid_record(struct lttng_ctx_field *field,
 	pid_t vppid;
 
 	/*
-	 * nsproxy can be NULL when scheduled out of exit.
+	 * current nsproxy can be NULL when scheduled out of exit. pid_vnr uses
+	 * the current thread nsproxy to perform the lookup.
 	 */
+
+	/*
+	 * TODO: when we eventually add RCU subsystem instrumentation,
+	 * taking the rcu read lock here will trigger RCU tracing
+	 * recursively. We should modify the kernel synchronization so
+	 * it synchronizes both for RCU and RCU sched, and rely on
+	 * rcu_read_lock_sched_notrace.
+	 */
+
 	rcu_read_lock();
 	parent = rcu_dereference(current->real_parent);
-	if (!parent->nsproxy)
+	if (!current->nsproxy)
 		vppid = 0;
 	else
 		vppid = task_tgid_vnr(parent);
@@ -76,7 +86,7 @@ int lttng_add_vppid_to_ctx(struct lttng_ctx **ctx)
 	field->event_field.type.atype = atype_integer;
 	field->event_field.type.u.basic.integer.size = sizeof(pid_t) * CHAR_BIT;
 	field->event_field.type.u.basic.integer.alignment = lttng_alignof(pid_t) * CHAR_BIT;
-	field->event_field.type.u.basic.integer.signedness = is_signed_type(pid_t);
+	field->event_field.type.u.basic.integer.signedness = lttng_is_signed_type(pid_t);
 	field->event_field.type.u.basic.integer.reverse_byte_order = 0;
 	field->event_field.type.u.basic.integer.base = 10;
 	field->event_field.type.u.basic.integer.encoding = lttng_encode_none;
@@ -90,3 +100,7 @@ EXPORT_SYMBOL_GPL(lttng_add_vppid_to_ctx);
 MODULE_LICENSE("GPL and additional rights");
 MODULE_AUTHOR("Mathieu Desnoyers");
 MODULE_DESCRIPTION("Linux Trace Toolkit vPPID Context");
+MODULE_VERSION(__stringify(LTTNG_MODULES_MAJOR_VERSION) "."
+	__stringify(LTTNG_MODULES_MINOR_VERSION) "."
+	__stringify(LTTNG_MODULES_PATCHLEVEL_VERSION)
+	LTTNG_MODULES_EXTRAVERSION);