X-Git-Url: http://git.lttng.org/?a=blobdiff_plain;f=libust%2Ftracectl.c;h=2f9215e65b29adc0df6095ce72c206425304c559;hb=1eba9d6b2081a1e75e7f711ac02023dde773bef1;hp=0a8fc8e80f2e2d2e7bdbc3ead5df30a97d40a61f;hpb=b73a4c471dc987ea8548632dffb3c7050de77dd0;p=ust.git

diff --git a/libust/tracectl.c b/libust/tracectl.c
index 0a8fc8e..2f9215e 100644
--- a/libust/tracectl.c
+++ b/libust/tracectl.c
@@ -15,19 +15,24 @@
  * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301 USA
  */
 
+/* This file contains the implementation of the UST listener thread, which
+ * receives trace control commands. It also coordinates the initialization of
+ * libust.
+ */
+
 #define _GNU_SOURCE
 #include <stdio.h>
+#include <stdlib.h>
 #include <stdint.h>
+#include <pthread.h>
 #include <signal.h>
 #include <sys/types.h>
 #include <sys/socket.h>
 #include <sys/un.h>
-#include <sched.h>
 #include <fcntl.h>
 #include <poll.h>
 #include <regex.h>
-
-#include <urcu-bp.h>
+#include <urcu/uatomic_arch.h>
 
 #include <ust/marker.h>
 #include <ust/tracectl.h>
@@ -36,8 +41,7 @@
 #include "ustcomm.h"
 #include "buffers.h"
 #include "marker-control.h"
-
-//#define USE_CLONE
+#include "multipoll.h"
 
 #define USTSIGNAL SIGIO
 
@@ -45,13 +49,13 @@
 #define MSG_NOTIF 1
 #define MSG_REGISTER_NOTIF 2
 
-char consumer_stack[10000];
-
 /* This should only be accessed by the constructor, before the creation
  * of the listener, and then only by the listener.
  */
 s64 pidunique = -1LL;
 
+extern struct chan_info_struct chan_infos[];
+
 struct list_head blocked_consumers = LIST_HEAD_INIT(blocked_consumers);
 
 static struct ustcomm_app ustcomm_app;
@@ -62,7 +66,7 @@ struct tracecmd { /* no padding */
 };
 
 /* volatile because shared between the listener and the main thread */
-volatile sig_atomic_t buffers_to_export = 0;
+int buffers_to_export = 0;
 
 struct trctl_msg {
 	/* size: the size of all the fields except size itself */
@@ -125,37 +129,6 @@ static void print_markers(FILE *fp)
 
 static int init_socket(void);
 
-/* This needs to be called whenever a new thread is created. It notifies
- * liburcu of the new thread.
- */
-
-void ust_register_thread(void)
-{
-	rcu_register_thread();
-}
-
-int fd_notif = -1;
-void notif_cb(void)
-{
-	int result;
-	struct trctl_msg msg;
-
-	/* FIXME: fd_notif should probably be protected by a spinlock */
-
-	if(fd_notif == -1)
-		return;
-
-	msg.type = MSG_NOTIF;
-	msg.size = sizeof(msg.type);
-
-	/* FIXME: don't block here */
-	result = write(fd_notif, &msg, msg.size+sizeof(msg.size));
-	if(result == -1) {
-		PERROR("write");
-		return;
-	}
-}
-
 /* Ask the daemon to collect a trace called trace_name and being
  * produced by this pid.
  *
@@ -179,17 +152,19 @@ static void inform_consumer_daemon(const char *trace_name)
 	}
 
 	for(i=0; i < trace->nr_channels; i++) {
-		/* iterate on all cpus */
-		for(j=0; j<trace->channels[i].n_cpus; j++) {
-			char *buf;
-			asprintf(&buf, "%s_%d", trace->channels[i].channel_name, j);
-			result = ustcomm_request_consumer(pid, buf);
-			if(result == -1) {
-				WARN("Failed to request collection for channel %s. Is the daemon available?", trace->channels[i].channel_name);
-				/* continue even if fail */
+		if(trace->channels[i].request_collection) {
+			/* iterate on all cpus */
+			for(j=0; j<trace->channels[i].n_cpus; j++) {
+				char *buf;
+				asprintf(&buf, "%s_%d", trace->channels[i].channel_name, j);
+				result = ustcomm_request_consumer(pid, buf);
+				if(result == -1) {
+					WARN("Failed to request collection for channel %s. Is the daemon available?", trace->channels[i].channel_name);
+					/* continue even if fail */
+				}
+				free(buf);
+				STORE_SHARED(buffers_to_export, LOAD_SHARED(buffers_to_export)+1);
 			}
-			free(buf);
-			buffers_to_export++;
 		}
 	}
 
@@ -197,84 +172,67 @@ static void inform_consumer_daemon(const char *trace_name)
 	ltt_unlock_traces();
 }
 
-void process_blocked_consumers(void)
+int process_blkd_consumer_act(void *priv, int fd, short events)
 {
-	int n_fds = 0;
-	struct pollfd *fds;
-	struct blocked_consumer *bc;
-	int idx = 0;
-	char inbuf;
 	int result;
+	long consumed_old = 0;
+	char *reply;
+	struct blocked_consumer *bc = (struct blocked_consumer *) priv;
+	char inbuf;
 
-	list_for_each_entry(bc, &blocked_consumers, list) {
-		n_fds++;
-	}
-
-	fds = (struct pollfd *) malloc(n_fds * sizeof(struct pollfd));
-	if(fds == NULL) {
-		ERR("malloc returned NULL");
-		return;
-	}
-
-	list_for_each_entry(bc, &blocked_consumers, list) {
-		fds[idx].fd = bc->fd_producer;
-		fds[idx].events = POLLIN;
-		bc->tmp_poll_idx = idx;
-		idx++;
-	}
-
-	while((result = poll(fds, n_fds, 0)) == -1 && errno == EINTR)
-		/* nothing */;
+	result = read(bc->fd_producer, &inbuf, 1);
 	if(result == -1) {
-		PERROR("poll");
-		return;
+		PERROR("read");
+		return -1;
 	}
+	if(result == 0) {
+		int res;
+		DBG("listener: got messsage that a buffer ended");
 
-	list_for_each_entry(bc, &blocked_consumers, list) {
-		if(fds[bc->tmp_poll_idx].revents) {
-			long consumed_old = 0;
-			char *reply;
+		res = close(bc->fd_producer);
+		if(res == -1) {
+			PERROR("close");
+		}
 
-			result = read(bc->fd_producer, &inbuf, 1);
-			if(result == -1) {
-				PERROR("read");
-				continue;
-			}
-			if(result == 0) {
-				DBG("PRODUCER END");
+		list_del(&bc->list);
+
+		result = ustcomm_send_reply(&bc->server, "END", &bc->src);
+		if(result < 0) {
+			ERR("ustcomm_send_reply failed");
+			return -1;
+		}
 
-				close(bc->fd_producer);
+		return 0;
+	}
 
-				list_del(&bc->list);
+	result = ust_buffers_get_subbuf(bc->buf, &consumed_old);
+	if(result == -EAGAIN) {
+		WARN("missed buffer?");
+		return 0;
+	}
+	else if(result < 0) {
+		ERR("ust_buffers_get_subbuf: error: %s", strerror(-result));
+	}
+	asprintf(&reply, "%s %ld", "OK", consumed_old);
+	result = ustcomm_send_reply(&bc->server, reply, &bc->src);
+	if(result < 0) {
+		ERR("ustcomm_send_reply failed");
+		free(reply);
+		return -1;
+	}
+	free(reply);
 
-				result = ustcomm_send_reply(&bc->server, "END", &bc->src);
-				if(result < 0) {
-					ERR("ustcomm_send_reply failed");
-					continue;
-				}
+	list_del(&bc->list);
 
-				continue;
-			}
+	return 0;
+}
 
-			result = ust_buffers_get_subbuf(bc->buf, &consumed_old);
-			if(result == -EAGAIN) {
-				WARN("missed buffer?");
-				continue;
-			}
-			else if(result < 0) {
-				DBG("ust_buffers_get_subbuf: error: %s", strerror(-result));
-			}
-			asprintf(&reply, "%s %ld", "OK", consumed_old);
-			result = ustcomm_send_reply(&bc->server, reply, &bc->src);
-			if(result < 0) {
-				ERR("ustcomm_send_reply failed");
-				free(reply);
-				continue;
-			}
-			free(reply);
+void blocked_consumers_add_to_mp(struct mpentries *ent)
+{
+	struct blocked_consumer *bc;
 
-			list_del(&bc->list);
-		}
+	list_for_each_entry(bc, &blocked_consumers, list) {
+		multipoll_add(ent, bc->fd_producer, POLLIN, process_blkd_consumer_act, bc, NULL);
 	}
 
 }
@@ -311,13 +269,13 @@ static int do_cmd_get_shmid(const char *recvbuf, struct ustcomm_source *src)
 
 	channel_and_cpu = nth_token(recvbuf, 1);
 	if(channel_and_cpu == NULL) {
-		ERR("get_shmid: cannot parse channel");
+		ERR("cannot parse channel");
 		goto end;
 	}
 
 	seperate_channel_cpu(channel_and_cpu, &ch_name, &ch_cpu);
 	if(ch_cpu == -1) {
-		ERR("Problem parsing channel name");
+		ERR("problem parsing channel name");
 		goto free_short_chan_name;
 	}
 
@@ -344,7 +302,7 @@ static int do_cmd_get_shmid(const char *recvbuf, struct ustcomm_source *src)
 
 			result = ustcomm_send_reply(&ustcomm_app.server, reply, src);
 			if(result) {
-				ERR("listener: get_shmid: ustcomm_send_reply failed");
+				ERR("ustcomm_send_reply failed");
 				free(reply);
 				retval = -1;
 				goto free_short_chan_name;
@@ -357,11 +315,8 @@ static int do_cmd_get_shmid(const char *recvbuf, struct ustcomm_source *src)
 		}
 	}
 
-	if(found) {
-		buffers_to_export--;
-	}
-	else {
-		ERR("get_shmid: channel not found (%s)", channel_and_cpu);
+	if(!found) {
+		ERR("channel not found (%s)", channel_and_cpu);
 	}
 
 	free_short_chan_name:
@@ -387,13 +342,13 @@ static int do_cmd_get_n_subbufs(const char *recvbuf, struct ustcomm_source *src)
 
 	channel_and_cpu = nth_token(recvbuf, 1);
 	if(channel_and_cpu == NULL) {
-		ERR("get_n_subbufs: cannot parse channel");
+		ERR("cannot parse channel");
 		goto end;
 	}
 
 	seperate_channel_cpu(channel_and_cpu, &ch_name, &ch_cpu);
 	if(ch_cpu == -1) {
-		ERR("Problem parsing channel name");
+		ERR("problem parsing channel name");
 		goto free_short_chan_name;
 	}
 
@@ -418,7 +373,7 @@ static int do_cmd_get_n_subbufs(const char *recvbuf, struct ustcomm_source *src)
 
 			result = ustcomm_send_reply(&ustcomm_app.server, reply, src);
 			if(result) {
-				ERR("listener: get_n_subbufs: ustcomm_send_reply failed");
+				ERR("ustcomm_send_reply failed");
 				free(reply);
 				retval = -1;
 				goto free_short_chan_name;
@@ -430,7 +385,7 @@ static int do_cmd_get_n_subbufs(const char *recvbuf, struct ustcomm_source *src)
 		}
 	}
 	if(found == 0) {
-		ERR("get_n_subbufs: unable to find channel");
+		ERR("unable to find channel");
 	}
 
 	free_short_chan_name:
@@ -456,13 +411,13 @@ static int do_cmd_get_subbuf_size(const char *recvbuf, struct ustcomm_source *sr
 
 	channel_and_cpu = nth_token(recvbuf, 1);
 	if(channel_and_cpu == NULL) {
-		ERR("get_subbuf_size: cannot parse channel");
+		ERR("cannot parse channel");
 		goto end;
 	}
 
 	seperate_channel_cpu(channel_and_cpu, &ch_name, &ch_cpu);
 	if(ch_cpu == -1) {
-		ERR("Problem parsing channel name");
+		ERR("problem parsing channel name");
 		goto free_short_chan_name;
 	}
 
@@ -487,7 +442,7 @@ static int do_cmd_get_subbuf_size(const char *recvbuf, struct ustcomm_source *sr
 
 			result = ustcomm_send_reply(&ustcomm_app.server, reply, src);
 			if(result) {
-				ERR("listener: get_subbuf_size: ustcomm_send_reply failed");
+				ERR("ustcomm_send_reply failed");
 				free(reply);
 				retval = -1;
 				goto free_short_chan_name;
@@ -499,7 +454,7 @@ static int do_cmd_get_subbuf_size(const char *recvbuf, struct ustcomm_source *sr
 		}
 	}
 	if(found == 0) {
-		ERR("get_subbuf_size: unable to find channel");
+		ERR("unable to find channel");
 	}
 
 	free_short_chan_name:
@@ -509,6 +464,129 @@ static int do_cmd_get_subbuf_size(const char *recvbuf, struct ustcomm_source *sr
 	return retval;
 }
 
+/* Return the power of two which is equal or higher to v */
+
+static unsigned int pow2_higher_or_eq(unsigned int v)
+{
+	int hb = fls(v);
+	int hbm1 = hb-1;
+	int retval = 1<<(hb-1);
+
+	if(v-retval == 0)
+		return retval;
+	else
+		return retval<<1;
+}
+
+static int do_cmd_set_subbuf_size(const char *recvbuf, struct ustcomm_source *src)
+{
+	char *channel_slash_size;
+	char ch_name[256]="";
+	unsigned int size, power;
+	int retval = 0;
+	struct ust_trace *trace;
+	char trace_name[] = "auto";
+	int i;
+	int found = 0;
+
+	DBG("set_subbuf_size");
+
+	channel_slash_size = nth_token(recvbuf, 1);
+	sscanf(channel_slash_size, "%255[^/]/%u", ch_name, &size);
+
+	if(ch_name == NULL) {
+		ERR("cannot parse channel");
+		goto end;
+	}
+
+	power = pow2_higher_or_eq(size);
+	power = max_t(unsigned int, 2u, power);
+	if (power != size)
+		WARN("using the next power of two for buffer size = %u\n", power);
+
+	ltt_lock_traces();
+	trace = _ltt_trace_find_setup(trace_name);
+	if(trace == NULL) {
+		ERR("cannot find trace!");
+		retval = -1;
+		goto end;
+	}
+
+	for(i = 0; i < trace->nr_channels; i++) {
+		struct ust_channel *channel = &trace->channels[i];
+
+		if(!strcmp(trace->channels[i].channel_name, ch_name)) {
+
+			channel->subbuf_size = power;
+			DBG("the set_subbuf_size for the requested channel is %zd", channel->subbuf_size);
+
+			found = 1;
+			break;
+		}
+	}
+	if(found == 0) {
+		ERR("unable to find channel");
+	}
+
+	end:
+	ltt_unlock_traces();
+	return retval;
+}
+
+static int do_cmd_set_subbuf_num(const char *recvbuf, struct ustcomm_source *src)
+{
+	char *channel_slash_num;
+	char ch_name[256]="";
+	unsigned int num;
+	int retval = 0;
+	struct ust_trace *trace;
+	char trace_name[] = "auto";
+	int i;
+	int found = 0;
+
+	DBG("set_subbuf_num");
+
+	channel_slash_num = nth_token(recvbuf, 1);
+	sscanf(channel_slash_num, "%255[^/]/%u", ch_name, &num);
+
+	if(ch_name == NULL) {
+		ERR("cannot parse channel");
+		goto end;
+	}
+	if (num < 2) {
+		ERR("subbuffer count should be greater than 2");
+		goto end;
+	}
+
+	ltt_lock_traces();
+	trace = _ltt_trace_find_setup(trace_name);
+	if(trace == NULL) {
+		ERR("cannot find trace!");
+		retval = -1;
+		goto end;
+	}
+
+	for(i = 0; i < trace->nr_channels; i++) {
+		struct ust_channel *channel = &trace->channels[i];
+
+		if(!strcmp(trace->channels[i].channel_name, ch_name)) {
+
+			channel->subbuf_cnt = num;
+			DBG("the set_subbuf_cnt for the requested channel is %zd", channel->subbuf_cnt);
+
+			found = 1;
+			break;
+		}
+	}
+	if(found == 0) {
+		ERR("unable to find channel");
+	}
+
+	end:
+	ltt_unlock_traces();
+	return retval;
+}
+
 static int do_cmd_get_subbuffer(const char *recvbuf, struct ustcomm_source *src)
 {
 	int retval = 0;
@@ -524,24 +602,31 @@ static int do_cmd_get_subbuffer(const char *recvbuf, struct ustcomm_source *src)
 
 	channel_and_cpu = nth_token(recvbuf, 1);
 	if(channel_and_cpu == NULL) {
-		ERR("get_subbuf: cannot parse channel");
+		ERR("cannot parse channel");
 		goto end;
 	}
 
 	seperate_channel_cpu(channel_and_cpu, &ch_name, &ch_cpu);
 	if(ch_cpu == -1) {
-		ERR("Problem parsing channel name");
+		ERR("problem parsing channel name");
 		goto free_short_chan_name;
 	}
 
 	ltt_lock_traces();
 	trace = _ltt_trace_find(trace_name);
-	ltt_unlock_traces();
 
 	if(trace == NULL) {
-		ERR("cannot find trace!");
-		retval = -1;
-		goto free_short_chan_name;
+		int result;
+
+		DBG("Cannot find trace. It was likely destroyed by the user.");
+		result = ustcomm_send_reply(&ustcomm_app.server, "NOTFOUND", src);
+		if(result) {
+			ERR("ustcomm_send_reply failed");
+			retval = -1;
+			goto unlock_traces;
+		}
+
+		goto unlock_traces;
 	}
 
 	for(i=0; i<trace->nr_channels; i++) {
@@ -556,7 +641,7 @@ static int do_cmd_get_subbuffer(const char *recvbuf, struct ustcomm_source *src)
 			bc = (struct blocked_consumer *) malloc(sizeof(struct blocked_consumer));
 			if(bc == NULL) {
 				ERR("malloc returned NULL");
-				goto free_short_chan_name;
+				goto unlock_traces;
 			}
 			bc->fd_consumer = src->fd;
 			bc->fd_producer = buf->data_ready_fd_read;
@@ -566,13 +651,24 @@ static int do_cmd_get_subbuffer(const char *recvbuf, struct ustcomm_source *src)
 
 			list_add(&bc->list, &blocked_consumers);
 
+			/* Being here is the proof the daemon has mapped the buffer in its
+			 * memory. We may now decrement buffers_to_export.
+			 */
+			if(uatomic_read(&buf->consumed) == 0) {
+				DBG("decrementing buffers_to_export");
+				STORE_SHARED(buffers_to_export, LOAD_SHARED(buffers_to_export)-1);
+			}
+
 			break;
 		}
 	}
 	if(found == 0) {
-		ERR("get_subbuf: unable to find channel");
+		ERR("unable to find channel");
 	}
 
+	unlock_traces:
+	ltt_unlock_traces();
+
 	free_short_chan_name:
 	free(ch_name);
 
@@ -594,44 +690,50 @@ static int do_cmd_put_subbuffer(const char *recvbuf, struct ustcomm_source *src)
 	long consumed_old;
 	char *consumed_old_str;
 	char *endptr;
+	char *reply = NULL;
 
 	DBG("put_subbuf");
 
-	channel_and_cpu = strdup_malloc(nth_token(recvbuf, 1));
+	channel_and_cpu = strdup(nth_token(recvbuf, 1));
 	if(channel_and_cpu == NULL) {
-		ERR("put_subbuf_size: cannot parse channel");
+		ERR("cannot parse channel");
 		retval = -1;
 		goto end;
 	}
 
-	consumed_old_str = strdup_malloc(nth_token(recvbuf, 2));
+	consumed_old_str = strdup(nth_token(recvbuf, 2));
 	if(consumed_old_str == NULL) {
-		ERR("put_subbuf: cannot parse consumed_old");
+		ERR("cannot parse consumed_old");
 		retval = -1;
 		goto free_channel_and_cpu;
 	}
 	consumed_old = strtol(consumed_old_str, &endptr, 10);
 	if(*endptr != '\0') {
-		ERR("put_subbuf: invalid value for consumed_old");
+		ERR("invalid value for consumed_old");
 		retval = -1;
 		goto free_consumed_old_str;
 	}
 
 	seperate_channel_cpu(channel_and_cpu, &ch_name, &ch_cpu);
 	if(ch_cpu == -1) {
-		ERR("Problem parsing channel name");
+		ERR("problem parsing channel name");
 		retval = -1;
 		goto free_short_chan_name;
 	}
 
 	ltt_lock_traces();
 	trace = _ltt_trace_find(trace_name);
-	ltt_unlock_traces();
 
 	if(trace == NULL) {
-		ERR("cannot find trace!");
-		retval = -1;
-		goto free_short_chan_name;
+		DBG("Cannot find trace. It was likely destroyed by the user.");
+		result = ustcomm_send_reply(&ustcomm_app.server, "NOTFOUND", src);
+		if(result) {
+			ERR("ustcomm_send_reply failed");
+			retval = -1;
+			goto unlock_traces;
+		}
+
+		goto unlock_traces;
 	}
 
 	for(i=0; i<trace->nr_channels; i++) {
@@ -639,8 +741,6 @@ static int do_cmd_put_subbuffer(const char *recvbuf, struct ustcomm_source *src)
 
 		if(!strcmp(trace->channels[i].channel_name, ch_name)) {
 			struct ust_buffer *buf = channel->buf[ch_cpu];
-			char *reply;
-			long consumed_old=0;
 
 			found = 1;
 
@@ -656,10 +756,10 @@ static int do_cmd_put_subbuffer(const char *recvbuf, struct ustcomm_source *src)
 
 			result = ustcomm_send_reply(&ustcomm_app.server, reply, src);
 			if(result) {
-				ERR("listener: put_subbuf: ustcomm_send_reply failed");
+				ERR("ustcomm_send_reply failed");
 				free(reply);
 				retval = -1;
-				goto free_channel_and_cpu;
+				goto unlock_traces;
 			}
 
 			free(reply);
@@ -667,322 +767,309 @@ static int do_cmd_put_subbuffer(const char *recvbuf, struct ustcomm_source *src)
 		}
 	}
 	if(found == 0) {
-		ERR("get_subbuf_size: unable to find channel");
+		ERR("unable to find channel");
 	}
 
-	free_channel_and_cpu:
-	free(channel_and_cpu);
-	free_consumed_old_str:
-	free(consumed_old_str);
+	unlock_traces:
+	ltt_unlock_traces();
 	free_short_chan_name:
 	free(ch_name);
+	free_consumed_old_str:
+	free(consumed_old_str);
+	free_channel_and_cpu:
+	free(channel_and_cpu);
 
 	end:
 	return retval;
 }
 
-void *listener_main(void *p)
+static void listener_cleanup(void *ptr)
+{
+	ustcomm_fini_app(&ustcomm_app, 0);
+}
+
+int process_client_cmd(char *recvbuf, struct ustcomm_source *src)
 {
 	int result;
+	char trace_name[] = "auto";
+	char trace_type[] = "ustrelay";
+	int len;
 
-	ust_register_thread();
+	DBG("received a message! it's: %s", recvbuf);
+	len = strlen(recvbuf);
 
-	DBG("LISTENER");
+	if(!strcmp(recvbuf, "print_markers")) {
+		print_markers(stderr);
+	}
+	else if(!strcmp(recvbuf, "list_markers")) {
+		char *ptr;
+		size_t size;
+		FILE *fp;
 
-	for(;;) {
-		char trace_name[] = "auto";
-		char trace_type[] = "ustrelay";
-		char *recvbuf;
-		int len;
-		struct ustcomm_source src;
+		fp = open_memstream(&ptr, &size);
+		print_markers(fp);
+		fclose(fp);
 
-		process_blocked_consumers();
+		result = ustcomm_send_reply(&ustcomm_app.server, ptr, src);
 
-		result = ustcomm_app_recv_message(&ustcomm_app, &recvbuf, &src, 5);
+		free(ptr);
+	}
+	else if(!strcmp(recvbuf, "start")) {
+		/* start is an operation that setups the trace, allocates it and starts it */
+		result = ltt_trace_setup(trace_name);
 		if(result < 0) {
-			WARN("error in ustcomm_app_recv_message");
-			continue;
+			ERR("ltt_trace_setup failed");
+			return -1;
 		}
-		else if(result == 0) {
-			/* no message */
-			continue;
+
+		result = ltt_trace_set_type(trace_name, trace_type);
+		if(result < 0) {
+			ERR("ltt_trace_set_type failed");
+			return -1;
 		}
 
-		DBG("received a message! it's: %s", recvbuf);
-		len = strlen(recvbuf);
+		result = ltt_trace_alloc(trace_name);
+		if(result < 0) {
+			ERR("ltt_trace_alloc failed");
+			return -1;
+		}
 
-		if(!strcmp(recvbuf, "print_markers")) {
-			print_markers(stderr);
+		inform_consumer_daemon(trace_name);
+
+		result = ltt_trace_start(trace_name);
+		if(result < 0) {
+			ERR("ltt_trace_start failed");
+			return -1;
 		}
-		else if(!strcmp(recvbuf, "list_markers")) {
-			char *ptr;
-			size_t size;
-			FILE *fp;
+	}
+	else if(!strcmp(recvbuf, "trace_setup")) {
+		DBG("trace setup");
 
-			fp = open_memstream(&ptr, &size);
-			print_markers(fp);
-			fclose(fp);
+		result = ltt_trace_setup(trace_name);
+		if(result < 0) {
+			ERR("ltt_trace_setup failed");
+			return -1;
+		}
 
-			result = ustcomm_send_reply(&ustcomm_app.server, ptr, &src);
+		result = ltt_trace_set_type(trace_name, trace_type);
+		if(result < 0) {
+			ERR("ltt_trace_set_type failed");
+			return -1;
+		}
+	}
+	else if(!strcmp(recvbuf, "trace_alloc")) {
+		DBG("trace alloc");
 
-			free(ptr);
+		result = ltt_trace_alloc(trace_name);
+		if(result < 0) {
+			ERR("ltt_trace_alloc failed");
+			return -1;
 		}
-		else if(!strcmp(recvbuf, "start")) {
-			/* start is an operation that setups the trace, allocates it and starts it */
-			result = ltt_trace_setup(trace_name);
-			if(result < 0) {
-				ERR("ltt_trace_setup failed");
-				return (void *)1;
-			}
+		inform_consumer_daemon(trace_name);
+	}
+	else if(!strcmp(recvbuf, "trace_create")) {
+		DBG("trace create");
 
-			result = ltt_trace_set_type(trace_name, trace_type);
-			if(result < 0) {
-				ERR("ltt_trace_set_type failed");
-				return (void *)1;
-			}
+		result = ltt_trace_setup(trace_name);
+		if(result < 0) {
+			ERR("ltt_trace_setup failed");
+			return -1;
+		}
 
-			result = ltt_trace_alloc(trace_name);
-			if(result < 0) {
-				ERR("ltt_trace_alloc failed");
-				return (void *)1;
-			}
+		result = ltt_trace_set_type(trace_name, trace_type);
+		if(result < 0) {
+			ERR("ltt_trace_set_type failed");
+			return -1;
+		}
+	}
+	else if(!strcmp(recvbuf, "trace_start")) {
+		DBG("trace start");
 
+		result = ltt_trace_alloc(trace_name);
+		if(result < 0) {
+			ERR("ltt_trace_alloc failed");
+			return -1;
+		}
+		if(!result) {
 			inform_consumer_daemon(trace_name);
-
-			result = ltt_trace_start(trace_name);
-			if(result < 0) {
-				ERR("ltt_trace_start failed");
-				continue;
-			}
 		}
-		else if(!strcmp(recvbuf, "trace_setup")) {
-			DBG("trace setup");
 
-			result = ltt_trace_setup(trace_name);
-			if(result < 0) {
-				ERR("ltt_trace_setup failed");
-				return (void *)1;
-			}
+		result = ltt_trace_start(trace_name);
+		if(result < 0) {
+			ERR("ltt_trace_start failed");
+			return -1;
+		}
+	}
+	else if(!strcmp(recvbuf, "trace_stop")) {
+		DBG("trace stop");
 
-			result = ltt_trace_set_type(trace_name, trace_type);
-			if(result < 0) {
-				ERR("ltt_trace_set_type failed");
-				return (void *)1;
-			}
+		result = ltt_trace_stop(trace_name);
+		if(result < 0) {
+			ERR("ltt_trace_stop failed");
+			return -1;
 		}
-		else if(!strcmp(recvbuf, "trace_alloc")) {
-			DBG("trace alloc");
+	}
+	else if(!strcmp(recvbuf, "trace_destroy")) {
 
-			result = ltt_trace_alloc(trace_name);
-			if(result < 0) {
-				ERR("ltt_trace_alloc failed");
-				return (void *)1;
-			}
+		DBG("trace destroy");
+
+		result = ltt_trace_destroy(trace_name, 0);
+		if(result < 0) {
+			ERR("ltt_trace_destroy failed");
+			return -1;
 		}
-		else if(!strcmp(recvbuf, "trace_create")) {
-			DBG("trace create");
+	}
+	else if(nth_token_is(recvbuf, "get_shmid", 0) == 1) {
+		do_cmd_get_shmid(recvbuf, src);
+	}
+	else if(nth_token_is(recvbuf, "get_n_subbufs", 0) == 1) {
+		do_cmd_get_n_subbufs(recvbuf, src);
+	}
+	else if(nth_token_is(recvbuf, "get_subbuf_size", 0) == 1) {
+		do_cmd_get_subbuf_size(recvbuf, src);
+	}
+	else if(nth_token_is(recvbuf, "load_probe_lib", 0) == 1) {
+		char *libfile;
 
-			result = ltt_trace_setup(trace_name);
-			if(result < 0) {
-				ERR("ltt_trace_setup failed");
-				return (void *)1;
-			}
+		libfile = nth_token(recvbuf, 1);
 
-			result = ltt_trace_set_type(trace_name, trace_type);
-			if(result < 0) {
-				ERR("ltt_trace_set_type failed");
-				return (void *)1;
-			}
+		DBG("load_probe_lib loading %s", libfile);
 
-			result = ltt_trace_alloc(trace_name);
-			if(result < 0) {
-				ERR("ltt_trace_alloc failed");
-				return (void *)1;
-			}
+		free(libfile);
+	}
+	else if(nth_token_is(recvbuf, "get_subbuffer", 0) == 1) {
+		do_cmd_get_subbuffer(recvbuf, src);
+	}
+	else if(nth_token_is(recvbuf, "put_subbuffer", 0) == 1) {
+		do_cmd_put_subbuffer(recvbuf, src);
+	}
+	else if(nth_token_is(recvbuf, "set_subbuf_size", 0) == 1) {
+		do_cmd_set_subbuf_size(recvbuf, src);
+	}
+	else if(nth_token_is(recvbuf, "set_subbuf_num", 0) == 1) {
+		do_cmd_set_subbuf_num(recvbuf, src);
+	}
+	else if(nth_token_is(recvbuf, "enable_marker", 0) == 1) {
+		char *channel_slash_name = nth_token(recvbuf, 1);
+		char channel_name[256]="";
+		char marker_name[256]="";
 
-			inform_consumer_daemon(trace_name);
-		}
-		else if(!strcmp(recvbuf, "trace_start")) {
-			DBG("trace start");
+		result = sscanf(channel_slash_name, "%255[^/]/%255s", channel_name, marker_name);
 
-			result = ltt_trace_start(trace_name);
-			if(result < 0) {
-				ERR("ltt_trace_start failed");
-				continue;
-			}
+		if(channel_name == NULL || marker_name == NULL) {
+			WARN("invalid marker name");
+			goto next_cmd;
 		}
-		else if(!strcmp(recvbuf, "trace_stop")) {
-			DBG("trace stop");
 
-			result = ltt_trace_stop(trace_name);
-			if(result < 0) {
-				ERR("ltt_trace_stop failed");
-				return (void *)1;
-			}
+		result = ltt_marker_connect(channel_name, marker_name, "default");
+		if(result < 0) {
+			WARN("could not enable marker; channel=%s, name=%s", channel_name, marker_name);
 		}
-		else if(!strcmp(recvbuf, "trace_destroy")) {
+	}
+	else if(nth_token_is(recvbuf, "disable_marker", 0) == 1) {
+		char *channel_slash_name = nth_token(recvbuf, 1);
+		char *marker_name;
+		char *channel_name;
 
-			DBG("trace destroy");
+		result = sscanf(channel_slash_name, "%a[^/]/%as", &channel_name, &marker_name);
 
-			result = ltt_trace_destroy(trace_name);
-			if(result < 0) {
-				ERR("ltt_trace_destroy failed");
-				return (void *)1;
-			}
-		}
-		else if(nth_token_is(recvbuf, "get_shmid", 0) == 1) {
-			do_cmd_get_shmid(recvbuf, &src);
-		}
-		else if(nth_token_is(recvbuf, "get_n_subbufs", 0) == 1) {
-			do_cmd_get_n_subbufs(recvbuf, &src);
+		if(marker_name == NULL) {
 		}
-		else if(nth_token_is(recvbuf, "get_subbuf_size", 0) == 1) {
-			do_cmd_get_subbuf_size(recvbuf, &src);
-		}
-		else if(nth_token_is(recvbuf, "load_probe_lib", 0) == 1) {
-			char *libfile;
 
-			libfile = nth_token(recvbuf, 1);
+		result = ltt_marker_disconnect(channel_name, marker_name, "default");
+		if(result < 0) {
+			WARN("could not disable marker; channel=%s, name=%s", channel_name, marker_name);
+		}
+	}
+	else if(nth_token_is(recvbuf, "get_pidunique", 0) == 1) {
+		char *reply;
 
-			DBG("load_probe_lib loading %s", libfile);
+		asprintf(&reply, "%lld", pidunique);
 
-			free(libfile);
-		}
-		else if(nth_token_is(recvbuf, "get_subbuffer", 0) == 1) {
-			do_cmd_get_subbuffer(recvbuf, &src);
-		}
-		else if(nth_token_is(recvbuf, "put_subbuffer", 0) == 1) {
-			do_cmd_put_subbuffer(recvbuf, &src);
+		result = ustcomm_send_reply(&ustcomm_app.server, reply, src);
+		if(result) {
+			ERR("listener: get_pidunique: ustcomm_send_reply failed");
+			goto next_cmd;
 		}
-		else if(nth_token_is(recvbuf, "enable_marker", 0) == 1) {
-			char *channel_slash_name = nth_token(recvbuf, 1);
-			char channel_name[256]="";
-			char marker_name[256]="";
 
-			result = sscanf(channel_slash_name, "%255[^/]/%255s", channel_name, marker_name);
+		free(reply);
+	}
+	else {
+		ERR("unable to parse message: %s", recvbuf);
+	}
 
-			if(channel_name == NULL || marker_name == NULL) {
-				WARN("invalid marker name");
-				goto next_cmd;
-			}
+next_cmd:
 
-			result = ltt_marker_connect(channel_name, marker_name, "default");
-			if(result < 0) {
-				WARN("could not enable marker; channel=%s, name=%s", channel_name, marker_name);
-			}
-		}
-		else if(nth_token_is(recvbuf, "disable_marker", 0) == 1) {
-			char *channel_slash_name = nth_token(recvbuf, 1);
-			char *marker_name;
-			char *channel_name;
+	return 0;
+}
 
-			result = sscanf(channel_slash_name, "%a[^/]/%as", &channel_name, &marker_name);
+void *listener_main(void *p)
+{
+	int result;
 
-			if(marker_name == NULL) {
-			}
+	DBG("LISTENER");
 
-			result = ltt_marker_disconnect(channel_name, marker_name, "default");
-			if(result < 0) {
-				WARN("could not disable marker; channel=%s, name=%s", channel_name, marker_name);
-			}
-		}
-		else if(nth_token_is(recvbuf, "get_pidunique", 0) == 1) {
-			char *reply;
+	pthread_cleanup_push(listener_cleanup, NULL);
 
-			asprintf(&reply, "%lld", pidunique);
+	for(;;) {
+		struct mpentries mpent;
 
-			result = ustcomm_send_reply(&ustcomm_app.server, reply, &src);
-			if(result) {
-				ERR("listener: get_pidunique: ustcomm_send_reply failed");
-				goto next_cmd;
-			}
+		multipoll_init(&mpent);
 
-			free(reply);
-		}
-//		else if(nth_token_is(recvbuf, "get_notifications", 0) == 1) {
-//			struct ust_trace *trace;
-//			char trace_name[] = "auto";
-//			int i;
-//			char *channel_name;
-//
-//			DBG("get_notifications");
-//
-//			channel_name = strdup_malloc(nth_token(recvbuf, 1));
-//			if(channel_name == NULL) {
-//				ERR("put_subbuf_size: cannot parse channel");
-//				goto next_cmd;
-//			}
-//
-//			ltt_lock_traces();
-//			trace = _ltt_trace_find(trace_name);
-//			ltt_unlock_traces();
-//
-//			if(trace == NULL) {
-//				ERR("cannot find trace!");
-//				return (void *)1;
-//			}
-//
-//			for(i=0; i<trace->nr_channels; i++) {
-//				struct rchan *rchan = trace->channels[i].trans_channel_data;
-//				int fd;
-//
-//				if(!strcmp(trace->channels[i].channel_name, channel_name)) {
-//					struct rchan_buf *rbuf = rchan->buf;
-//					struct ltt_channel_buf_struct *lttbuf = trace->channels[i].buf;
-//
-//					result = fd = ustcomm_app_detach_client(&ustcomm_app, &src);
-//					if(result == -1) {
-//						ERR("ustcomm_app_detach_client failed");
-//						goto next_cmd;
-//					}
-//
-//					lttbuf->wake_consumer_arg = (void *) fd;
-//
-//					smp_wmb();
-//
-//					lttbuf->call_wake_consumer = 1;
-//
-//					break;
-//				}
-//			}
-//
-//			free(channel_name);
-//		}
-		else {
-			ERR("unable to parse message: %s", recvbuf);
+		blocked_consumers_add_to_mp(&mpent);
+		ustcomm_mp_add_app_clients(&mpent, &ustcomm_app, process_client_cmd);
+
+		result = multipoll_poll(&mpent, -1);
+		if(result == -1) {
+			ERR("error in multipoll_poll");
 		}
 
-	next_cmd:
-		free(recvbuf);
+		multipoll_destroy(&mpent);
 	}
+
+	pthread_cleanup_pop(1);
 }
 
-volatile sig_atomic_t have_listener = 0;
+/* These should only be accessed in the parent thread,
+ * not the listener.
+ */
+static volatile sig_atomic_t have_listener = 0;
+static pthread_t listener_thread;
 
 void create_listener(void)
 {
-#ifdef USE_CLONE
-	static char listener_stack[16384];
 	int result;
-#else
-	pthread_t thread;
-#endif
+	sigset_t sig_all_blocked;
+	sigset_t orig_parent_mask;
 
 	if(have_listener) {
 		WARN("not creating listener because we already had one");
 		return;
 	}
 
-#ifdef USE_CLONE
-	result = clone((int (*)(void *)) listener_main, listener_stack+sizeof(listener_stack)-1, CLONE_FS | CLONE_FILES | CLONE_VM | CLONE_SIGHAND | CLONE_THREAD, NULL);
+	/* A new thread created by pthread_create inherits the signal mask
+	 * from the parent. To avoid any signal being received by the
+	 * listener thread, we block all signals temporarily in the parent,
+	 * while we create the listener thread.
+	 */
+
+	sigfillset(&sig_all_blocked);
+
+	result = pthread_sigmask(SIG_SETMASK, &sig_all_blocked, &orig_parent_mask);
+	if(result) {
+		PERROR("pthread_sigmask: %s", strerror(result));
+	}
+
+	result = pthread_create(&listener_thread, NULL, listener_main, NULL);
 	if(result == -1) {
-		perror("clone");
-		return;
+		PERROR("pthread_create");
 	}
-#else
 
-	pthread_create(&thread, NULL, listener_main, NULL);
-#endif
+	/* Restore original signal mask in parent */
+	result = pthread_sigmask(SIG_SETMASK, &orig_parent_mask, NULL);
+	if(result) {
+		PERROR("pthread_sigmask: %s", strerror(result));
+	}
 
 	have_listener = 1;
 }
@@ -1034,22 +1121,19 @@ static void __attribute__((constructor)) init()
 {
 	int result;
 	char* autoprobe_val = NULL;
+	char* subbuffer_size_val = NULL;
+	char* subbuffer_count_val = NULL;
+	unsigned int subbuffer_size;
+	unsigned int subbuffer_count;
+	unsigned int power;
 
 	/* Assign the pidunique, to be able to differentiate the processes with same
 	 * pid, (before and after an exec).
 	 */
 	pidunique = make_pidunique();
 
-	/* Initialize RCU in case the constructor order is not good. */
-	rcu_init();
-
-	/* It is important to do this before events start to be generated. */
-	ust_register_thread();
-
 	DBG("Tracectl constructor");
 
-	/* Must create socket before signal handler to prevent races.
-         */
 	result = init_socket();
 	if(result == -1) {
 		ERR("init_socket error");
@@ -1105,6 +1189,43 @@ static void __attribute__((constructor)) init()
 		}
 	}
 
+	if(getenv("UST_OVERWRITE")) {
+		int val = atoi(getenv("UST_OVERWRITE"));
+		if(val == 0 || val == 1) {
+			STORE_SHARED(ust_channels_overwrite_by_default, val);
+		}
+		else {
+			WARN("invalid value for UST_OVERWRITE");
+		}
+	}
+
+	if(getenv("UST_AUTOCOLLECT")) {
+		int val = atoi(getenv("UST_AUTOCOLLECT"));
+		if(val == 0 || val == 1) {
+			STORE_SHARED(ust_channels_request_collection_by_default, val);
+		}
+		else {
+			WARN("invalid value for UST_AUTOCOLLECT");
+		}
+	}
+
+	subbuffer_size_val = getenv("UST_SUBBUF_SIZE");
+	if(subbuffer_size_val) {
+		sscanf(subbuffer_size_val, "%u", &subbuffer_size);
+		power = pow2_higher_or_eq(subbuffer_size);
+		if(power != subbuffer_size)
+			WARN("using the next power of two for buffer size = %u\n", power);
+		chan_infos[LTT_CHANNEL_UST].def_subbufsize = power;
+	}
+
+	subbuffer_count_val = getenv("UST_SUBBUF_NUM");
+	if(subbuffer_count_val) {
+		sscanf(subbuffer_count_val, "%u", &subbuffer_count);
+		if(subbuffer_count < 2)
+			subbuffer_count = 2;
+		chan_infos[LTT_CHANNEL_UST].def_subbufcount = subbuffer_count;
+	}
+
 	if(getenv("UST_TRACE")) {
 		char trace_name[] = "auto";
 		char trace_type[] = "ustrelay";
@@ -1117,6 +1238,11 @@ static void __attribute__((constructor)) init()
 		/* Ensure markers are initialized */
 		init_markers();
 
+		/* Ensure buffers are initialized, for the transport to be available.
+		 * We are about to set a trace type and it will fail without this.
+		 */
+		init_ustrelay_transport();
+
 		/* FIXME: When starting early tracing (here), depending on the
 		 * order of constructors, it is very well possible some marker
 		 * sections are not yet registered. Because of this, some
@@ -1166,7 +1292,6 @@ static void __attribute__((constructor)) init()
 		inform_consumer_daemon(trace_name);
 	}
 
-
 	return;
 
 	/* should decrementally destroy stuff if error */
@@ -1197,7 +1322,7 @@ static void destroy_traces(void)
 		ERR("ltt_trace_stop error");
 	}
 
-	result = ltt_trace_destroy("auto");
+	result = ltt_trace_destroy("auto", 0);
 	if(result == -1) {
 		ERR("ltt_trace_destroy error");
 	}
@@ -1244,6 +1369,20 @@ int restarting_usleep(useconds_t usecs)
 	return result;
 }
 
+static void stop_listener()
+{
+	int result;
+
+	result = pthread_cancel(listener_thread);
+	if(result != 0) {
+		ERR("pthread_cancel: %s", strerror(result));
+	}
+	result = pthread_join(listener_thread, NULL);
+	if(result != 0) {
+		ERR("pthread_join: %s", strerror(result));
+	}
+}
+
 /* This destructor keeps the process alive for a few seconds in order
  * to leave time to ustd to connect to its buffers. This is necessary
  * for programs whose execution is very short. It is also useful in all
@@ -1256,10 +1395,10 @@ int restarting_usleep(useconds_t usecs)
 
 static void __attribute__((destructor)) keepalive()
 {
-	if(trace_recording() && buffers_to_export) {
+	if(trace_recording() && LOAD_SHARED(buffers_to_export)) {
 		int total = 0;
 		DBG("Keeping process alive for consumer daemon...");
-		while(buffers_to_export) {
+		while(LOAD_SHARED(buffers_to_export)) {
 			const int interv = 200000;
 			restarting_usleep(interv);
 			total += interv;
@@ -1274,7 +1413,8 @@ static void __attribute__((destructor)) keepalive()
 
 	destroy_traces();
 
-	ustcomm_fini_app(&ustcomm_app);
+	/* Ask the listener to stop and clean up. */
+	stop_listener();
 }
 
 void ust_potential_exec(void)
@@ -1302,24 +1442,35 @@ static void ust_fork(void)
 	struct blocked_consumer *deletable_bc = NULL;
 	int result;
 
+	/* FIXME: technically, the locks could have been taken before the fork */
 	DBG("ust: forking");
+
+	/* break lock if necessary */
+	ltt_unlock_traces();
+
 	ltt_trace_stop("auto");
-	ltt_trace_destroy("auto");
+	ltt_trace_destroy("auto", 1);
 	/* Delete all active connections */
 	ustcomm_close_all_connections(&ustcomm_app.server);
 
 	/* Delete all blocked consumers */
 	list_for_each_entry(bc, &blocked_consumers, list) {
-		close(bc->fd_producer);
-		close(bc->fd_consumer);
+		result = close(bc->fd_producer);
+		if(result == -1) {
+			PERROR("close");
+		}
 		free(deletable_bc);
 		deletable_bc = bc;
 		list_del(&bc->list);
 	}
 
+	/* free app, keeping socket file */
+	ustcomm_fini_app(&ustcomm_app, 1);
+
+	STORE_SHARED(buffers_to_export, 0);
 	have_listener = 0;
-	create_listener();
 	init_socket();
+	create_listener();
 	ltt_trace_setup("auto");
 	result = ltt_trace_set_type("auto", "ustrelay");
 	if(result < 0) {