Close stream and channel file descriptors as soon as passed to sessiond
[lttng-ust.git] / liblttng-ust / ltt-events.c
index e3fd3f79fdd9bb913a3f01987866a4c08e57ee7d..ee88b43142d6e39c57f974102ba45328a7aef210 100644 (file)
@@ -75,6 +75,7 @@ struct ust_pending_probe {
 
 static void _ltt_event_destroy(struct ltt_event *event);
 static void _ltt_loglevel_destroy(struct session_loglevel *sl);
+static void _ltt_wildcard_destroy(struct session_wildcard *sw);
 static void _ltt_channel_destroy(struct ltt_channel *chan);
 static int _ltt_event_unregister(struct ltt_event *event);
 static
@@ -93,14 +94,20 @@ int add_pending_probe(struct ltt_event *event, const char *name)
 {
        struct cds_hlist_head *head;
        struct ust_pending_probe *e;
-       size_t name_len = strlen(name) + 1;
-       uint32_t hash = jhash(name, name_len - 1, 0);
+       size_t name_len = strlen(name);
+       uint32_t hash;
 
+       if (name_len > LTTNG_UST_SYM_NAME_LEN - 1) {
+               WARN("Truncating tracepoint name %s which exceeds size limits of %u chars", name, LTTNG_UST_SYM_NAME_LEN - 1);
+               name_len = LTTNG_UST_SYM_NAME_LEN - 1;
+       }
+       hash = jhash(name, name_len, 0);
        head = &pending_probe_table[hash & (PENDING_PROBE_HASH_SIZE - 1)];
        e = zmalloc(sizeof(struct ust_pending_probe) + name_len);
        if (!e)
                return -ENOMEM;
-       memcpy(&e->name[0], name, name_len);
+       memcpy(&e->name[0], name, name_len + 1);
+       e->name[name_len] = '\0';
        cds_hlist_add_head(&e->node, head);
        e->event = event;
        event->pending_probe = e;
@@ -132,9 +139,10 @@ int pending_probe_fix_events(const struct lttng_event_desc *desc)
        struct cds_hlist_node *node, *p;
        struct ust_pending_probe *e;
        const char *name = desc->name;
-       size_t name_len = strlen(name) + 1;
-       uint32_t hash = jhash(name, name_len - 1, 0);
        int ret = 0;
+       struct lttng_ust_event event_param;
+       size_t name_len = strlen(name);
+       uint32_t hash;
 
        /*
         * For this event, we need to lookup the loglevel. If active (in
@@ -146,6 +154,8 @@ int pending_probe_fix_events(const struct lttng_event_desc *desc)
 
                ev_ll = *desc->loglevel;
                loglevel = get_loglevel(ev_ll->identifier);
+               if (!loglevel)
+                       loglevel = get_loglevel_value(ev_ll->value);
                if (loglevel) {
                        struct session_loglevel *sl;
 
@@ -154,27 +164,68 @@ int pending_probe_fix_events(const struct lttng_event_desc *desc)
                                struct ltt_event *ev;
                                int ret;
 
+                               memcpy(&event_param, &sl->event_param,
+                                               sizeof(event_param));
+                               memcpy(event_param.name,
+                                       desc->name,
+                                       sizeof(event_param.name));
                                /* create event */
                                ret = ltt_event_create(sl->chan,
-                                       &sl->event_param, NULL,
+                                       &event_param, NULL,
                                        &ev);
-                               /*
-                                * TODO: report error.
-                                */
-                               if (ret)
+                               if (ret) {
+                                       DBG("Error creating event");
                                        continue;
+                               }
                                cds_list_add(&ev->loglevel_list,
                                        &sl->events);
                        }
                }
        }
 
+       /* Wildcard */
+       {
+               struct wildcard_entry *wildcard;
+
+               wildcard = match_wildcard(desc->name);
+               if (strcmp(desc->name, "lttng_ust:metadata") && wildcard) {
+                       struct session_wildcard *sw;
+
+                       cds_list_for_each_entry(sw, &wildcard->session_list,
+                                       session_list) {
+                               struct ltt_event *ev;
+                               int ret;
+
+                               memcpy(&event_param, &sw->event_param,
+                                               sizeof(event_param));
+                               memcpy(event_param.name,
+                                       desc->name,
+                                       sizeof(event_param.name));
+                               /* create event */
+                               ret = ltt_event_create(sw->chan,
+                                       &event_param, NULL,
+                                       &ev);
+                               if (ret) {
+                                       DBG("Error creating event");
+                                       continue;
+                               }
+                               cds_list_add(&ev->wildcard_list,
+                                       &sw->events);
+                       }
+               }
+       }
+
+       if (name_len > LTTNG_UST_SYM_NAME_LEN - 1) {
+               WARN("Truncating tracepoint name %s which exceeds size limits of %u chars", name, LTTNG_UST_SYM_NAME_LEN - 1);
+               name_len = LTTNG_UST_SYM_NAME_LEN - 1;
+       }
+       hash = jhash(name, name_len, 0);
        head = &pending_probe_table[hash & (PENDING_PROBE_HASH_SIZE - 1)];
        cds_hlist_for_each_entry_safe(e, node, p, head, node) {
                struct ltt_event *event;
                struct ltt_channel *chan;
 
-               if (strcmp(name, e->name))
+               if (strncmp(name, e->name, LTTNG_UST_SYM_NAME_LEN - 1))
                        continue;
                event = e->event;
                chan = event->chan;
@@ -209,6 +260,7 @@ struct ltt_session *ltt_session_create(void)
        CDS_INIT_LIST_HEAD(&session->chan);
        CDS_INIT_LIST_HEAD(&session->events);
        CDS_INIT_LIST_HEAD(&session->loglevels);
+       CDS_INIT_LIST_HEAD(&session->wildcards);
        uuid_generate(session->uuid);
        cds_list_add(&session->list, &sessions);
        return session;
@@ -219,6 +271,7 @@ void ltt_session_destroy(struct ltt_session *session)
        struct ltt_channel *chan, *tmpchan;
        struct ltt_event *event, *tmpevent;
        struct session_loglevel *loglevel, *tmploglevel;
+       struct session_wildcard *wildcard, *tmpwildcard;
        int ret;
 
        CMM_ACCESS_ONCE(session->active) = 0;
@@ -229,6 +282,8 @@ void ltt_session_destroy(struct ltt_session *session)
        synchronize_trace();    /* Wait for in-flight events to complete */
        cds_list_for_each_entry_safe(loglevel, tmploglevel, &session->loglevels, list)
                _ltt_loglevel_destroy(loglevel);
+       cds_list_for_each_entry_safe(wildcard, tmpwildcard, &session->wildcards, list)
+               _ltt_wildcard_destroy(wildcard);
        cds_list_for_each_entry_safe(event, tmpevent, &session->events, list)
                _ltt_event_destroy(event);
        cds_list_for_each_entry_safe(chan, tmpchan, &session->chan, list)
@@ -254,10 +309,20 @@ int ltt_session_enable(struct ltt_session *session)
        cds_list_for_each_entry(chan, &session->chan, list) {
                if (chan->header_type)
                        continue;               /* don't change it if session stop/restart */
+               /*
+                * Because we don't use any timer in the application, we
+                * currently cannot guarantee that we have frequent
+                * events that let us detect 27-bit overflows.
+                * Therefore, for now, we force large event headers,
+                * which contain 64-bit timestamps.
+                */
+               chan->header_type = 2;  /* large */
+#if 0
                if (chan->free_event_id < 31)
                        chan->header_type = 1;  /* compact */
                else
                        chan->header_type = 2;  /* large */
+#endif //0
        }
 
        CMM_ACCESS_ONCE(session->active) = 1;
@@ -336,8 +401,8 @@ struct ltt_channel *ltt_channel_create(struct ltt_session *session,
                                       size_t subbuf_size, size_t num_subbuf,
                                       unsigned int switch_timer_interval,
                                       unsigned int read_timer_interval,
-                                      int *shm_fd, int *wait_fd,
-                                      uint64_t *memory_map_size,
+                                      int **shm_fd, int **wait_fd,
+                                      uint64_t **memory_map_size,
                                       struct ltt_channel *chan_priv_init)
 {
        struct ltt_channel *chan = NULL;
@@ -406,6 +471,26 @@ void _ltt_loglevel_destroy(struct session_loglevel *sl)
        _remove_loglevel(sl);
 }
 
+int ltt_wildcard_create(struct ltt_channel *chan,
+       struct lttng_ust_event *event_param,
+       struct session_wildcard **_sw)
+{
+       struct session_wildcard *sw;
+
+       sw = add_wildcard(event_param->name, chan, event_param);
+       if (!sw || IS_ERR(sw)) {
+               return PTR_ERR(sw);
+       }
+       *_sw = sw;
+       return 0;
+}
+
+static
+void _ltt_wildcard_destroy(struct session_wildcard *sw)
+{
+       _remove_wildcard(sw);
+}
+
 /*
  * Supports event creation while tracing session is active.
  */
@@ -426,7 +511,9 @@ int ltt_event_create(struct ltt_channel *chan,
         * creation). Might require a hash if we have lots of events.
         */
        cds_list_for_each_entry(event, &chan->session->events, list) {
-               if (event->desc && !strcmp(event->desc->name, event_param->name)) {
+               if (event->desc && !strncmp(event->desc->name,
+                               event_param->name,
+                               LTTNG_UST_SYM_NAME_LEN - 1)) {
                        ret = -EEXIST;
                        goto exist;
                }
@@ -803,6 +890,19 @@ int _ltt_event_metadata_statedump(struct ltt_session *session,
        if (ret)
                goto end;
 
+       if (event->desc->loglevel) {
+               const struct tracepoint_loglevel_entry *ll_entry;
+
+               ll_entry = *event->desc->loglevel;
+               ret = lttng_metadata_printf(session,
+                       "       loglevel.identifier = \"%s\";\n"
+                       "       loglevel.value = %lld;\n",
+                       ll_entry->identifier,
+                       (long long) ll_entry->value);
+               if (ret)
+                       goto end;
+       }
+
        if (event->ctx) {
                ret = lttng_metadata_printf(session,
                        "       context := struct {\n");
This page took 0.026688 seconds and 4 git commands to generate.